From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id 490083858434 for ; Thu, 10 Nov 2022 16:25:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 490083858434 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 8CAAA100460C7 for ; Thu, 10 Nov 2022 16:25:36 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id tAMyo9y9UeAe4tAMyoJury; Thu, 10 Nov 2022 16:25:36 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ycp4Wydf c=1 sm=1 tr=0 ts=636d2600 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=mDV3o1hIAAAA:8 a=M5GUcnROAAAA:8 a=mNl5f2XD-MANQH1hkL0A:9 a=Dea_Pg1l_RIA:10:uccc_2email_address a=_FVE-zBwftR9WsbkzFJk:22 a=OBjm3rFKGHvpk9ecZwUJ:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=m32M3EWs0DFmbja8ew2Io8YkaNhqDtsbjs9torjwcPs=; b=vLNlOqrFsbARV6vCr+U0zE3dG6 QndPaXKRIvfMoQRDeKFhcwPNz+bvhXDWWUgReem9Kr+uyOPdhyl6zuXqNw/nvZA52g9jvh+N11Crs Z5O/EEzixCnqIA5nwyisxYAKx; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56826 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1otAMy-001K6D-38; Thu, 10 Nov 2022 09:25:36 -0700 From: Tom Tromey To: apinski--- via Gcc-patches Cc: , , , Subject: Re: [PATCH] Use toplevel configure for GMP and MPFR for gdb References: <1667924955-9218-1-git-send-email-apinski@marvell.com> X-Attribution: Tom Date: Thu, 10 Nov 2022 09:25:33 -0700 In-Reply-To: <1667924955-9218-1-git-send-email-apinski@marvell.com> (apinski's message of "Tue, 8 Nov 2022 08:29:15 -0800") Message-ID: <871qqazshu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1otAMy-001K6D-38 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56826 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == apinski--- via Gcc-patches writes: Andrew> From: Andrew Pinski Andrew> This patch uses the toplevel configure parts for GMP/MPFR for Andrew> gdb. The only thing is that gdb now requires MPFR for building. Andrew> Before it was a recommended but not required library. Andrew> Also this allows building of GMP and MPFR with the toplevel Andrew> directory just like how it is done for GCC. Andrew> We now error out in the toplevel configure of the version Andrew> of GMP and MPFR that is wrong. Thank you for doing this. It's been on my to-do list to investigate this for quite a while, but I never got to it... :( One larger question I have is whether we should land this now, or wait until after GDB 13 branches. That is coming soon and maybe it's not good to add a new dependency just before the release. My inclination would be to defer it, I suppose out of conservatism, but I'd appreciate hearing from others. I think gdb/README and gdb/doc/gdb.texinfo need some minor changes, because the GMP-related configure options are being renamed. The commit message should mention "PR build/28500" somewhere so that the commit is logged to bugzilla. Also in gdb we've been using a "Bug:" trailer in the commit message that has the full URL of the bug. IIUC this does fix that PR. Tom