From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D86163858D39 for ; Wed, 19 Oct 2022 11:14:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D86163858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666178066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ygEjortG9LtOF3N5BkGGKMjVfzVHHtxUciYT0Pme+f8=; b=VscqVtfwcQkrZ5Y2MZhQUkdeoFmHqyFdyf/Dk6DnnLw3pgEVFWVvp1ehY+mdFOVCltBmOO JW7eJ1QI03hK7qTXjnGLYU/m590XmSwPdR3+4LkouRAZbZYqhzjW0FrnCfPNdx6DC0jb1E y2Ve2pyYWNTQzgoP7Yjbi7i/M2nRtf0= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-50-kiAsGdKFNlWEP2USRXgZWw-1; Wed, 19 Oct 2022 07:14:25 -0400 X-MC-Unique: kiAsGdKFNlWEP2USRXgZWw-1 Received: by mail-qk1-f197.google.com with SMTP id u9-20020a05620a454900b006eeafac8ea4so14576436qkp.19 for ; Wed, 19 Oct 2022 04:14:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ygEjortG9LtOF3N5BkGGKMjVfzVHHtxUciYT0Pme+f8=; b=CB+bHcCyEDreGjI5JJZMm6By8iHGC3Kqn+eVhjeHnatozvlKLrb8G1i6EBlAembI4l t+RauVXDkyZ6n7gHDwnddc8kDFywFrjqvECsRZDZEvT6cE8DWq5rMhnWz1Fo8c7Wami1 G7aQXO8uedLxh9hmdzijmpDn6J8wlw61dEc9Z55a6PebrzSs/K1MiclPeWQ2Wk+w292+ NDS8GjQ3BNO3WfPxbfj+2CWjgIwiYHKmlt901RktMXm/Eqp0Z+IDkBTMMlVObfIvs/09 W4vHI38upF7GjzYXiguoR2c+q5dRP9GWxrZRU8uU/6wHZzzaQ8O9FjvCWYv8lxKaCWwz pwrw== X-Gm-Message-State: ACrzQf0wJZ4LQ1UZoyqbggjB/QqXL6apHNLoBz8cP5R2yeOHQ0/QMi5b tO8WPAK4gAx+RXYTXMGrXVUqygwvCDB+8d7Sh8rLf/iTdGFMjpvrfx6rrmLqRXhNHzH7cjhu2CY lGPeqnPXcwsiI5UL27A== X-Received: by 2002:a05:622a:413:b0:39c:f1b4:b296 with SMTP id n19-20020a05622a041300b0039cf1b4b296mr5987360qtx.308.1666178064551; Wed, 19 Oct 2022 04:14:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4cfpDvBhv5PwHi8tE7jl0oIWd01UkMvJQ1sgbeaQTD0SyxLwQtVKMpYj61r6V/oMQB7aIM/A== X-Received: by 2002:a05:622a:413:b0:39c:f1b4:b296 with SMTP id n19-20020a05622a041300b0039cf1b4b296mr5987343qtx.308.1666178064311; Wed, 19 Oct 2022 04:14:24 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id bj41-20020a05620a192900b006bb29d932e1sm4659661qkb.105.2022.10.19.04.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 04:14:23 -0700 (PDT) From: Andrew Burgess To: zac.walker@linaro.org, binutils@sourceware.org Subject: RE: [PATCH v3] aarch64-pe support for LD, GAS and BFD In-Reply-To: <000401d8e3a0$0373e8b0$0a5bba10$@linaro.org> References: <027ae69a-636b-6757-297a-eec42936401e@linaro.org> <000401d8e3a0$0373e8b0$0a5bba10$@linaro.org> Date: Wed, 19 Oct 2022 12:14:22 +0100 Message-ID: <871qr4awvl.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Zac Walker via Binutils writes: > Sorry - this patch caused a build break: > > checking for PT_GETDBREGS... /usr/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.data.rel.ro+0x48): undefined reference to `aarch64_pe_le_vec' > /usr/bin/ld: ../bfd/.libs/libbfd.a(targets.o):(.data.rel.ro+0x17c0): undefined reference to `aarch64_pe_le_vec' > collect2: error: ld returned 1 exit status > make[4]: *** [Makefile:1276: as-new] Error 1 > > Investigating now and hope to fix soon (or roll back.) I just pushed the patch below to fix this issue. Just needed to run autoreconf. Thanks, Andrew --- commit 6d6ae7c23dd59fe16f3e366e969b927d97fe5e01 Author: Andrew Burgess Date: Wed Oct 19 12:00:42 2022 +0100 bfd: fix undefined references to aarch64_pe_le_vec After commit: commit c60b3806799abf1d7f6cf5108a1b0e733a950b13 Date: Wed Oct 19 10:57:12 2022 +0200 aarch64-pe support for LD, GAS and BFD It appears that bfd/Makefile.in and bfd/configure were not regenerated correctly. The differences in the configure file are only whitespace, but in Makefile.in a critical reference to pe-aarch64.lo was missing. diff --git a/bfd/Makefile.in b/bfd/Makefile.in index 3f520355829..b906976a1c0 100644 --- a/bfd/Makefile.in +++ b/bfd/Makefile.in @@ -1048,6 +1048,7 @@ BFD64_BACKENDS = \ pe-loongarch64igen.lo \ pe-x86_64.lo \ pei-aarch64.lo \ + pe-aarch64.lo \ pei-ia64.lo \ pei-loongarch64.lo \ pei-x86_64.lo \ @@ -1700,6 +1701,7 @@ distclean-compile: @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pc532-mach.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pdb.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pdp11.Plo@am__quote@ +@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-aarch64.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-aarch64igen.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-arm-wince.Plo@am__quote@ @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/pe-arm.Plo@am__quote@ diff --git a/bfd/configure b/bfd/configure index bae9d17c515..1c1760670cb 100755 --- a/bfd/configure +++ b/bfd/configure @@ -13604,7 +13604,7 @@ do aarch64_elf64_le_cloudabi_vec) tb="$tb elf64-aarch64.lo elfxx-aarch64.lo elf-ifunc.lo elf64.lo $elf"; target_size=64 ;; aarch64_mach_o_vec) tb="$tb mach-o-aarch64.lo"; target_size=64 ;; aarch64_pei_le_vec) tb="$tb pei-aarch64.lo pe-aarch64igen.lo $coff"; target_size=64 ;; - aarch64_pe_le_vec) tb="$tb pe-aarch64.lo pe-aarch64igen.lo $coff"; target_size=64 ;; + aarch64_pe_le_vec) tb="$tb pe-aarch64.lo pe-aarch64igen.lo $coff"; target_size=64 ;; alpha_ecoff_le_vec) tb="$tb coff-alpha.lo ecoff.lo $ecoff"; target_size=64 ;; alpha_elf64_vec) tb="$tb elf64-alpha.lo elf64.lo $elf"; target_size=64 ;; alpha_elf64_fbsd_vec) tb="$tb elf64-alpha.lo elf64.lo $elf"; target_size=64 ;;