From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BD0323858D37 for ; Wed, 10 Aug 2022 11:16:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BD0323858D37 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-75-t-iM-N_1O56FSovgQHbxrw-1; Wed, 10 Aug 2022 07:16:51 -0400 X-MC-Unique: t-iM-N_1O56FSovgQHbxrw-1 Received: by mail-wm1-f72.google.com with SMTP id x17-20020a05600c21d100b003a32dda6577so482244wmj.7 for ; Wed, 10 Aug 2022 04:16:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=rMFaRSCIyPSnsnKoQLUZKawORBIiXJ5d8f8tWilDaSY=; b=HaWib0GGcLH7CzdpVVRTtTuM3qt3UwYc+d/G0XZljKQxopUrGdnCNdqLLCM61/pYlM dce6ckF6mLQuGojwtpoMiAy+7kkmjU++tGwNI6cjyAODhNCYNR3+wk4WEFnd4UARIX/8 YekjuNQyaHq2f21d5nMxKkA72bnGa/1vbaDiKPOeq9QKdibcNsDrdOR31YHJDR/WpWX7 LQHKCAM1QBsTehsm8eSwZ8OJbsQH826pbv0Dp+2mWf4SO4OhexTk+M4us8+9zp8FxQmk BceYLTGRAwJb2dOMP+SfF8F0xXiIru9dNQuUBKiirCF1dKsqZ0lGmeikxLiPrERjG2RM Qfnw== X-Gm-Message-State: ACgBeo0Di/5A0Ra0c5hHeBcENghbUD/31qWLAZGd+EIUHAIqj+LzgEhx Nwh4vRlsi8mrS6mhNCCqA9/iG2jCl1UsK+YFn+Ih5cLjF9Alidh7Py0CtN8Xd7plLZ3iOAU66oE e/7AKH7GcdvmKoiTucVMnYOnMe3+VVCzYMbAxGEWQe3mTB6HSk06RGIuq3q8FZVPe6MEu3w== X-Received: by 2002:a05:6000:811:b0:220:6262:ac66 with SMTP id bt17-20020a056000081100b002206262ac66mr16051986wrb.529.1660130209044; Wed, 10 Aug 2022 04:16:49 -0700 (PDT) X-Google-Smtp-Source: AA6agR5nVJZCIvYm4JRdr1Sw0H4w1004NPAEFVlKlBNx58hNatujuz6zvlcWuN6C/byZ4ah1lh0/Pg== X-Received: by 2002:a05:6000:811:b0:220:6262:ac66 with SMTP id bt17-20020a056000081100b002206262ac66mr16051972wrb.529.1660130208810; Wed, 10 Aug 2022 04:16:48 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id d15-20020adfe84f000000b00220628ef654sm15599219wrn.24.2022.08.10.04.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 04:16:48 -0700 (PDT) From: Andrew Burgess To: Tsukasa OI via Binutils , Tsukasa OI , Nelson Chu , Kito Cheng , Palmer Dabbelt Cc: binutils@sourceware.org Subject: Re: [PATCH 1/4] RISC-V: Fix immediates to have `immediate' style In-Reply-To: <811c2c02e7ad0afe48eb2b8a2db210c823cdd9a2.1659500861.git.research_trasio@irq.a4lg.com> References: <4919138bb21768d0cdc3a6da81dbbbd62cc96855.1657719581.git.research_trasio@irq.a4lg.com> <811c2c02e7ad0afe48eb2b8a2db210c823cdd9a2.1659500861.git.research_trasio@irq.a4lg.com> Date: Wed, 10 Aug 2022 12:16:46 +0100 Message-ID: <871qto1h7l.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 11:16:54 -0000 Tsukasa OI via Binutils writes: > This commit fixes certain print calls on immediate operands to have > `dis_style_immediate'. > > opcodes/ChangeLog: > > * riscv-dis.c (print_insn_args): Fix immediates to have > `immediate' style. > (riscv_disassemble_data): Likewise. I'm not a binutils maintainer, so can't approve this patch. But... ... this looks good to me, with just one minor comment, see below. > --- > opcodes/riscv-dis.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c > index 164fd209dbd..fe091f294e7 100644 > --- a/opcodes/riscv-dis.c > +++ b/opcodes/riscv-dis.c > @@ -472,7 +472,7 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info > break; > > case 'y': > - print (info->stream, dis_style_text, "0x%x", > + print (info->stream, dis_style_immediate, "0x%x", > (int)EXTRACT_OPERAND (BS, l)); > break; > > @@ -541,17 +541,17 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info > if (riscv_csr_hash[csr] != NULL) > print (info->stream, dis_style_text, "%s", riscv_csr_hash[csr]); You haven't updated this line, but, I wonder if this should be dis_style_register? Otherwise, LGTM. Thanks, Andrew > else > - print (info->stream, dis_style_text, "0x%x", csr); > + print (info->stream, dis_style_immediate, "0x%x", csr); > break; > } > > case 'Y': > - print (info->stream, dis_style_text, "0x%x", > + print (info->stream, dis_style_immediate, "0x%x", > (int) EXTRACT_OPERAND (RNUM, l)); > break; > > case 'Z': > - print (info->stream, dis_style_text, "%d", rs1); > + print (info->stream, dis_style_immediate, "%d", rs1); > break; > > default: > @@ -907,7 +907,7 @@ riscv_disassemble_data (bfd_vma memaddr ATTRIBUTE_UNUSED, > (*info->fprintf_styled_func) > (info->stream, dis_style_assembler_directive, ".byte\t"); > (*info->fprintf_styled_func) > - (info->stream, dis_style_assembler_directive, "0x%02llx", > + (info->stream, dis_style_immediate, "0x%02llx", > (unsigned long long) data); > break; > case 2: > -- > 2.34.1