From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from t05.bc.larksuite.com (t05.bc.larksuite.com [209.127.231.55]) by sourceware.org (Postfix) with UTF8SMTPS id A0C083858291 for ; Mon, 21 Aug 2023 06:27:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0C083858291 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1692599256; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=OgYQ09k9O8IIp8NxnHFJGYxxLN9QWRu/fmwVy1kWi+o=; b=EXq+iraNpDR67hPcbSKron8XuyihIoZnKN7dFdrFIhBb2bsocQJL/RvcTUzxZelc6LpYog GhmOvsvyQshw97fu440I5Y+SB2qjSNln5XOsKTM1du6/lc3WMu9ORjvrov/7YQWbhUC+S7 hUu1Ilc2Nr6eeqyM4YOxO9L30GOGzVEvxvx1SrFJIRB0779LuRbvVKlFGP9Fhw9a35SUrz RMoxTmgNqQxjvDe6I1SbHwsCp+46nNDpMfpz7I5fqBOsgZTfgvY5c7peV574ezRkfFgFJc g/MJxEp5C9hWoub82uZHP9gCtyPc3VSDrPly1eiO7kOFYT9mOlC4x4bGP7wyEw== Mime-Version: 1.0 X-Lms-Return-Path: X-Original-From: Ying Huang Date: Mon, 21 Aug 2023 14:27:33 +0800 Message-Id: <8725cca2-4c4d-f32d-fc8c-3c6c194c481c@oss.cipunited.com> To: "Maciej W. Rozycki" , "libc-alpha" Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils References: <114fe517229b8cc0e504238f0d8553dd3528f5e9.568cb3db.66b5.4ad3.826b.3b027f1ea47e@feishu.cn> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Transfer-Encoding: 8bit Content-Language: en-US Cc: , "binutils" From: "Ying Huang" Content-Type: multipart/alternative; boundary=692c73040350b4e82678c9c312f613ace22f65083f8a6ccec496d5d5eae5 In-Reply-To: <114fe517229b8cc0e504238f0d8553dd3528f5e9.568cb3db.66b5.4ad3.826b.3b027f1ea47e@feishu.cn> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_INVALID,DKIM_SIGNED,HTML_MESSAGE,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --692c73040350b4e82678c9c312f613ace22f65083f8a6ccec496d5d5eae5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi Maciej, Can you help commit=C2=A0 these two patchs? Thanks, Ying =E5=9C=A8 2023/8/18 18:10, =E9=BB=84=E8=8E=BA =E5=86=99=E9=81=93: > Hi Maciej, > I have submitted pacthv10 including changing all E_MIPS_* to EF_MIPS_, an= d also updatebinutils & submit patch. > Thanks, > Ying > From: "Maciej W. Rozycki" > Date: Sat, Aug 12, 2023, 01:43 > Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils > To: "Florian Weimer" > Cc: "Richard Sandiford", "Ying Huang", "libc-alpha", , > Hi Florian, Cc-ing binutils now, to get a record of this discussion there= . > > The EF_* definitions were added on top of preexisting E_* macros back= in > > 1998 by Ulrich Drepper with commit c3966b88eeb ("Update.") and only= this: > > > > * elf/elf.h: Add lots of new symbols from Irix and Solaris. = > > My concern was adding EF_* constants to glibc that duplicate E_* > cons= tants that are used in binutils. I think we should either change > binutils= to use the EF_* constants, too, or for these legacy constants, > use the E= _* prefix in glibc as well. It's not a problem: as long as we reach consens= us I can update binutils accordingly, and we can discard E_* constants from= there at any time if needed as they are for BFD use only and we don't offe= r any stable BFD API. > Not sure if this a reasonable position, though. So = I did a little more research on this topic and came across this thread of m= ine from decades ago, and specifically this message coming from the lost wo= rld: > . Clearly IRIX = used to use EF_* macros, just as I thought and just as has used the Linux k= ernel (and MTI never came to finishing their promised psABI spec, where it = only says "To be supplied" in the relevant part[1]). So while we may have t= o keep the few already existing in , just because we were unfortunat= e enough to make them a part of our API back in 1996: * elf/elf.h: Add some= new constants from recent Cygnus ELF header files. having likely taken the= m as a Cygnus invention without due consideration, I think we ought to refr= ain from adding new E_* macros and stick to EF_* instead. NB the whole thre= ad referred above might be worth reviewing for anyone interested in these m= atters. Here's a reference for the earlier part: as the dis= cussion started on the old MIPS/Linux mailing lists first and then was carr= ied over to > binutils as well. References: [1] "MIPS ABIs Described", MIPS Technologie= s, Inc., Document Number: MD00305, Revision 1.3, 2002/12/02, Chapter 7. "EL= F object code", p. 24 Maciej= --692c73040350b4e82678c9c312f613ace22f65083f8a6ccec496d5d5eae5--