From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 141513858D32 for ; Thu, 27 Apr 2023 09:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 141513858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33R6Hx0c022590; Thu, 27 Apr 2023 09:59:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=/wyYjyJdIgJs4Af/JEhn4HbHvQ72fKcvLovp3zseLWA=; b=BIMZHk+Z1Qu1souvbqAzIZq6FxG+SlrF+ay0FqpQmpTLE8jfqgQCpWSXcYPDKCbEYo+H xkzWVYiS+jFCYeoJo4/Cs8371NWpqfrhX99IgiTpnKEg1mOWJcYr2tbUNfPxvh9ajwhM ng7v9QLarmMOGiiNCkc3HclcYlG1J5hkqVzsMb0/6JHB5GzKQJFpqHm2ezYX2DjsqCs5 xCZcwvxwwHR+VLd8r9EQm1PEyoNuX1v37o92J1umW14qsHU/GWv78jWAgPH4a7rLlPUf zxRi9uTVCJZF6eNUJjZZHfmv0KXoPZQ2dZrpmavha3i9itFW+1CCMRAemSnJRnL01lK0 WQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3q47fauf5a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Apr 2023 09:59:40 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 33R7vBCK032610; Thu, 27 Apr 2023 09:59:40 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2044.outbound.protection.outlook.com [104.47.56.44]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3q4619br9u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Apr 2023 09:59:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=USxezYph38ON28a2j5FCrvKKJXzFMG+DKFI46qPkBRKz7iN/8vL6NhrdYIPK9e/qhq9/wRiisELwx/vgsaENiGYtrlU85vShaFwj5cDguHD2nnOQPXBvNQS0vrB5Ekb261PciLmYPzOppgoH235aRGCIH5S5Tsa/NCUM+FYPKnKsSvv3+a0oW0QHm4SGryHfw3RyZ1XsUXCg4kKOfaKciWTi5wsEQA7V/AhJhTKhALSSLU7P9OMVMmC3odGwc13sfYuESzNma4AxoqsGdUH+UbC2yzFRmsmprcfioZJgE9Jg+oOz/K3w0RfT0gj6gFhCZU4cMKBR6Y9R2iB901rM/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/wyYjyJdIgJs4Af/JEhn4HbHvQ72fKcvLovp3zseLWA=; b=W6UBSNeKB7SXp/eMawxXHOqJZ2jlcdgUKH/iJGVrFAq1+j1SmmZk5MbChuTZaOfJFLCngFOk+e7mfgn+k5HuQCfet3L0Lf5ujC2k0LftnjjZG++a2SPSvBSGmjyxDl4Uz1HQ3U85PTErVNsiOG3rXGabpBaJfLtSBe2chfqwhHSVh24qvm9s4VemX5vvsxlLNQtbe/hr17ubU1Up6VvrP8JfUgL321IfIPIZPU2GIjO8gEjMSoHcZfbox/QXMamzW4ixbYT9f5fYn0+kRq778TtZsMeGDuKzPK60R/4oOB2jUHui+MyygUyy1PvE9We44qJInbLGRyepW1HC0jRsZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/wyYjyJdIgJs4Af/JEhn4HbHvQ72fKcvLovp3zseLWA=; b=cEYRfx78QdCOzGQOwosG9AfXSYqcNqnj6KfZqFkUHuxdZ8PbuQBIzeJrfP6hZ0b6UDay4a93CA+wjjdoiYno4yRZXJFcIlfoh6mP6vwaxSlmPtkL4W8z2y2F8bmAH0QFJNPEqgmRsmSA/E87QAArxgxyNcemVRykoGG7O8VrOeM= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by DS7PR10MB5926.namprd10.prod.outlook.com (2603:10b6:8:86::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Thu, 27 Apr 2023 09:59:35 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::d8ec:1377:664:f516]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::d8ec:1377:664:f516%6]) with mapi id 15.20.6340.022; Thu, 27 Apr 2023 09:59:35 +0000 From: "Jose E. Marchesi" To: Jan Beulich Cc: binutils@sourceware.org Subject: Re: [COMMITTED 2/3] gas: BPF pseudo-c syntax tests In-Reply-To: <3ce08588-8065-473a-2ff8-d2c412406cbb@suse.com> (Jan Beulich's message of "Thu, 27 Apr 2023 10:26:13 +0200") References: <20230426173123.24564-1-jose.marchesi@oracle.com> <20230426173123.24564-2-jose.marchesi@oracle.com> <3ce08588-8065-473a-2ff8-d2c412406cbb@suse.com> Date: Thu, 27 Apr 2023 11:59:29 +0200 Message-ID: <87354labni.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0071.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::35) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|DS7PR10MB5926:EE_ X-MS-Office365-Filtering-Correlation-Id: 14387add-5399-458f-fe4b-08db47061ac8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hPDMG9vrrCkxOJKmmA58GdDiMHQO8LJzummepENQ6AcRN3q06O7kDMuD/A7liEkyKZPY/ylEd7iv0jTEtKNbKwHse6e1qSl4L7sRD6qad5ViSvEaJq9Yo2zytX98YH9bMemYwZI6FCxKUeAEsa341j2vuItaKXLfz37VhDAqirEba8p4lHRPpVLkyWpVGe0cD4sfi2UjorORSuqsdaAVg+0bKf/hG96DIRKs13HxOQN0OGgb1Qi+jEwaCc47cSae/t/H2BUY+Ffrq7At+nOHlVPwYxAtnr3u3U5ry59bWcT857gN0TPFUPIg+MaWQ81gd3Fdh5j/hYSMfmPQEH2aOKhLLl9vpi2tfMp1SNnmNtMPiK+ABu8n5Yuw+PlKCtTz9ZoUZJTP52GI1Jv4uqw8M8KxktJdxLHSrapnqAzDyq+gaSky3McuRtROjK85ltaLMbfiVmKAVkT0IpzVJXnd7Q2Lmq2spYBMK91uRLDQ1puBHGd4ltBM6Adb5VkFHcjqJLkikEiuTIzFWyzBvXSvXemcp0dbyH1f+BSqLRlIzv7ANbaC6rPdGJtmmsyvSwAk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(136003)(366004)(376002)(396003)(451199021)(4326008)(66476007)(66556008)(66946007)(5660300002)(316002)(41300700001)(6916009)(8936002)(2906002)(8676002)(86362001)(478600001)(38100700002)(6486002)(2616005)(6666004)(36756003)(83380400001)(6512007)(186003)(26005)(6506007)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GhaKtd2c18G8WR/mo8RHZtdQZVJ+Y3s7NR2G/IcacG9nwms87WAthbiST46T?= =?us-ascii?Q?dioMIjFAMpwBQFeyYXoPy+1o3/dGBuX3p+N7ay+ccpHfX2uiJVVfz9oB/eZu?= =?us-ascii?Q?q2SZy53g6iEz4QWetuIyK3lCD5ut1rHjl3yrWeDYkadVostLUBd9BNzpD3H5?= =?us-ascii?Q?cdCPq7eD76qXQcggdMPhtE1Dr/b/AQ+vvutLB+Ew7JNIdHcNaDa2QVcOaWXl?= =?us-ascii?Q?ELgQmCQYMpfo7A8FkHZaVGWHDXww6kQfYCPxcMmzrm+jvAii+2f/phpwU3Xi?= =?us-ascii?Q?onrQFAwhhMCXeewymCYmeymSkHRFe5qwEOB4vfPzOrDrX+RNujxhDFYdyMUB?= =?us-ascii?Q?eGiG/iaXgVDydvBdT8l/vUO+9Vy8Cm9JhkHYjLH/xjTJRzoAmevzTz2S17pK?= =?us-ascii?Q?+LeHTh9N7ez+soq5lqLE1qdVun5LrZwm2kd3XdwBjTaPHkSqnSU8uGfzXtsy?= =?us-ascii?Q?bdeXj06kteh/19Rl+rnweXB63reRRHRRUGQIl/76ITN2h0KG3CkodFWbDyCe?= =?us-ascii?Q?WgR+QfykeGT6eLqYSYrFyJzgA2wZBhyqJJGLrKLvbz8ORYVwFwteMaN3ql23?= =?us-ascii?Q?ElGArxGjlWgbPaqT8TIuyckFmmirhC85CEh15p8vyr3ONGMx+3kmVDG9WfEw?= =?us-ascii?Q?JcMIupU60e8JzLNGlaQe3ZCyNzI6MA2ocYPZjbD95qBF4cm0tX6WNMtCps3f?= =?us-ascii?Q?4CVjBIRUt7Vq1lLuFNheUtxlKUscUfemi/4qDuO5+UXTiWoddTwCaIqS+K4B?= =?us-ascii?Q?7kOXLhP5a9eKmlKakSzUqP7lwtoweRG6wxrcc6yQk+qSKQDIDSvf0O2K0d2r?= =?us-ascii?Q?4OR9vJw7xDQgYY5WEQFfr2Ghsj0b/GLVkxljSHzU+NrRf0DvcX86aq1x0fqs?= =?us-ascii?Q?/8HiV+bMYG+Jg3AwhaDCuWTfHldKc/VYtXyqBg1vycGFSwULXezlNB5enLYS?= =?us-ascii?Q?jvRNZfKlbV/iXJ4oiXMv0/yn+MaKG5/T55HYjWh7fox/YQ/hG+SzI+t3bXap?= =?us-ascii?Q?FjN1xbqtBIm//auJ3OYfX3uMciNqSpv3aYMSbxkLfYLkXDGVM/BRvci7nNUA?= =?us-ascii?Q?JR42qID8bbNzyhxDzYGeYfb7yHxjbSFGa+9usFgRHS1Piss3P8s2rylie/PU?= =?us-ascii?Q?vyvqKbt45GAH5yW+HkRttlLhMaDzcG4r0nmCVwsVMOSRTWHiYp7Q/ufA37bu?= =?us-ascii?Q?+6itq11x+lMPKT/5HQM+JZmeFO0p0kn3RpK6e4IyEfeqwHEi0LW+xToNsedg?= =?us-ascii?Q?BG6bn7hSJO2Rv3bbg/jM3h+PLZMajpGbojPVaNJs8lRx27TyUpg0qJy8nLMT?= =?us-ascii?Q?n8LTJlxIE80tLGQ8CL6ITcmPPuetsR5ZQC5FBgWibDLnpRLO8+PaKy6Edh+l?= =?us-ascii?Q?Ae7kTIss/TTy0ewKJ7ojWO7QCp7E7h4AT4swnDColJI/bzidKhhMgPO4YFUb?= =?us-ascii?Q?HX9oiLPKPhUKCjdRnzNwJF2PvFvhMdvsiYMxT3uskZm3x673E0Fz9n+sYuQs?= =?us-ascii?Q?5dhXa4tvf/e3YRaWFFfjY3N2ds3X3DWix5Uh39MXCLdegULkckCp+ezMUV6S?= =?us-ascii?Q?1BEFVLGAl9WUJGN0lpPfYdU1/HvY5v+qB5SPTu1a3l8Gi0Yxqk3rmIUwMZt6?= =?us-ascii?Q?VQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: KwQ/wW7GfBMrX7khXSZJkd2eM9vV2rc2VcqtATS0iP2kWtNUcDEfOmTdQ+n+YL4fFPz+SEEss6qtCTrlHZX7vErX9iqAAyc9ogz8hDcAluAoRNbnf3Vfj8ogq9SkQ32ROm5EG05swvyePjN7SCtGpgukmhRqO4yIvzPsMkG6ILzjk/kkgSuAhfTH4at4mSDjXwqcPBPAmetKQ8tUPdBfAEmTx4/vrmmPTYgbbW1QbcuUTj0z087gBkOs15eI5jVjA6VWFDscUlwXpe2UbDoU19UuxqlBvj7JzVE0uQOVIuokpYk9zXMScPIzCyilB9JAHUao6gDtApPBlkzNI+XNhW5nTdZjJyy70ctGqGhlJxxZ7siE/BvskliWWFCh/30JKJfz2u9PAr0gmO0CuorkKHo4KPM/C+gtZmMfFHZacMWIL+K5odwAOcoL7KH8tm2tUTNbZol+A+5ERY+S1ND2TZp/Nrgv663ZvCeFCBoLI4HK0knlTUew2xHEG1KmLzdBkB4OJw8cwNsqU4Z9uAvSBjQyl7Ijz4ySEP3+m33hXXioUwbi6oe2uQk7+tuMs/zOdu3YDk6NR3/V6qN7rMl24CpApcVreiAicJX+joHVv/l605+niporoJv1z74SBSNxt7sRmZcZlxAXBOM+P1LuzDiPTwdD06b67n8nRdD9x2CCY2vjdlXNuEWAr/yWK3gwu2+gbLJ1f/prXNkSpK1VYfCDdOC+L6gFiRFHPi7WFabWak7zM82+pMlEyMd3zOBvQ3Jyd5PzBq6Q1QdNT/MF3SD7rTPDt6x1n6KXu1qcyzo= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14387add-5399-458f-fe4b-08db47061ac8 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2023 09:59:35.1170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CqU6mz1HChUkccfZ2agDjOn0b0QhJL3Ug+cKVFvXZZGcXvNkoM1OXB6fYgxb8+PoNP0ukcJ3AJun1o46Wmo3cr5s5K1hxHGmkqV2P1Sj3LU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5926 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-27_07,2023-04-26_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304270087 X-Proofpoint-ORIG-GUID: UIO1V4aUGcsge0kD_ROfqtWYa4zh2Z6D X-Proofpoint-GUID: UIO1V4aUGcsge0kD_ROfqtWYa4zh2Z6D X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 26.04.2023 19:31, Jose E. Marchesi via Binutils wrote: >> --- a/gas/ChangeLog >> +++ b/gas/ChangeLog >> @@ -1,3 +1,23 @@ >> +2023-04-20 Guillermo E. Martinez >> + >> + PR gas/29728 >> + * testsuite/gas/all/assign-bad-recursive.d: Skip test in bpf-* >> + targets. >> + * testsuite/gas/all/eqv-dot.d: Likewise. >> + * testsuite/gas/all/gas.exp: Skip other assignment tests in bpf-*. > > I view doing such as problematic. Looking at what patch 3 documents, > the uses of " = " are pretty limited, and ones not naming a register > on the lhs (or, for store forms, on the rhs) ought to be fine to > retain their meaning. Sadly there isn't an easy way to specify target- > specific flags, or else I'd be inclined to suggest that you have an > option to suppress recognition of the C-like syntax (which may be a > good idea anyway, as people might be using constructs like the ones > used in the testcases you now disable) and use it here and below. Hmm, actually the assembler is supposed to first try to recognize normal syntax, including expressions such as SYMBOL = VALUE. Then to fallback to the pseudo-c syntax in case the above fails to parse. I will take a look (Guillermo is no longer working with us.) It may be that we don't need to disable these tests at all. > In any event, ... > >> --- a/gas/testsuite/gas/all/eqv-dot.d >> +++ b/gas/testsuite/gas/all/eqv-dot.d >> @@ -2,7 +2,7 @@ >> #name: eqv involving dot >> # bfin doesn't support 'symbol = expression' >> # tic30 and tic4x have 4 octets per byte, tic54x has 2 octets per byte >> -#notarget: bfin-*-* *c30-*-* *c4x-*-* *c54x-*-* >> +#notarget: bfin-*-* *c30-*-* *c4x-*-* *c54x-*-* *bpf-*-* > > ... at least in cases where there already are justifying comments, new > additions of exceptions shouldn't go uncommented. Yes, will do, in case it is necessary to keep the skips. >> --- a/gas/testsuite/gas/bpf/alu-be.d >> +++ b/gas/testsuite/gas/bpf/alu-be.d >> @@ -1,5 +1,6 @@ >> #as: --EB >> #source: alu.s >> +#source: alu-pseudoc.s >> #objdump: -dr >> #name: eBPF ALU64 instructions, big endian > > I may of course be reading binutils-common.exp's run_dump_test wrong, > but is this having the intended effect of assembling each of the files > once and checking objdump output for each of them? It looks to me as > if only the assembling step would be performed for both, which I don't > think is what is wanted. It was an attempt to avoid having to replicate the same contents in alu-be.d and alu-be-pseudoc.d. Will look into this too. >> --- a/gas/testsuite/gas/macros/macros.exp >> +++ b/gas/testsuite/gas/macros/macros.exp >> @@ -82,6 +82,7 @@ switch -glob $target_triplet { >> rl78-*-* { } >> rx-*-* { } >> vax-*-* { } >> + bpf-*-* { } >> default { run_list_test dot "-alm" } >> } > > How is this test affected by your changes? It consists of only labels > and directives afaics, so insn syntax expectations shouldn't matter > at all. > > Jan