From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 2B99A3858D32 for ; Thu, 6 Apr 2023 11:46:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B99A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3366x3hp009591; Thu, 6 Apr 2023 11:46:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=GMNqrFApJdEqSkHw4q64Cgb8Ij8wFEjgXKIN9GryKn4=; b=1dYf8AuABn8IpLuZk6HnpvyG7Aiko6Tys93V0QDMOwYzSeVXAQ15yU0+xSvKs1lGRMrA lDbahytSp4HUBy4L3al4pydLfqNhL4hm1UPp3cTGvn8Gw48ZoaBk6FVYeFxtvF9ad7BQ 0YwO+FHgtQgQaR2uObUygfANlUSsvUxsvfirwZxPLxRljgHi6b0RJ3qk3xKFmbeeG79x LVbrU6cuUbPqkIRBtHDgQz5J1JYjeC7Zb3PphzLvdQKHYm+hv7Wtdku3NwhDHQKH7ZYW kVkmYYgV8tp4JIl7670jsLGXZ/vwGRYL4tSoR7EPdkdUIdOcLWsaAlGAfb42znoN9eHP 4g== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ppcnd2pwy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Apr 2023 11:46:57 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 336AOVnB037728; Thu, 6 Apr 2023 11:46:56 GMT Received: from pps.reinject (localhost [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3pptjv4n97-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Apr 2023 11:46:56 +0000 Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 336Bku4J007569; Thu, 6 Apr 2023 11:46:56 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3pptjv4n8k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Apr 2023 11:46:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g6xxaPEW1HDID9R17jAumb5IvwKOalHQrv/P8xDYwDRixIkhTbXo8GoojCc2CyYLh+VlxBgfNJF9oavlMIbEBHdicNhNvmlnmRuTxz+HWHX+gMa/gdm2QZudprX9uFX0PiQud6wWMj3+WnBq53Ct+/ZqD0+TWq/dh3ZAApuX+GsUxZ2P5t6K06LECNd7n6ozB12f0Y8dxafQ3G20oH+NxX9Cryo6czrXy1PkfsMLxV/4iRhaWVep9C0Nmn/VSmddhpeP/JS6y6ERoZQnrBcp7MkWOoppX/Tg3vKm72sLwrFZ3OjltB/CW7HRdzvKVXhp62kKaTmeOQclVLfzaytLgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GMNqrFApJdEqSkHw4q64Cgb8Ij8wFEjgXKIN9GryKn4=; b=g4z43w/kaXyQ/E+VluzZpy/I0mSuzU/CI/6s7q4SdXMdRGznHcBx8YkPHB0BuqTdz9vUXhQ+chQK52dCMvZjynwyKsf056JZ3YvyQFZUJc8JPAZiA+ttjWbgOaAe4Rpocq6Sa5Sa18AcN0SSOc+Brc6nyH7/50x7I0OMDkVVH7CUNZ/fcK1xLK8TBMfShWBFFKvkazTtwf96pqaHXiexnJXVrO49952WilYxE5ElsGYGsHh8R/TmNp9/4q+uHBvLz6rzPGJm5+gHBK4e2F3u+kBBHVKbnzDsvDcsbL5YygW1078JrWqTQozCw0GAzjTM9lDAvI7w+1h3rcsGFqyb/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GMNqrFApJdEqSkHw4q64Cgb8Ij8wFEjgXKIN9GryKn4=; b=bc4weq423YzPKsMnwfj+WLfx3YocplFrY2ltKL1iDVLHY5m3UK1TAix165FUIrCp5mIN6euO/LQU/YDc4qYJLMPqNLsv2195fykTa/DjLJdP2ttIlrIiABtKlcYvrwDgVRucVgy4vLr5d7VSz3zCt94cNqk5KZIwS9nEYSsVWpQ= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by CH3PR10MB6740.namprd10.prod.outlook.com (2603:10b6:610:144::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.31; Thu, 6 Apr 2023 11:46:51 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::cffe:f272:20:9a87]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::cffe:f272:20:9a87%9]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 11:46:51 +0000 From: Nick Alcock To: Alan Modra Cc: binutils@sourceware.org, Indu Bhagat Subject: Re: [PATCH 4/4] libctf: get the offsets of fields of unnamed structs/unions right References: <20230324133625.450723-1-nick.alcock@oracle.com> <20230324133625.450723-4-nick.alcock@oracle.com> <87y1nilc9v.fsf@esperi.org.uk> Emacs: it's not slow --- it's stately. Date: Thu, 06 Apr 2023 12:46:45 +0100 In-Reply-To: (Alan Modra's message of "Mon, 27 Mar 2023 21:52:34 +1030") Message-ID: <87355dkzbu.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0549.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::18) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|CH3PR10MB6740:EE_ X-MS-Office365-Filtering-Correlation-Id: cd529ef2-214a-4283-28bd-08db36949c3f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F5qMrM59jomF0nZowY8X2Zod2oVIi08vHSQV7//LIQF9inUnqn7GY9UELivJuNQr23DpuXc449UrobC5DtS4NoWEp3+rh3XwGMTQxuYv1TOUbfatpxyelMtVFzMB+DcxZfkCj85Vn5KjyZqEB6Q/9AP9CTh3aPeZTLb3o7VUjH+7Ci2XwbYoLG7fYdU167HfJF+4OSHiJ/6LNog6w8IQexMUwDg6DX3VBBRiThxRNkN45EOLmCcyxy/QkSNxYNfo7jSdh8aw9wVKtniIz2c9dmPbGCjBp+LEvciNVi0rnG4iafmL3G2Tw2qRYlpqIV0oADN3HixR76fkj90UMDQtjqoPk78ngpY34whR3ydUo+5JJVZjA5w8+tFNqS1BC2h2ge+rDIzbiRXN4InsCQWH0+1QwPPG2yB+iYPYPMlSGbP2aTlKCN9fWX7rQvsRk8/IfpUJTvqTSnU91StyoZ6jgd6L4WkffeoMI31wsWahixomXDnA3iRUIN+Gl8SHuF2h0QHzAaJg+ixRE5g465pi65H7AEmofuhz0tkyATpDGA3Z9jGd8owuB31Lt1i/Nxnj6qA2OUEuEL8Tc5Ry4JRC+06OJzJnfyKW4RSiRwp8Ivc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(39860400002)(136003)(366004)(346002)(451199021)(38100700002)(86362001)(36756003)(44832011)(8936002)(6486002)(478600001)(316002)(5660300002)(6506007)(2906002)(6512007)(9686003)(186003)(6916009)(4326008)(8676002)(6666004)(66946007)(66556008)(66476007)(41300700001)(83380400001)(15583001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J66TD/XraCRRPReFsZuiCWvHF56wokD52UfgR9aFFhlZBGESowEwENjRhTxh?= =?us-ascii?Q?9LQZljJ+HfbIqR0zK2I03lwVOqh5uFlrlukrp4O4+61jDfRk942zL/nxnaRR?= =?us-ascii?Q?d+Na3yX9mIZfsTTtsSoYLwPrSLy4MrBkXUqsQ0Xeu5bw4IBLExfLzQN3kRBL?= =?us-ascii?Q?Sbdx2AV5qkmiYEeO9WSrlKyBBA7jTv0a/i+WVDqXWBHyCr9RW/y1gi0KvytD?= =?us-ascii?Q?KQcx1TSdS+dPfK2aZ584497Cd+RgEFy6SEOPx0u88Oyx8QOjHadhFQpqsccj?= =?us-ascii?Q?FsFFGS9rDafGiTj+o1pKxMoMy94/hCGN2qwpD57dMAYqWFuytnziPsitc5zj?= =?us-ascii?Q?sttTXvInQxI4idXSvbBEYck7LLQsYuHpuZEw7peJ2wT7EoBeB//fnEvjIsw1?= =?us-ascii?Q?yUt9SqOs7aTwhXuofK6zMm43rMIbRTm0Vk80CpD/ezYl34Zje3VmNYgt/O1L?= =?us-ascii?Q?d3FboIVxFAZooI7tT+qmoXn4eK8IZFtDVAaRpHROLS5RB+cSplU/LHuqLfyZ?= =?us-ascii?Q?EhfdwrLf7IEaJK213dpZA0cowaqH7FkUa0bGI0np1ITRYrlMDKwtkZrD27gF?= =?us-ascii?Q?Fk7fo5LUoiSwA18gCia8JNSM95c6SeTGg65lii2F/LnOY0TBHb1N8OSvdYnk?= =?us-ascii?Q?06oJHFllD4i6s3gP46FZ1CPsNM4UwOioyJPqnkkw4E5ATzXt/ML35UG695s0?= =?us-ascii?Q?Y6K7JMS+DlyBeFcSkBtAnUbrla+6/SJEw3cM1Jdepb3ViM+LUlQpZaCYPkek?= =?us-ascii?Q?4lXFx3uE9flQUrL2FWxB84QO/qRoTqeQcoA4LFWVUqb4Q4J1K0zbkMqhcRZK?= =?us-ascii?Q?ZzoK3g953H/hZfHARqYk27HA038Ul/C2VhjiWwDVBrA/e8zRDTWkbXJw/bRg?= =?us-ascii?Q?uHztWjTsEsEp4+8zpHf1DJ5CeOPlbmlB4PZ6gdRRlfY9rWLynjfaErdBDezB?= =?us-ascii?Q?StsxpnCExYwGaMjjaLc1e+ikJrzCk5DkEEztc4TjtEGmkcioI4uRFfSQ0m6Q?= =?us-ascii?Q?rl0Oij7z1bxn5YzInvCydJL5NffKulAiTqf2DDl4lcD+kUF/yXT+sRCyFHN0?= =?us-ascii?Q?+bkm9WQbPEXvbEz9ykhcLW1QqbloGuidAp/qiOY643pRRFznAZXVFYb1F1OD?= =?us-ascii?Q?Lm26dKAEWV8aPPwKaNxGohLi3qBp96cY9Mb4ivtD0/WcpLHaaK+ZiJsQ3tsk?= =?us-ascii?Q?F9GUnQZK+kQSRfEbnTG4bVNpLbjAh9+EWlUZMZMeAcTgXAa/dysiaNmVr9fX?= =?us-ascii?Q?vyZIs54NH1fMQmTqmbCIBDmLf/wkV8MxASWh2GGZInoGv+Pt3vjI+RVvpqZ8?= =?us-ascii?Q?CVU5VtrJ3NBCfs9LA1YRqqNurRznYhnJZJNlEwgk/JqzJTM9NQJOFCBJCLPJ?= =?us-ascii?Q?YwYRZ0tPibwgyYM2jnTLnYBszyo6UcIKo65J6i7r0u6M0gJUqgnV7QLUMGgq?= =?us-ascii?Q?y4UYenHa/vMg5kzZX51YbsmfrG3qeJFSTe+3HY2bpW1qz7QTmqavj1AjAGqw?= =?us-ascii?Q?A5kZhHBhHYIq5OZvFMsiY1LtASM/qDGxezU2GUHg4H5tIYW9vB8mllQM7ux1?= =?us-ascii?Q?1zdnEs2MpBlSyeI2tfaq9MibYow/KDN8W+XJrOps0Iy4SSXevmg0fto9fcUT?= =?us-ascii?Q?Ag=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SrSXXqRYPjvqu1EKHMu+j+IALcdiUHkO7L1QbtaZ3ZMZ7jUIZEZ8Zg/2xS4WyuoQGWm2SR+UdD3lc/TET20x+fr9cxDgdcQOv6P0YXiouvWgp7HDc8YoIkjwYQZrfY7OdxFrlELnw9+dj5v+KclbNPO5WnIxg/tNu6pVz6QjXB5konwvh5cwmtlSvE+2STHpWzwIviFZrqSjP7m8s68JHUlKnIyhFIN8Y09sH3u87QYde6mCWOWNl2pwQkUyng/DzyjZETGCilKpj9YdIbXTBoRO5q91qIEKcmAXQmCPJVXB4xf2Ao6tcC3BQVL0cIUBIQWoZTCxprPNSgI39LFQdUdG+vLrOp2imoqliku3gw/dPc16B+nF2uHhp7l/yjtoBiamAuWrdSdJW3qwrGqsqSxHn8SSf9mLqP6ZmZARulKmv9FC8Ks1I70KMbBhKP4Oj6wdybQ6DEQsf2E8lIgxoUeLJEtdwo1xFqmfYC2f8QpH8bTFDltULhXDz/i5aLHwIV+9BQ06TsNUOPOEgqA2FP3CnB2YpAsC+ukp8LHwy4t/BHBdSC1CBsUMOcxr9yvBgzVvqREqgMFtBETfJ2Wa462hxO8Xg/aXVZnCsnBpT4rOuyZiRblp59ciOREKODl61q4pySoiqeCraozTRLXwE+5qAvXkupTLfI8yMyKa/lyTChZMioDrVkvBcXvyvguTkz2ddMWn0/6SojZ9yfJgMi8orDg6dkbEVnqCRCvFCeCqf2NhoRxDVPO5MA4zqZx6Jn3xPai3javphAtbSMW3PA3b3xu62inuGUki18sRHTQDwX4wcoZ4awRwKTcKj+tzfT7nPMoujIBi0fTLExGnpxjgSe43N48yJ66z8xLB66o= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd529ef2-214a-4283-28bd-08db36949c3f X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 11:46:50.9190 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PQXij+M49K5Wf1nKUoh3hxABxaVqodrmLfaC2syLEAs9ykd60oXlgJ4P41UrzUXdTiJAxU1WCOptOQ2nzHiJNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6740 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-06_06,2023-04-06_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=406 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304060103 X-Proofpoint-GUID: TOaL_yOkZ8diJ_vDIy8N2Xrtwg4o7WFB X-Proofpoint-ORIG-GUID: TOaL_yOkZ8diJ_vDIy8N2Xrtwg4o7WFB X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27 Mar 2023, Alan Modra stated: > On Mon, Mar 27, 2023 at 11:27:40AM +0100, Nick Alcock wrote: >> Are they all 32-bit platforms? It looks like it. > > Yes, and built on x86_64-linux. Which is why things go wrong. > "lookup" is compiled and running on x86_64, thus compiled in offsets > are for the 64-bit host. The test objects are compiled by the > relevant target compiler, in this case all 32-bit. Things would break > with a 32-bit host and 64-bit targets too of course. I have a fix under test that just turns this test off when cross-compiling. It just doesn't make sense to assume that datatypes have similar sizes on distinct platforms, regardless of the state of some woolly generality like "bitness". I suppose I could use the same tricks Autoconf does to get sizeof()s without execution, but for this test that feels like total overkill. This isn't a cross-compilation bug, it bites everywhere, so native-only tests will suffice to stop it returning. >> I'll take a look. Maybe I can just make the test less picky -- all we're >> actually interested in for this bug is "CTF says 0". But this is worthy >> of investigation regardless. It's just as likely to be a compiler bug >> as a bug in libctf, I'd guess. > > It's funny how we tend to not suspect the test. :) At least that's usually fixable with better ways to run the testsuite that spot bugs in the tests :) This round of fixes is taking longer than I'd hoped because valgrind and ASAN spotted uninitialized data usage and memory leaks in a new test... (I really should put the pile of scripts that controls my tests online somewhere: even if some of them rely on things like homebrew containerization hacks and so won't run without modification, the combination might still be valuable. These days they're mostly run under pueue, a rather nice queueing system for noninteractive programs.) -- NULL && (void)