From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79447 invoked by alias); 26 Jun 2015 18:02:41 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 79431 invoked by uid 89); 26 Jun 2015 18:02:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-out.m-online.net Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 26 Jun 2015 18:02:39 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3mJ5f32CLMz3hhgq; Fri, 26 Jun 2015 20:02:35 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3mJ5f30Phgzvh1r; Fri, 26 Jun 2015 20:02:35 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id f65MLpOt4UNF; Fri, 26 Jun 2015 20:02:34 +0200 (CEST) X-Auth-Info: KpqZ8E2cC68tLPo3p0W8iA+ayOmAi+27qpEMJSMRAkvh/QqUlY+X8l8A8nWASRx8 Received: from igel.home (ppp-93-104-60-107.dynamic.mnet-online.de [93.104.60.107]) by mail.mnet-online.de (Postfix) with ESMTPA; Fri, 26 Jun 2015 20:02:33 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 9AC5C2C3646; Fri, 26 Jun 2015 20:02:33 +0200 (CEST) From: Andreas Schwab To: "Pawar\, Amit" Cc: "H.J. Lu" , "binutils\@sourceware.org" , Jan Beulich Subject: Re: [PATH] AMD MWAITX enablement References: <0428E25D138CAA4D819A6FED9429E51AF4A29C@SCYBEXDAG02.amd.com> <556D83DE02000078000800CE@mail.emea.novell.com> <0428E25D138CAA4D819A6FED9429E51AF4A96C@SCYBEXDAG02.amd.com> <55755AD50200007800081CE1@mail.emea.novell.com> <0428E25D138CAA4D819A6FED9429E51AF4CB28@SCYBEXDAG02.amd.com> <0428E25D138CAA4D819A6FED9429E51AF4CBC5@SCYBEXDAG02.amd.com> <0428E25D138CAA4D819A6FED9429E51AF4CC18@SCYBEXDAG02.amd.com> <0428E25D138CAA4D819A6FED9429E51AF4CC42@SCYBEXDAG02.amd.com> <0428E25D138CAA4D819A6FED9429E51AF4CCA0@SCYBEXDAG02.amd.com> <0428E25D138CAA4D819A6FED9429E51AF4CCB8@SCYBEXDAG02.amd.com> X-Yow: I am having a CONCEPTION-- Date: Fri, 26 Jun 2015 18:02:00 -0000 In-Reply-To: <0428E25D138CAA4D819A6FED9429E51AF4CCB8@SCYBEXDAG02.amd.com> (Amit Pawar's message of "Fri, 26 Jun 2015 16:51:53 +0000") Message-ID: <87381efiva.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2015-06/txt/msg00278.txt.bz2 "Pawar, Amit" writes: > @@ -3347,6 +3349,34 @@ process_immext (void) > i.operands = 0; > } > > + if (i.tm.cpu_flags.bitfield.cpumwaitx && i.operands > 0) > + { > + /* MONITORX/MWAITX instructions have fixed operands with an opcode > + suffix which is coded in the same place as an 8-bit immediate field > + would be. > + Here we check those operands and remove them afterwards. */ > + unsigned int x; > + > + if (i.operands != 3) > + abort(); > + > + for (x = 0; x < 2; x++) > + if (register_number (i.op[x].regs) != x) > + goto bad_register_operand; > + > + /* Check for third operand for mwaitx/monitorx insn*/ > + if (register_number (i.op[x].regs) != > + (x + (i.tm.extension_opcode == 0xfb))) Line break before operator, not after. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."