From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14739 invoked by alias); 3 Aug 2012 20:09:31 -0000 Received: (qmail 14685 invoked by uid 22791); 3 Aug 2012 20:09:13 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_FD,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Aug 2012 20:08:57 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q73K8urZ026105 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 3 Aug 2012 16:08:56 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q73K8tom003110 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 3 Aug 2012 16:08:56 -0400 From: Tom Tromey To: Binutils Development Subject: Re: [PATCH 3/5] remove deleted BFDs from the archive cache References: <87txwknhzj.fsf@fleche.redhat.com> <20120803160934.GE4430@bubble.grove.modra.org> Date: Fri, 03 Aug 2012 20:56:00 -0000 In-Reply-To: <20120803160934.GE4430@bubble.grove.modra.org> (Alan Modra's message of "Sat, 4 Aug 2012 01:39:34 +0930") Message-ID: <873943n3fs.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00072.txt.bz2 Alan> Here's something I hacked together to go a little further than your Alan> patch and actually close archive member bfds when the archive is Alan> closed. You'll see I solved the problem of looking up the member BFD Alan> by saving the filepos in arelt_data. What I haven't done is make this Alan> all work with thin archives, but that shouldn't be too hard. Alan> Just a matter of adding a field to struct areltdata instead of Alan> reusing "origin", and solving the fact that my_archive isn't set for Alan> thin archives, I think. Care to run with this? Sure, I will take it on. Tom