From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 55EF93858D28 for ; Wed, 3 Jan 2024 10:34:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 55EF93858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 55EF93858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704278069; cv=pass; b=YgSWjRh6rGFW7pzC4hRNHsW38682gsERZ18IKEGPcsn2ticHpaaMKP1LFtiwaNqQBc0TxFZio5V4M9KfLMxHFNjuIjZygAOxqK7kXd0li3Ys9YB5hX0IdRnMGGy057cXdpCHE7eT0hWzry9JQM07sTot64KRpmdqcuLQv25WOb0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704278069; c=relaxed/simple; bh=Udn4IehajydFEWgRX2AmQ/2Mg0ZuMDGF5MxBn8uruho=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=qDlsIfK8vaE6EP1u6bZNixLjsV1ZzsIQ3PcmHmN5ZUyiunMjSXtGIhQgWbelcQsGhag/pvrDzPC8eoXAO5YU0uc5Rbwlnb5Edc2rxjdnpYdi9YX+ERYxit9evVIaOaLC/hC0Z40b9Ht8Im0M1L8nMPHIRhVevVnADFOJjv2XiFI= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4039iJdH017161; Wed, 3 Jan 2024 10:34:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=zX2uBZGKcyZavayFXElCVLw+rnlFaCfMSSe65fv+XMs=; b=oW4x1gU/74CSws2O0e4Hu1PlmR2bzvFihdaJyzFdKxcl1+CTys8ctZ0Klxz7ogqrOhZ5 RP3XdgzI8bCF7wy52OMv2eTSvTdN7ba/Cc1fHm6adL8nLDViSHkISUJw3myyZ3grFA6l NkmSO8+JXDOIgTo3tLkUCMWawjRBJYi/HOG8U7oUnYXYUYhkZvz8dS/9raBlORWRALXJ oGeBXl6mBhNXMcxX09rLwxpkXZFPNGF9wiYzJKGVJBKBrqrJtV0sODuzsP4LaRxfehPs nYnlTW4u634tITCYqk5lj3wZ5EDBxznJcZJmyHpPI1OSw4WDO0SPEI4PPit5T4VMu08t Sg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vab3avqas-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Jan 2024 10:34:23 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4039UOdb035959; Wed, 3 Jan 2024 10:34:19 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3va9n991ek-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Jan 2024 10:34:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Se3C+jI5VXQPgk3lHZ3F9aqVSIatHUVvd13H0eYSxhaJebLw6z982+OuqzjKK5U7kiyk1wVp9b9zBD0DV+OeU4zj0fY9VgYwvhubHrhiroaCk/lV0WVB8/0vYNu2pMjLiSGtUG/tUcgfJ38amcI1/FuC7Ru1LpVF+7NeQvX1/VcaxwcDPYq2mx/L+9J9j/G8wez0+vg2xiZhIZS7Q9iihwBi28Jyf0AqdvH2PxuCel7GWxn/3Yafw1yADQcVuB70I1eAUtZcJQorRX0SRuTsOYoDVqDq5w5QLXOlpd/DWaI/2bsTnmZ4Eyz0XGtwD1YR1IJsRu07yBSvrbgkch0Ksw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zX2uBZGKcyZavayFXElCVLw+rnlFaCfMSSe65fv+XMs=; b=jqJX6gy9poVZ3xnW2WNxoC65FcHJzzXhHKEdPXwz6JfD8c6237pk2XL/lPus7C2T8KoPxGl+fHOdr/46Nempn8xRTBr/qNOO1sl7g+6C9DMGD8xiO1dRx0+ptyTEITmyGNQU8c9qUDdJnQsWVWovY9Ok1AUodaWAQhCyXvHI9Vt+YoJvbLGeIL9p4JWnWY/8/GcMoyJRqiYx89chRDUJ2UWtb6Hl181bjcrwqdnbRqsCTGourRh4NJsVPnF2+qLmyiNbMrvkuN/cFn7EDwQFWCQCVXScbH9wZZymevxMfTFYEUdpL670zSD0ytlcG3isJsYSGP8BX0M/Ub3fqEsfVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zX2uBZGKcyZavayFXElCVLw+rnlFaCfMSSe65fv+XMs=; b=A8/90DkMDJWN4xD1CdVzt3Os7WSzg/uejNORWAvcOt7mcswjWbauIDwZqjlFLznYpQd5K0bgWBIrfh3I7YSMnfxWk7YFV2w1WQdrhmsV4aq69+uEankhDSCz5hTC2i1AYDSc2rUjfwd/zBWph/WLiAwkr3pLwYk/OwNVmw3nWYQ= Received: from DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) by PH8PR10MB6289.namprd10.prod.outlook.com (2603:10b6:510:1bd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 10:34:17 +0000 Received: from DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::a45d:77b4:ce0c:9146]) by DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::a45d:77b4:ce0c:9146%7]) with mapi id 15.20.7159.013; Wed, 3 Jan 2024 10:34:17 +0000 From: "Jose E. Marchesi" To: Cupertino Miranda Cc: binutils@sourceware.org, nickc@redhat.com, elena.zannoni@oracle.com Subject: Re: [PATCH] bpf: Added linker support for R_BPF_64_NODYLD32. In-Reply-To: <20231220132305.459519-1-cupertino.miranda@oracle.com> (Cupertino Miranda's message of "Wed, 20 Dec 2023 13:23:05 +0000") References: <20231220132305.459519-1-cupertino.miranda@oracle.com> Date: Wed, 03 Jan 2024 11:34:12 +0100 Message-ID: <874jfug0yj.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0487.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::12) To DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3113:EE_|PH8PR10MB6289:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b185b0c-30eb-4338-86d9-08dc0c47896e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JreKrscyBoyz+U3168bumavMtiPnfLjPmA1widfuxjVjkvmndx8DMIUNDCAADoCyqw0yoqOC9bCbODL5wH11epPa6JaCz0J46YMrX6XzsrWewEthXkqZEBMeLecWSqy/6VMHfY+s0zIPAgDMEA0g2JkLUWZymQPwfb61jbJtHCxmL3t6zRbN5Kk0j21DYjRpQaUUjT6ca+gVfUvtwXmKNWc+lRk37LOGd3/AhivTg81bqZ1rjob5sqsZh89SjiTWjyEXszpxSzlTxQfZLy9TR9oO//fqo4Qr+3MWOKkLw2FenA12hyPoR+U1WIxy5fki0LVQ2ef6B3FO1qyoC7sj5nZTUTJVH/9yOSg7rYmVePlRivQZqwy4HdFCrGoLSWk1eyGNnxWPi5lHY7hDVwlDuSEUe9fx8hEHlrCa2vjxrx2rgXM8LOyE+XJipwYcSDpFKdlecyM22rRCL//xLWIJttW2sXsu/VNmU3aimri14x3JoBKXeIEF7sdn4kJuraUPgVQctW50b+GF5evGKpwIEHjHMEdEPkzvACQ6WgWRk8k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3113.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(346002)(376002)(39860400002)(136003)(366004)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(83380400001)(26005)(107886003)(2616005)(6512007)(6506007)(37006003)(66946007)(4326008)(8676002)(8936002)(5660300002)(6862004)(41300700001)(6486002)(966005)(478600001)(316002)(6636002)(66556008)(2906002)(66476007)(86362001)(36756003)(38100700002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PWLzo/qo3GZBsiLXf+WdaIzY0E4AvjZJPO04l0GhsdBAzS5BtH5AIb0nnla1?= =?us-ascii?Q?jQk2kKRfpmsyF4FzoRyuiCvkciEAi3F/ShZfl2j+X0C9Ihj35CSJ0c20bZiC?= =?us-ascii?Q?Vtu6GDlJtaD/A8oLvHpeyll26CytHzN9L4Bl+EgrfTiFz7G3erje3q1sLZhG?= =?us-ascii?Q?2qZQXOvhDsR/w9FjVLh4Ad8PuUuNzmBP2EMC9lbjElM7Xjt76tJzHrN+vV+9?= =?us-ascii?Q?rjIfwo317khVopaO2IC1BMjGvEPoEhmbStLHwB+M1Nw4wI0MT12BDtry3soB?= =?us-ascii?Q?+vmG2CH+Qgq/Rv+1G78x8vasFb1ONIQzpM8+D1+eNMKt2onjnz4p6rkq4ME5?= =?us-ascii?Q?wHMBbDofnVBtXO0X37Vx4F1eIYA+MWMFBPRVcMsHFSUCWrJDzFfAoILDha9d?= =?us-ascii?Q?3cpTkoL/vuZt/BxDqxSR0G+Do4KbEJzggTKdzvRW5yjvsPFyRZTAiMhSgYc1?= =?us-ascii?Q?e2QC2Mm/Ao+01/W4C/zFXUhEjtso3nNhsU198GBn+XletmUd0zCGunWOqy42?= =?us-ascii?Q?6Yri0D4vbnrOsb/EXhHe8SVD8TLBZNvWrUWFKQkU7JTXkLVfnlr3OKzktd3+?= =?us-ascii?Q?v9XD6SSNmfodV1U8TOaNfpdvTW+V/2wLtEPj3zF0l+4TVwry8h/ueG7t7/e1?= =?us-ascii?Q?Wnp7BOWAoYkBiykkhQRFp6JCnrcnSFtyBLyRcb9bv1O5CF+PUl8t16/3ssIM?= =?us-ascii?Q?CEI1po2b8ZNqjf5zRo4CChWEAe9LkE6Y12Pu5c+bsLgnhddtqQ8peLlpb3rH?= =?us-ascii?Q?mZrrzRQCgFD2re5Gbftuw0fRqEwMRZF6oPXgzMgQ0qBSs/WQO0j9R04CTLg+?= =?us-ascii?Q?Zke3872yloWKwD379Ioa7dmsb00zghv9pqoCoRkkrd4Uf4D8m/8a2IT0cnvM?= =?us-ascii?Q?jetA1o1rWhcwAaZlXzYxelfkNJSM45n3FGIso6kZcegZNOtsB9lmLpdE2/oR?= =?us-ascii?Q?fw1vnQue08qXoxoOsWRtS6te7xF057s/W0TZRV3/WkuNX0v/YQPn7fmAULk6?= =?us-ascii?Q?7UqZ4SoUHyf9V3SsHIaCZSgqF0NWai0NGaqWANAXkYQM2fLUOAZgGDsQc6cI?= =?us-ascii?Q?IbPdvKwrHxsYJxBbU1lyp66YW5ultmnMu7bYcukL3VcjUjJ8WNwb3SL406e7?= =?us-ascii?Q?nPmx/gWALPedXSOxcvKh5maXxlSVyn+9yIxv5LpluWE1X+FhBVbUvJlr0sw9?= =?us-ascii?Q?PknnzNyzF9iHJOg7kW/GFicOi3I/hbxZfxu4cm+Vchj78PjL7+BCJDrBXMFz?= =?us-ascii?Q?u9vfTsbwgK2Yr3zWkUDbVteOHRcY6x222v3EAW2ftXOCzuCmYP6mLA0JAV/Z?= =?us-ascii?Q?51dHLr/P9+Ooucpf3OkO2gm5f/n0oqpak9V+KksC+M3hdWIHsZOb5xVxMXgB?= =?us-ascii?Q?SJzlxHw3tGFtHHB8jJtJFVeijvJxIbQTziSMxpjGEdXdkkqUNbFV9BofcBdq?= =?us-ascii?Q?cQ6OCtvYrAD9VzjXR9s7cU2wtN8eaemqrJrxbBvwUnzQZmrmVXty6c+Kag36?= =?us-ascii?Q?9T/mtmS5c4BN/S+0UxKVIEbj+oW7Mlf+V6ca5J72RNHXumq3XxlgOkA5o6AH?= =?us-ascii?Q?fq1pc1GVAjrxC2WuYv9gF687EK/CvdT23jYSbeifwDNRmNyrCDwxOFkLtIzc?= =?us-ascii?Q?wQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: XuSpk+HNKI0tiBxeAmzFmxaaxHQRExw7Q1mqPAf6tmr3qGF4qXzsjdI+YvOycjCKbDQ1sYVDfXesdEP4vad5FFXieOmNAfEG5QNc5sVGB/XjH1SerrFqWq59gk6LCGWx8NcC7dbTLRgRJCyCfd+Bxfb4fDZ8MNQsLP9728Ob3kqIVYRpfuF1mMdr4AoaQXNv2o1BC7nup7/u3/UmJMUtl8mGEmeZsZv0OaLsmNj1KHce4XXIVqLQ0j7iHBAAzdd0HAcWcnGvooUszpmYnYIxXLyTvBPQbeWkiCNNFNZ+wnL6fAabMvjRKBpz4CirGvy8XDBvgDBTskk9fEdyLvNeyAvdy6oDBxA0JmYl+RPQ3yc9pvl0UnIz2tTYGgl0aBAQOzaAOV+O8NRxDqpP+BLxPSgONdcjK2NcaxAP64r1tQxTBpjYUpbREwRWLEpnJFk/Og6nZit1WNUd1hrnKYz8ivzTqX/mbS/W+/00MKmC5YcXWAURiYBAJ1/40xzwkSVVhO9FFAN5lmWRu9Q40M3FeN8P6cOiY3vQTZmlUUZatsF4Nyt9PdD1LNOv42ScrWdHZpG3imGhyAEGsIqZk6qOuzvc69IY6y9X/ulhSmOFyUI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b185b0c-30eb-4338-86d9-08dc0c47896e X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3113.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 10:34:17.2743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: duHFBXyopmUSItpSpJx5JmjApQ7guOXLHBtAeSuZpM3e/JPwtsKhsYLIrjwvah2ee2SVZ9FKG1VkbYmT2fkLv8ZVYaoQvR4ujY/UMR0bRak= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6289 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-03_04,2024-01-03_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 adultscore=0 mlxscore=0 mlxlogscore=937 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401030087 X-Proofpoint-GUID: oyewqMD1Yz8Zb1L9HH_cSPiEzZd644Gt X-Proofpoint-ORIG-GUID: oyewqMD1Yz8Zb1L9HH_cSPiEzZd644Gt X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Cuper. > Hi everyone, > > This patch is in context of Nick Cliftons request in thread: > https://sourceware.org/pipermail/binutils/2023-October/130194.html > due to bug reported in: > https://bugzilla.redhat.com/show_bug.cgi?id=2245296 > > For the time being the linker is not used in BPF infrastructure. > Considering that and without a proper way to validate the code, the > following patch is what I think is missing in order to add linker > support for the particular relocation. > > Looking forward to your review. > > Best regards, > Cupertino > > This patch adds linker support to patch R_BPF_64_NODYLD32 relocations. > The implementation was based on comments and code in LLVM, as the GNU > toolchain does not uses this relocation type. > --- > bfd/elf64-bpf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/bfd/elf64-bpf.c b/bfd/elf64-bpf.c > index aefad7da5ac..5820dd3d7d4 100644 > --- a/bfd/elf64-bpf.c > +++ b/bfd/elf64-bpf.c > @@ -276,6 +276,7 @@ bpf_elf_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED, > } > case R_BPF_64_ABS64: > case R_BPF_64_ABS32: > + case R_BPF_64_NODYLD32: I would add here a comment explaining that R_BPF_64_NODYLD32 shall be handled/resolved like R_BPF_64_ABS32 and that it differs from ABS32 only in that the LLVM execution engine is not supposed to resolve it. Given that, the patch is OK. Thanks! > { > addend = bfd_get (howto->bitsize, input_bfd, where); > relocation += addend;