From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 649DA3857B8E for ; Mon, 20 Nov 2023 16:42:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 649DA3857B8E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 649DA3857B8E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700498562; cv=none; b=V5O+YIkvw8fy2Hqm9dGc+GK35r0jmSZrUGrC9oJM91hftR0s6LG27kC59aiz6/bbBP93zrO489bLiBXCspqAjBafFCI/mUuXvbBww4zUOX4Qg8916AJ6Icb/YS9+sTZ1ISfIq4tk3xx9gjGaQNZtGr6+MWCDFSq1GDUourEQYr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700498562; c=relaxed/simple; bh=3bTOAa9uSFZGnfJPniSnjcxjgndbmjjzQ3n/Y7jxlZU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=psJxGTOEsXAQDm64Viob8djX3UJRYvHjaQjBBE4ePsT0PFRVln5XqfYuM1SAtGdZ+01+qkV5HGDJ+kjUnU8A7/gGJetAc0aM1kG1BoJEKcmgqlRghdyll2rlhoD+Q2TTgM9P3BtYNs4Tu5gR/oH+TqEtlaTcSjMReOU2fLpysns= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40907b82ab9so11614485e9.1 for ; Mon, 20 Nov 2023 08:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1700498560; x=1701103360; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=42VP7Dh1qvFJ2s4Wo9SKzdOlT2Z1JpcDUbBpceHj4SA=; b=H+bwvYzsd2uoWjwnCZr8bylc6nFs9euh9lYoakI4ojvvB6c1gzD/nn8/QxMXh7FBQQ xiJOGdWm3eLvDBrvweIGjT2v+Z5d/Ei0L4MhAAH73aT5N7XNqBLQIl3na8B3v1cAlMCu pSAIjyvjVvSVV0zI/z5WKWuyPh60VMpo45l4BUlrmtncKg9unm343z2gyKcaAXF5QmiH lxb9E47+24riMhLByPbLmlcPG0u+IbEPJOI+qTjpUsTei7PgEoB4uka1/bN9+rB6Ztfw ML/69xrPsp+wIqhRX4TgO9xCSGsWRhXgGUwTPsYWtSAcyl/W8Nhs9GtRbE4ejvAqnT/X 41iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700498560; x=1701103360; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=42VP7Dh1qvFJ2s4Wo9SKzdOlT2Z1JpcDUbBpceHj4SA=; b=GM6S9q1meKN/HWOKeod93X40KgLzeRQ59XX6Q73W8smKn4sPrkyI3cqHt/N/afvvsy 758CkODmARbFUOOM9BL/XB7jTtVSOeSpxnBdFxd1SIqUTQOaVilchxbJVb8N/1uYBmj5 qk7TUNd2U1R3ob+ZlQKuwXikC3lOV7OxoCQpXgacLNt6FZaUXS2NejlB3zsZC6GyTZYR YUP0DVxD+wOgbSmeD0lWXbO25HFAXlvqrrtpdwzuaheFGzVBUOohqr5ERh2U01SqV/my fON83qzQajr6d0G11aQAckfPfu7txfnb2HY4wYaB/Vxo/dp/WsyPHJYYUwiZuCL0bFEC vBIQ== X-Gm-Message-State: AOJu0Yw2QT4wop/2LqvYiFknZicc+/Rwz1naMgyyA7OxRdeC1japOujP lR0Vj2hD8Vmdr9b/7LeQPgd5IA== X-Google-Smtp-Source: AGHT+IEJZeYEs/wa+q9ewPF5zr8tHtR8+yJkny6wDcto3n/UU9EH0blwsFTNIN2mK9ynQ4RBsPBQiw== X-Received: by 2002:a05:600c:1c25:b0:407:3e94:bcca with SMTP id j37-20020a05600c1c2500b004073e94bccamr23787wms.1.1700498559969; Mon, 20 Nov 2023 08:42:39 -0800 (PST) Received: from legouguec-Precision-7550 ([2.57.72.67]) by smtp.gmail.com with ESMTPSA id bi27-20020a05600c3d9b00b004097881d5f0sm18373946wmb.29.2023.11.20.08.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 08:42:39 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Arsen =?utf-8?Q?Arsenovi=C4=87?= Cc: gdb-patches@sourceware.org, binutils@sourceware.org, Bruno Haible , Iain Sandoe Subject: Re: [PATCH v2 1/2] *: add modern gettext support In-Reply-To: <20230926004300.1716711-3-arsen@aarsen.me> ("Arsen =?utf-8?Q?Arsenovi=C4=87=22's?= message of "Tue, 26 Sep 2023 02:17:33 +0200") References: <20230926004300.1716711-2-arsen@aarsen.me> <20230926004300.1716711-3-arsen@aarsen.me> Date: Mon, 20 Nov 2023 17:42:38 +0100 Message-ID: <874jhg2x6p.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello! Do I understand correctly that this patch, committed as 2023-11-15 "Finalized intl-update patches" (862776f26a5) specifically the bits quoted below, remove the support for in-tree libiconv introduced in 2015-08-24 "Missing parts of fixes for in-tree libiconv" (cfe101c6a82) ? If so, was this intentional? Arsen Arsenovi=C4=87 writes: > [=E2=80=A6] > config/ChangeLog: > > * intlmacosx.m4: Import from gettext-0.22 (serial 8). > * gettext.m4: Sync with gettext-0.22 (serial 77). > * gettext-sister.m4 (ZW_GNU_GETTEXT_SISTER_DIR): Load gettext's > uninstalled-config.sh, or call AM_GNU_GETTEXT if missing. > * iconv.m4: Sync with gettext-0.22 (serial 26). > [=E2=80=A6] > diff --git a/config/iconv.m4 b/config/iconv.m4 > index f1e54c5aedc..ff5d5261139 100644 > --- a/config/iconv.m4 > +++ b/config/iconv.m4 > [=E2=80=A6] > - CPPFLAGS=3D"$am_save_CPPFLAGS" > - > - if test "$am_cv_func_iconv" !=3D yes && test -d ../libiconv; then > - for _libs in .libs _libs; do > - am_save_CPPFLAGS=3D"$CPPFLAGS" > - am_save_LIBS=3D"$LIBS" > - CPPFLAGS=3D"$CPPFLAGS -I../libiconv/include" > - LIBS=3D"$LIBS ../libiconv/lib/$_libs/libiconv.a" > - AC_TRY_LINK([#include > -#include ], > - [iconv_t cd =3D iconv_open("",""); > + AC_LINK_IFELSE( > + [AC_LANG_PROGRAM( > + [[ > +#include > +#include > + ]], > + [[iconv_t cd =3D iconv_open("",""); > iconv(cd,NULL,NULL,NULL,NULL); > - iconv_close(cd);], > - INCICONV=3D"-I../libiconv/include" > - LIBICONV=3D'${top_builddir}'/../libiconv/lib/$_libs/libiconv.a > - LTLIBICONV=3D'${top_builddir}'/../libiconv/lib/libiconv.la > - am_cv_lib_iconv=3Dyes > - am_cv_func_iconv=3Dyes) > - CPPFLAGS=3D"$am_save_CPPFLAGS" > - LIBS=3D"$am_save_LIBS" > - if test "$am_cv_func_iconv" =3D "yes"; then > - break > - fi > - done > - fi > - > [=E2=80=A6]