From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id E5AB73858404 for ; Tue, 18 Jul 2023 17:54:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5AB73858404 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-98e39784a85so1509638066b.1 for ; Tue, 18 Jul 2023 10:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689702889; x=1692294889; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=8LlI1hOSZ+8c/bqRRyxgpcdJL75m4gkpZBoyeauqNMs=; b=IRKN+QUHFF26GiqHTUA0txRa9YKSFILczllvhnHB1dWDiKKTRTmHpHHhxO50rmMqWE K7CEBvSN+QqiXa/SP2yZhOiBIaU6FqoVG7DwmRamdNLFCKXbzIDFy8uJBnmNHAcFiIro qQbjp9oq2UMIZfsxisW3MWYXPNtaHrPhTMwFqqGlwaB7tW5qBI1mh4FkV+gJqOjd8AZ7 gPP62DH894ElPo0zu5vfaRl5h+0j8erH1daLvVZ6u1uonmXLH64Y7TVDzregRR9h5p41 UWlRBD9gIK11vdMjOCD0vnORPmMEBrni79YNV8HFgXcnMXd0kat6W/sH2oqZVNTiUsVy Lm2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689702889; x=1692294889; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8LlI1hOSZ+8c/bqRRyxgpcdJL75m4gkpZBoyeauqNMs=; b=JHzclIEZflJ5zyjR7gznbXY4PVf/82ZzOCBDCFpNCxAulSQYiS8+EdK85peo4UlTUl G1mPn98ZIhpkTQk3dlLbjgqTN7XdoOpKt4txHU9NIRdIMmebZVQXKSFM1sfqtvGPHONy +RaXeulhCU1Qv2gqiZjqX5qJnmALsltxnenTOfbA02ZANZp8H65vwM+Aw8CT1ADKd6se kPUFlitOqIsWxboA/c83WUtmbTzmng0+R4+++gSEpwm5qkKUwI7qES9rjnfLJ3reI9jH t3uMg2shLJErTY80grHklY2JfKyKoSWJ2S40Lei0I/vXgqauJNmbrXejwr/BTUfibfvX HMng== X-Gm-Message-State: ABy/qLbXZUoUhFLwRp1E9JwyqHmU4yp/0cyumtFqmxt4PXJ0h+UStEAS IMziM7w3H9WSr5MfapAW2u/Ys7BO05k= X-Google-Smtp-Source: APBJJlFfzrvrGEWmScnfWhqQBWOs2vXZpQ8g5iKL4+HkUez4zmLFvYJZzBzwuwQXjxVpMnTIAU0DSQ== X-Received: by 2002:a17:906:9e:b0:98f:8481:24b3 with SMTP id 30-20020a170906009e00b0098f848124b3mr591322ejc.37.1689702888619; Tue, 18 Jul 2023 10:54:48 -0700 (PDT) Received: from wractal (c-5dabe455.023-86-6d6c6d4.bbcust.telenor.se. [85.228.171.93]) by smtp.gmail.com with ESMTPSA id y14-20020a1709063a8e00b00988b86d6c7csm1273101ejd.132.2023.07.18.10.54.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 10:54:48 -0700 (PDT) References: <878rbrgzoz.fsf@gmail.com> <75e3c5a2-2098-90e6-13b0-4a007adcc58b@redhat.com> User-agent: a.out From: Waqar Hameed To: Nick Clifton Cc: binutils@sourceware.org Subject: Re: [PATCH] objdump: Round ASCII art lines in jump visualization Date: Tue, 18 Jul 2023 19:21:20 +0200 In-reply-to: <75e3c5a2-2098-90e6-13b0-4a007adcc58b@redhat.com> Message-ID: <874jm1ksv1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jul 18, 2023 at 16:24 Nick Clifton wrote: >> Lines with rounded corners are easier to follow (and easier on the >> eyes). Use `,` and `'` instead of `/` and `\`, respectively, when >> drawing lines for jumps. > > Well this is kind of a personal thing, and not everyone may agree with > your choice of characters. So how about allowing the user to select the > characters that they like ? For example if you added a new command line > option: > > --visualize-jump-chars="/,+>'" > > which could then be used to provide the characters displayed at various > points on the graph. Obviously this would be a more complicated patch, > and would require adding some more documentation, but overall I think that > it would be worthwhile... I understand that this is highly subjective and not everyone would agree with the argument stated in the commit message (I guess the "scientific method" would be to do a survey :) ). I don't think an option that specifies characters would make much sense; there is only a small subset of characters that qualifies to represent lines. An option to choose "ASCII style" is probably better, e.g. `--visualize-jumps=round` or something. However, I'm OK with just dropping this patch. It's not really a big deal.