From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 9142F3858D1E for ; Wed, 17 May 2023 14:03:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9142F3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34HDo7qR003414; Wed, 17 May 2023 14:03:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=oJx6XXk7D44rFqiZ6pDzkbSnjce/JkAxNJfneATBQr8=; b=cUjDTZldLPBXyEjVANjjSGBS2frI18t5MH6W/vQ3W927hP5o/AbUjuTyefiYpFpX1dr/ 0jPrzKXySIsXHj7brxxSF+GUByTz3radMpAsmU1XW3opLYuOgT79Y/QXi5i9of44EmH4 jEQqwav+Wcujl3/9AQsWeVXtxciV53V3eJU74NN+e6Gb5J7pTpJiJizVhlDpGlshEaT/ 8tt3824e0rz8tWbkgbFOywcETqsXr2rGuTbJ8z+b1HiRe1iq4Cd/CTjFH49CVGvGuTrF oqui53SAO41Faj05aezWNHuVXznBGaLCBwURTwW2A54ibu/f3RtQZ+47AVCF2nwqHG1s Vw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3qmxfc09tk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 May 2023 14:03:31 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 34HCqt6M040086; Wed, 17 May 2023 14:03:30 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2173.outbound.protection.outlook.com [104.47.59.173]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3qj1057rq8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 May 2023 14:03:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PFrwEWdPpw7XV2KZgtt7zmsPdW5EnJIezAGawAJxw5gi37Aox/OUKm++QALSGwkksJ0c6DPwLdWlr/vtLsr5+g1KPyzeDC9G0vLQq65HknbpTqC3ZTYrmK/ujVzDIedgwYnryUNGm3ALarbfLZvVzyM+8z4yC6SuvsfYM89p2FMxIJozirpkS3eYQnGDoODRdc/vUOy8NDiA6bCfP2V3gBQZx0rnLeDwXKAHrsUWMu8faJRvLniCKiEh8tI+iKAACM+oV0kuQM5xqHr3yob43Qv/xPSf0EGzvUHZvfmPr2IbvSb4Xs2AkNd9qL85mEw23s5ezmac9ZLAbjFkyGW1YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oJx6XXk7D44rFqiZ6pDzkbSnjce/JkAxNJfneATBQr8=; b=l2ABKfHPxF5mEzaa0b/x1B7/tKMkDUaOZsaMmE7xsmhX7DMmkLAEPFCFnJAfZuBjQAhD6HTTU4fAGN5NJBvjC/BliYV4M/y35WXfmMZwiB3bTywv5nYYVbsUMHph1j2Nr1IYr3VKZt5l+5fhISHB8EKCNgfudhh8/0U1D4xfYOtlkPnIQyA46nbLfGxY3prXoastSR2PEttxdPn7NL2L7LATU8iWOw2zGVKZrkzyw3j9S/wRPywcMvpuvan8NfbReb60JGU/kBndgKMcEfQ5L/ZiVFWGdWY2WHlAmLOfhPRAVb5lpcOKNSZuXpdzYZa8ngbYwp+4vIgOyqXuQKUmVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oJx6XXk7D44rFqiZ6pDzkbSnjce/JkAxNJfneATBQr8=; b=a//Vl0ZCLxCNz2UlQ8pl5WrID3emSoU445uIT3I6dX4JQxtTpKYfSyxf4PB9lhle/76QIw8aKFNFj2BtBsDXgU64HrOpQzsNSKPpJM1KIqVz69NUiVPkPwM0L8mpBud0cHSMz6bt+Y2vlS6llfj9yJ4KA+ZfN7XMVW/bmAm6ZOM= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by BLAPR10MB4915.namprd10.prod.outlook.com (2603:10b6:208:330::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Wed, 17 May 2023 14:03:07 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::c5b7:b8ea:e370:4622]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::c5b7:b8ea:e370:4622%3]) with mapi id 15.20.6411.017; Wed, 17 May 2023 14:03:07 +0000 From: "Jose E. Marchesi" To: Nick Clifton Cc: binutils@sourceware.org, Jan Beulich Subject: Re: [PATCH 1/4] opcodes: use CGEN_INSN_LGUINT for base instructions In-Reply-To: (Nick Clifton's message of "Wed, 17 May 2023 14:03:58 +0100") References: <20230511141351.18886-1-jose.marchesi@oracle.com> <20230511141351.18886-2-jose.marchesi@oracle.com> Date: Wed, 17 May 2023 16:03:01 +0200 Message-ID: <874jobm4x6.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0242.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::13) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|BLAPR10MB4915:EE_ X-MS-Office365-Filtering-Correlation-Id: 318e5778-1ffa-4a25-f321-08db56df706f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DNMps3aG3rCJTy/xCVYmaUGE9Wv5uHkdD373vzn8uhzJbMFfVbj10f9ewwTK82XrD0ufInDnBJMguzuwwmBPExc3G7dlIqikK7p8NDvMBPqDhe6dWdYt1IrlzzvhGgOO7Ot1EZgUm/vjJh31A3EWem7o9fXybYVpYPmpwYklRqa6jSrzY1iA8HUr1iX7cOZ4+fE6/f+XQwDNGWQ4SkxNYp4sTmwdAezgpuyAcw+/ZC/UM+x5QIkrt21moHIeLm1BtCDFE8IoVjpxXYLMWrOgYiZfQWJ39TCH3Fmbm/SjDVzVRFHysoOR+4jlmWJ8f4sQfJGEJlfosAqE3kYYTVKPwvuSRtS/qJNpg3WU74CmkYfw6g16pGZK5eAw81DMMRcbTUj18g0TbBmwTiqcFAYLX6AER7iMg9piLflaXpVJuPW+FDlCA3j5vLT3ehADxZA8NCCScr+NUo3CTJg5d9ng+j4MmUGcTAB4doo1oRZz7kHfdeJRoFy+PGbQgJ8B4jRuFdgYH8pomlWo0X2ajDzHMNeFlJzfWLwkCMI7dwyTsIvXB1pggqTi7VH9+/irmIZB X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(39860400002)(136003)(366004)(346002)(451199021)(83380400001)(478600001)(6486002)(2616005)(6666004)(6512007)(6506007)(26005)(186003)(2906002)(8936002)(8676002)(5660300002)(36756003)(41300700001)(6916009)(38100700002)(4326008)(66476007)(66556008)(66946007)(86362001)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ggPgAG0YIJxMakqI5hSzhpwBdEiopNi0giDVGekveTP/2zFWBTf+14ruUduR?= =?us-ascii?Q?2GzOuLshDtr0da6d3LYmtn6ni70XS1gmQ4SSys4fXKKMPz+ouCfIEM5P2bZS?= =?us-ascii?Q?sIHJIrAvQGy8phBwyU5fZa8ZP5JpAx2jX2+77tcRVyDbbrDLyXJQKapgO6lu?= =?us-ascii?Q?2l695xgHMA6TCfl9NPVyMSgCya+pL9md1FVcYNZN+Wb1EfPyQwMJgwUJ2ieu?= =?us-ascii?Q?+5KG/pMYT1+f/kK4kHGWa1Hldz6VuoOZ9gJacMOqlt5jf1iLWOsQdqi5GQ2A?= =?us-ascii?Q?ktYssPfzszrZ2ttH8lqjGu62TMUrG/3ryLQ5Y5fb+OjY2A6uzr1WPNja1j9g?= =?us-ascii?Q?etvo5xebymR/v3X9ojec7IWxTrhjr1tJkVOCf2Qy+A1+F/kcZB4pmXDBHEQP?= =?us-ascii?Q?IwYY4oP2DIqzeNKEXZbk20tBr1o9+66xzXIbnDvRddE1UeZ17EYsiSMIusq9?= =?us-ascii?Q?4vgZM/W8bRtJ+w1klFXN3ewzZ29Bkb/61gmgjS7qT7wFnB8OGcnjFNTQzsgK?= =?us-ascii?Q?/YigXRA0b7yHXc8RBHpMYUkP4PDjLYPnCococoXKOrkORMH48q5BSteTsyx6?= =?us-ascii?Q?Dj65m8xCl/HMRpHIbDMG39SDSnJe+70kvmnpSZPClpKeyd3dmfO/XsgeNRNN?= =?us-ascii?Q?+qhwEaKUHG9X9X33/z+F0xj6vyAwLVXs+X+e7JR/kaFZb6hT+P8z/wKI02mr?= =?us-ascii?Q?l9rXFblbsTC+kHAWnJPqDNRqAfiiKDtHNmPIPjVc3CRluD42nMBJwjH/utaq?= =?us-ascii?Q?ZO7UEyrQRq2VwdfK+nhg84Qt+05D3kfnJamW7LuNHccaU/GMJ1RkM3+5XJ5u?= =?us-ascii?Q?ZOxVrP0CsZk0jsZKXgf93FghuYLDUInGdZD4oZQlEYio0kocbkb9gibtXDhb?= =?us-ascii?Q?o7JNrOGrGCKKWR1FaE9PlQ5xP7u/p29OZ+4qsQh54mQk3scMD+vVRglHRRJJ?= =?us-ascii?Q?7B/y0Oy+/O0oiqdlD7J0vqNt6zqrYNjcppPcW0HB1iHMr6AZUDvuVnMgP0NZ?= =?us-ascii?Q?tE28v3xhAxQlNThbyjbl7ZergL3DxwYnzEILndMLnJJWs/HIhw32BGlDkoiF?= =?us-ascii?Q?6XVEEWi/CWy0egj2TblcgxeTrLTykTr949qVyJRE7snqIgVcM7Xu62EY5dft?= =?us-ascii?Q?mFGMB5penIFv0kLEGiTsynXeSYOn7Wen69eWhWWZBjIx9xEoz56ExI7f1ZEn?= =?us-ascii?Q?bQP5jZcIa9qtpp/LGSTflVwvx4AyUwl34v/UGC905K/ROUgiVlZxoJUYE/qI?= =?us-ascii?Q?9vF8IBAvTMlUGEriFHqmrPd95IIo2kSHsdu/yQBukDjJLM52xpZp9HEFG/LU?= =?us-ascii?Q?YhqeySgmMhuPNXz1icfYYGwQqrgnNA7bNJ/An0WQagME7UhO5+seiLfMD+Bv?= =?us-ascii?Q?3tzcJ2jEwNN0MoZD9hwU7PXUrI0qOgFdlIle+VYb1If2NeXZh0qAFtae6Lc6?= =?us-ascii?Q?SFG5/2F0XSZVsEgW8ZnzZ2llSabGwFSHMxNdcjMOLJz26dA2aHZhr9pPCSDv?= =?us-ascii?Q?7zF8/zO4PCrZ9yENV5yD9Z+Iz4REQxYEHhef/6v8cr15TaphE69gR6Fn43Bb?= =?us-ascii?Q?f6MjQc2eW8m4o6nEYsP8HPsqRuNs/XNRfKTdGYlUtgJsmuRRkg7QSGhCzAvG?= =?us-ascii?Q?jg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Zwm8DdwA67jHGG15sIm/LjS27dTc72bUIv6CQAwZnHXd24+vTA0mTEG+LWP3tXtAz9UwYSgyOgPajvnU1caMS7JWc7tVM0ujjAY8r2sACbZvaTLyCWEVRjwyZgUDzh4Q/xNMYl4ImgUKwgc1Q42jG/Gb/Th2qDT9EVUnZrbZyvsgG3FeuxfHeha2Tw2H7Pa5Ly68a1R++b6GtWeGet3MAJ69Zk664ZKOxNb6OkVj5ZD9ba/NCNwD4cCf+jl26MkxDezVvT7r6yonstjei5a83uvTc/liLy8j3hltIAdhx8auHo6r8iG/XtGUzqNstTjP7I6jlDINrjWHEQqeEox5OVWzWV55FUTKXbWCEjCnkDro+Cslf5y0f2RPyMJPQmSTrsoCJobCI6ivG3TZI8A8METcwq8444wUjj7/AXs8ziJtOmqhM3/IvH1eGA15I6DPHRLWPJ1GD8dcd19qObkxOnRrlKPkVl7m21g9c8jp77JpFVcjsESvCKelX9fFxFbPWdv4UkzFPrT3ammv9pe1QdviUDn7mXmh5OSHi24NcwhxQzFrd35drbYEDl87u2ZgtHUlZZawvr8LoV6hTs7FeS/IIS2YZGi0lHg+z0hSaM8V6O4VybdB+MeF7WKDkvniTeOlctFstMKMZdFklldioTPKauTmXCnAtGnI52LjvV4krQp4IXY+I4CGJMA7IRBm+BXlmfiVc6UY5qBHF2HqEtblYUkJrgx+b7OCBkDTepln/AYeg1i6DVQjiaplh/qC+LKtbU+RdLJ2YNFPAIrPhvem9jxfL82aU2rmTrNduFAtooMMudeud9oDE9WBCAI4 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 318e5778-1ffa-4a25-f321-08db56df706f X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 14:03:07.0295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x487OVGkhIz2BuPnC8jPTl2V+3wR9JuwU+a7h1E2onrj3jEgUyMc7zK714SohYReJm01IH3Fk1d0VOnu297WpENW1CIIW3MJwX2K39OAAcM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4915 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-17_02,2023-05-17_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0 mlxscore=0 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=290 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305170115 X-Proofpoint-GUID: oTLNXZO0fmMTJwB1Re9FMobdbRIkeWw2 X-Proofpoint-ORIG-GUID: oTLNXZO0fmMTJwB1Re9FMobdbRIkeWw2 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Nick. > Hi Jose, > >> This patch changes the opcodes CGEN support code in order to allow >> base instructions with opcodes past the least significative 32 bits. >> Note that the masks have been adapted in a previous patch. >> This patch has been regtested for all the current targets in >> binutils >> that are based on CGEN, namely: >> - bpf-unknown-none >> - lm32-elf >> - fr30-elf >> - ip2k-elf >> - iq2000-elf >> - m32c-elf >> - m32r-elf >> - mep-elf >> - mt-elf >> - or1k-elf >> - stormy16-elf" >> Also with --enable-cgen-maint and --enable-targets=all. >> No regressions observed. > > Patch approved - please apply. Thanks. Before pushing I am looking at the CGEN_INSN_BYTES point raised by Jan, which made me realize that, even when I am pretty sure the path introduces no regressions, it may be incomplete because it won't cover targets that would have opcodes past the lowest 32-bits of the base instruction and that also define CGEN_INT_INSN_P (even if we currently don't have such targets.)