From: Nick Alcock <nix@esperi.org.uk>
To: Simon Marchi <simark@simark.ca>
Cc: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>,
"Jose E. Marchesi" <jose.marchesi@oracle.com>,
Tom Tromey <tom@tromey.com>,
indu.bhagat@oracle.com, elena.zannoni@oracle.com,
binutils@sourceware.org
Subject: Re: [PATCH] gdb: use libtool in GDB_AC_CHECK_BFD
Date: Mon, 14 Nov 2022 13:56:29 +0000 [thread overview]
Message-ID: <874jv1wsfm.fsf@esperi.org.uk> (raw)
In-Reply-To: <c6b69423-ceb9-58d4-c7c8-bd26eee3282e@simark.ca> (Simon Marchi's message of "Fri, 11 Nov 2022 08:51:21 -0500")
On 11 Nov 2022, Simon Marchi stated:
> Another idea I thought of, which would still break the API (in that
> callers would need to include a new source file) but not the ABI would
> be to put that declaration in a separate header, say ctf-gzip-api.h.
> Users of ctf-api.h would not have to deal with zlib. Users of
> ctf-gzip-api.h would have to deal with zlib, but that's fine because
> they are consciously using it.
This thing is distinctly rarely used, so I'd say this is the best
suggestion so far: it unbreaks gdb and all known existing users can
definitely adapt easily, and it avoids depending on nasty guts of zlib.
If ctf-gzip-api.h #included ctf-api.h itself, the needed change to users
would be even smaller.
I'm trying to get a new libctf patch series into shape and can add this
change to it if you like: alternatively, consider a suitable patch
pre-approved. (You'll need to add a suitable #include to
libctf/ctf-serialize.c.)
prev parent reply other threads:[~2022-11-14 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221107194634.1313150-1-jose.marchesi@oracle.com>
[not found] ` <5e940b15-cd5c-83b2-0bdd-9afa27b5f197@simark.ca>
[not found] ` <87bkpeuae6.fsf@oracle.com>
[not found] ` <875yfmztd6.fsf@tromey.com>
[not found] ` <87sfiqsr7m.fsf@oracle.com>
2022-11-10 17:11 ` Nick Alcock
2022-11-10 17:46 ` Simon Marchi
2022-11-11 13:17 ` Nix
2022-11-11 13:51 ` Simon Marchi
2022-11-14 13:56 ` Nick Alcock [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jv1wsfm.fsf@esperi.org.uk \
--to=nix@esperi.org.uk \
--cc=binutils@sourceware.org \
--cc=elena.zannoni@oracle.com \
--cc=gdb-patches@sourceware.org \
--cc=indu.bhagat@oracle.com \
--cc=jose.marchesi@oracle.com \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).