From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A4BB63858C83 for ; Wed, 19 Oct 2022 10:11:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A4BB63858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666174260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bl8XB8LODh8lPqujpZmCbHZqeQ9NddeXYYJqa7Dle0A=; b=dqPHvKSck64GJPaPZKj1tVzwQkg6dmMiUSy83OJtVxCNyOupHjd6CRKwtB7tJOv87wodMK YQVTVp/0HqMLSeHzoygwEYMOV37x49bDSbd0dIw2VttAJzoU1ROW/9ScrpqOe9HS610stz tvdr2p9caNl7Vr2OJbHLl06aYB4DPow= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-81-Kw1kzeCpOlWdFPX73ekKmA-1; Wed, 19 Oct 2022 06:10:59 -0400 X-MC-Unique: Kw1kzeCpOlWdFPX73ekKmA-1 Received: by mail-qv1-f70.google.com with SMTP id t19-20020a056214119300b004b03f58b1abso10316136qvv.17 for ; Wed, 19 Oct 2022 03:10:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bl8XB8LODh8lPqujpZmCbHZqeQ9NddeXYYJqa7Dle0A=; b=DPAN3G/zzJh7RBYoLl6j845ig3+wngqIChE52pagzITpjiaaf8oLJRfib3ZhyfubEQ 5Jgh+v+NRRkEfQKr0NsBo7q68PPdlxGAtbVvzIqbZH0FISrxTaQTbrNjmAi8yjCirZPv XeAMdBAepPi1NCXwQfINK+5HoDgN1inxtJ4Btg30c3am8y7g3JLulBHm+fLJ31kGRLNf sQKsyRBCarsvtOueTvWSr9YQL0vMgSr80/GV6UiKIF0SLKft/TH9j/dGaisKG77PifJl n1zBiRPk4eH3L8N6LlrWH+iCSlo5GrTeGteO+OSDcObC/gIvIYzu5fYbmxiR9FTlpTz2 2zuQ== X-Gm-Message-State: ACrzQf1rkbVQTo8fN9vIAFl4PnPOQjEqBAJnpgOwxxsINe18bDcteIno q8nSLakPy4AwloMv+0dDUL8fao9Mv5Y28J/N6D24KlAvxTVw1C+gi0CcjfeieTvvJf6LUXWTsS5 4oUNLFivRX2PYjPyURZFMuhyeO6hqBbbl6ELEVlb/+tVwMQYKdKnZ07RmJWcUEioFHyl3EQ== X-Received: by 2002:a0c:b294:0:b0:4b1:a396:d1cc with SMTP id r20-20020a0cb294000000b004b1a396d1ccmr5936864qve.107.1666174258507; Wed, 19 Oct 2022 03:10:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM57ITmSbe9WH8IGpi4OlvfJhJsB4/F3SVy8D7p5Vs8YXyXcE2y819jpx8WGpIC7qlSUcrnsnw== X-Received: by 2002:a0c:b294:0:b0:4b1:a396:d1cc with SMTP id r20-20020a0cb294000000b004b1a396d1ccmr5936847qve.107.1666174258111; Wed, 19 Oct 2022 03:10:58 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id bn4-20020a05622a1dc400b0039ccbf75f92sm3695182qtb.11.2022.10.19.03.10.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 03:10:57 -0700 (PDT) From: Andrew Burgess To: binutils@sourceware.org Subject: Re: [PATCHv2 0/2] Disassembler styling for ARM In-Reply-To: References: Date: Wed, 19 Oct 2022 11:10:56 +0100 Message-ID: <874jw0aztb.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping! As the first patch in this series is too large to send to the mailing list (the code changes are in opcodes/arm-dis.c and pretty small, but there's lots of test result updates), I've pushed this whole series to the branch: users/aburgess/arm-disasm-styling if that makes reviewing easier for anyone. Thanks, Andrew Andrew Burgess writes: > This series adds disassembler styling for ARM. > > Changes since v1: > > - Patch #1 is now much bigger! The ARM disassembler now uses '@' > consistently for its comment character. This is a minor change in > the disassembler, but a huge change in the expected test results. > > I believe I've fixed all the tests; I'm not seeing any failures, > but as always, I suspect I will have missed something. I > apologies in advance, and hopefully, it should be pretty easy to > update any tests I've missed. > > - Patch #2 is largely unchanged. The only difference is that we now > look for '@' to indicate the start of a comment instead of ';'. > > All feedback welcome. > > Thanks, > Andrew > > --- > > Andrew Burgess (2): > opcodes/arm: use '@' consistently for the comment character > opcodes/arm: add disassembler styling for arm > > .../testsuite/binutils-all/arm/objdump.exp | 4 +- > gas/testsuite/gas/arm/adr.d | 2 +- > gas/testsuite/gas/arm/adrl.d | 20 +- > gas/testsuite/gas/arm/arch4t-eabi.d | 8 +- > gas/testsuite/gas/arm/arch4t.d | 8 +- > gas/testsuite/gas/arm/arch7.d | 4 +- > gas/testsuite/gas/arm/arch7a-mp.d | 6 +- > gas/testsuite/gas/arm/arch7r-mp.d | 6 +- > gas/testsuite/gas/arm/archv6t2.d | 10 +- > gas/testsuite/gas/arm/archv8m-base.d | 12 +- > gas/testsuite/gas/arm/archv8m-main-dsp-1.d | 12 +- > gas/testsuite/gas/arm/archv8m-main.d | 12 +- > gas/testsuite/gas/arm/arm3.d | 2 +- > gas/testsuite/gas/arm/arm6.d | 4 +- > gas/testsuite/gas/arm/arm7dm.d | 6 +- > gas/testsuite/gas/arm/arm7t.d | 26 +- > gas/testsuite/gas/arm/armv1.d | 8 +- > gas/testsuite/gas/arm/armv7-a+virt.d | 4 +- > .../gas/arm/armv8-2-fp16-scalar-ext.d | 8 +- > .../gas/arm/armv8-2-fp16-scalar-thumb-ext.d | 8 +- > .../gas/arm/armv8-2-fp16-scalar-thumb.d | 8 +- > gas/testsuite/gas/arm/armv8-2-fp16-scalar.d | 8 +- > gas/testsuite/gas/arm/armv8.1-m.main-fp.d | 70 +- > gas/testsuite/gas/arm/armv8.1-m.main-hp.d | 8 +- > gas/testsuite/gas/arm/bl-local-2.d | 10 +- > gas/testsuite/gas/arm/bl-local-v4t.d | 10 +- > gas/testsuite/gas/arm/blx-bad.d | 14 +- > gas/testsuite/gas/arm/blx-local-thumb.d | 10 +- > gas/testsuite/gas/arm/blx-local.d | 12 +- > gas/testsuite/gas/arm/branch-reloc.d | 10 +- > gas/testsuite/gas/arm/ccs.d | 2 +- > .../gas/arm/copro-arm_v2plus-arm_v2.d | 8 +- > .../gas/arm/copro-arm_v5plus-arm_v5.d | 4 +- > .../arm/copro-thumb_v6t2plus-thumb_v6t2-1.d | 4 +- > .../arm/copro-thumb_v6t2plus-thumb_v6t2-2.d | 4 +- > gas/testsuite/gas/arm/crc32-armv8-a-bad.d | 24 +- > gas/testsuite/gas/arm/crc32-armv8-r-bad.d | 24 +- > gas/testsuite/gas/arm/dis-data3.d | 2 +- > gas/testsuite/gas/arm/el_segundo.d | 2 +- > gas/testsuite/gas/arm/float.d | 2 +- > gas/testsuite/gas/arm/group-reloc-alu.d | 160 +- > gas/testsuite/gas/arm/group-reloc-ldrs.d | 240 +- > gas/testsuite/gas/arm/immed.d | 10 +- > gas/testsuite/gas/arm/immed2.d | 2 +- > gas/testsuite/gas/arm/inst.d | 36 +- > gas/testsuite/gas/arm/iwmmxt.d | 2 +- > gas/testsuite/gas/arm/ldconst.d | 42 +- > gas/testsuite/gas/arm/ldr-global.d | 14 +- > gas/testsuite/gas/arm/ldr-t.d | 16 +- > gas/testsuite/gas/arm/ldr.d | 10 +- > gas/testsuite/gas/arm/ldst-offset0.d | 6 +- > gas/testsuite/gas/arm/ldst-pc.d | 8 +- > gas/testsuite/gas/arm/m0-load-pseudo.d | 4 +- > gas/testsuite/gas/arm/m23-load-pseudo.d | 4 +- > gas/testsuite/gas/arm/m33-load-pseudo.d | 4 +- > gas/testsuite/gas/arm/macro1.d | 6 +- > gas/testsuite/gas/arm/mapdir.d | 4 +- > gas/testsuite/gas/arm/mapmisc.d | 38 +- > gas/testsuite/gas/arm/mapsecs.d | 10 +- > gas/testsuite/gas/arm/mapshort-eabi.d | 10 +- > gas/testsuite/gas/arm/mapshort-elf.d | 10 +- > gas/testsuite/gas/arm/mask_1-armv8-a.d | 32 +- > gas/testsuite/gas/arm/mask_1-armv8-r.d | 32 +- > gas/testsuite/gas/arm/mrs-msr-arm-v6.d | 6 +- > gas/testsuite/gas/arm/mrs-msr-arm-v7-a.d | 6 +- > gas/testsuite/gas/arm/msr-imm.d | 268 +- > gas/testsuite/gas/arm/mve-vand.d | 94 +- > gas/testsuite/gas/arm/mve-vbic.d | 20 +- > gas/testsuite/gas/arm/mve-vcvt-3.d | 80 +- > gas/testsuite/gas/arm/mve-vmov-1.d | 20 +- > gas/testsuite/gas/arm/mve-vmov-2.d | 34 +- > .../gas/arm/mve-vmov-vmvn-vorr-vbic.d | 64 +- > gas/testsuite/gas/arm/mve-vmvn.d | 114 +- > gas/testsuite/gas/arm/mve-vorn.d | 22 +- > gas/testsuite/gas/arm/mve-vorr.d | 20 +- > gas/testsuite/gas/arm/neon-cond-bad_t2.d | 4 +- > gas/testsuite/gas/arm/neon-const.d | 516 ++-- > gas/testsuite/gas/arm/neon-cov.d | 564 ++-- > gas/testsuite/gas/arm/neon-ldst-rm.d | 4 +- > gas/testsuite/gas/arm/neon-logic.d | 8 +- > gas/testsuite/gas/arm/nops.d | 2 +- > gas/testsuite/gas/arm/offset-1.d | 8 +- > gas/testsuite/gas/arm/offset.d | 8 +- > gas/testsuite/gas/arm/pr21458.d | 14 +- > gas/testsuite/gas/arm/pr24907.d | 6 +- > gas/testsuite/gas/arm/pr25235.d | 14 +- > gas/testsuite/gas/arm/push-pop.d | 8 +- > gas/testsuite/gas/arm/reg-alias.d | 6 +- > gas/testsuite/gas/arm/relax_branch_align.d | 8 +- > gas/testsuite/gas/arm/relax_load_align.d | 6 +- > gas/testsuite/gas/arm/sp-pc-usage-t.d | 8 +- > gas/testsuite/gas/arm/tcompat.d | 6 +- > gas/testsuite/gas/arm/tcompat2.d | 8 +- > gas/testsuite/gas/arm/thumb-eabi.d | 42 +- > gas/testsuite/gas/arm/thumb-nop.d | 4 +- > gas/testsuite/gas/arm/thumb.d | 42 +- > gas/testsuite/gas/arm/thumb1_unified.d | 4 +- > gas/testsuite/gas/arm/thumb2_add.d | 38 +- > gas/testsuite/gas/arm/thumb2_invert.d | 24 +- > gas/testsuite/gas/arm/thumb2_pool.d | 32 +- > gas/testsuite/gas/arm/thumb2_relax.d | 52 +- > gas/testsuite/gas/arm/thumb2_vpool.d | 158 +- > gas/testsuite/gas/arm/thumb2_vpool_be.d | 158 +- > gas/testsuite/gas/arm/thumb32.d | 186 +- > gas/testsuite/gas/arm/thumbv6.d | 8 +- > gas/testsuite/gas/arm/thumbv6k.d | 8 +- > gas/testsuite/gas/arm/tls.d | 14 +- > gas/testsuite/gas/arm/tls_vxworks.d | 6 +- > gas/testsuite/gas/arm/udf.d | 24 +- > gas/testsuite/gas/arm/unpredictable.d | 2 +- > gas/testsuite/gas/arm/vfp-mov-enc.d | 18 +- > gas/testsuite/gas/arm/vfp-neon-overlap.d | 8 +- > gas/testsuite/gas/arm/vfp1.d | 6 +- > gas/testsuite/gas/arm/vfp1xD.d | 76 +- > gas/testsuite/gas/arm/vfp1xD_t2.d | 70 +- > gas/testsuite/gas/arm/vfpv3-32drs.d | 6 +- > gas/testsuite/gas/arm/vldconst.d | 246 +- > gas/testsuite/gas/arm/vldconst_be.d | 246 +- > gas/testsuite/gas/arm/vldr.d | 4 +- > gas/testsuite/gas/arm/wince.d | 12 +- > gas/testsuite/gas/arm/wince_inst.d | 36 +- > gas/testsuite/gas/arm/xscale.d | 4 +- > ld/testsuite/ld-arm/arm-app-abs32.d | 8 +- > ld/testsuite/ld-arm/arm-app.d | 6 +- > ld/testsuite/ld-arm/arm-be8.d | 2 +- > ld/testsuite/ld-arm/arm-call.d | 8 +- > ld/testsuite/ld-arm/arm-lib-plt32.d | 6 +- > ld/testsuite/ld-arm/arm-lib.d | 6 +- > ld/testsuite/ld-arm/arm-movwt.d | 40 +- > ld/testsuite/ld-arm/arm-pic-veneer.d | 4 +- > ld/testsuite/ld-arm/armthumb-lib.d | 16 +- > ld/testsuite/ld-arm/attr-merge-wchar-24.d | 2 +- > ld/testsuite/ld-arm/attr-merge-wchar-42.d | 2 +- > ld/testsuite/ld-arm/callweak.d | 2 +- > ld/testsuite/ld-arm/cortex-a8-far.d | 6 +- > ld/testsuite/ld-arm/cortex-a8-fix-b-plt.d | 8 +- > ld/testsuite/ld-arm/cortex-a8-fix-bcc-plt.d | 8 +- > ld/testsuite/ld-arm/cortex-a8-fix-bl-plt.d | 8 +- > .../ld-arm/cortex-a8-fix-bl-rel-plt.d | 8 +- > ld/testsuite/ld-arm/cortex-a8-fix-blx-plt.d | 8 +- > .../ld-arm/farcall-arm-arm-pic-veneer.d | 2 +- > ld/testsuite/ld-arm/farcall-arm-arm.d | 2 +- > ld/testsuite/ld-arm/farcall-arm-nacl-pic.d | 4 +- > ld/testsuite/ld-arm/farcall-arm-nacl.d | 4 +- > .../ld-arm/farcall-arm-thumb-blx-pic-veneer.d | 2 +- > ld/testsuite/ld-arm/farcall-arm-thumb-blx.d | 2 +- > .../ld-arm/farcall-arm-thumb-pic-veneer.d | 2 +- > ld/testsuite/ld-arm/farcall-arm-thumb.d | 2 +- > ld/testsuite/ld-arm/farcall-data-nacl.d | 4 +- > ld/testsuite/ld-arm/farcall-data.d | 2 +- > ld/testsuite/ld-arm/farcall-group-limit.d | 2 +- > ld/testsuite/ld-arm/farcall-group-size2.d | 10 +- > ld/testsuite/ld-arm/farcall-group.d | 10 +- > ld/testsuite/ld-arm/farcall-mix.d | 10 +- > ld/testsuite/ld-arm/farcall-mix2.d | 10 +- > ld/testsuite/ld-arm/farcall-mixed-app-v5.d | 26 +- > ld/testsuite/ld-arm/farcall-mixed-app.d | 26 +- > ld/testsuite/ld-arm/farcall-mixed-app2.d | 28 +- > ld/testsuite/ld-arm/farcall-mixed-lib-v4t.d | 36 +- > ld/testsuite/ld-arm/farcall-mixed-lib.d | 24 +- > .../ld-arm/farcall-thumb-arm-blx-pic-veneer.d | 2 +- > ld/testsuite/ld-arm/farcall-thumb-arm-blx.d | 2 +- > .../ld-arm/farcall-thumb-arm-pic-veneer.d | 2 +- > ld/testsuite/ld-arm/farcall-thumb-arm.d | 2 +- > .../farcall-thumb-thumb-blx-pic-veneer.d | 2 +- > ld/testsuite/ld-arm/farcall-thumb-thumb-blx.d | 2 +- > .../ld-arm/farcall-thumb-thumb-m-no-profile.d | 2 +- > .../ld-arm/farcall-thumb-thumb-m-pic-veneer.d | 2 +- > ld/testsuite/ld-arm/farcall-thumb-thumb-m.d | 2 +- > .../ld-arm/farcall-thumb-thumb-pic-veneer.d | 2 +- > ld/testsuite/ld-arm/farcall-thumb-thumb.d | 2 +- > ld/testsuite/ld-arm/farcall-thumb2-purecode.d | 2 +- > ld/testsuite/ld-arm/farcall-thumb2-thumb2-m.d | 2 +- > ld/testsuite/ld-arm/fdpic-main-m.d | 16 +- > ld/testsuite/ld-arm/fdpic-main.d | 16 +- > ld/testsuite/ld-arm/fdpic-shared-m.d | 4 +- > ld/testsuite/ld-arm/fdpic-shared.d | 4 +- > ld/testsuite/ld-arm/fix-arm1176-off.d | 2 +- > ld/testsuite/ld-arm/fix-arm1176-on.d | 2 +- > ld/testsuite/ld-arm/gc-hidden-1.d | 2 +- > ld/testsuite/ld-arm/group-relocs.d | 58 +- > ld/testsuite/ld-arm/ifunc-1.dd | 50 +- > ld/testsuite/ld-arm/ifunc-10.dd | 236 +- > ld/testsuite/ld-arm/ifunc-11.dd | 28 +- > ld/testsuite/ld-arm/ifunc-12.dd | 28 +- > ld/testsuite/ld-arm/ifunc-13.dd | 28 +- > ld/testsuite/ld-arm/ifunc-14.dd | 42 +- > ld/testsuite/ld-arm/ifunc-15.dd | 42 +- > ld/testsuite/ld-arm/ifunc-16.dd | 36 +- > ld/testsuite/ld-arm/ifunc-17.dd | 2 +- > ld/testsuite/ld-arm/ifunc-2.dd | 146 +- > ld/testsuite/ld-arm/ifunc-3.dd | 40 +- > ld/testsuite/ld-arm/ifunc-4.dd | 236 +- > ld/testsuite/ld-arm/ifunc-5.dd | 26 +- > ld/testsuite/ld-arm/ifunc-6.dd | 38 +- > ld/testsuite/ld-arm/ifunc-7.dd | 18 +- > ld/testsuite/ld-arm/ifunc-8.dd | 118 +- > ld/testsuite/ld-arm/ifunc-9.dd | 56 +- > .../jump-reloc-veneers-cond-long-backward.d | 2 +- > .../ld-arm/jump-reloc-veneers-cond-long.d | 2 +- > ld/testsuite/ld-arm/jump-reloc-veneers-long.d | 2 +- > ld/testsuite/ld-arm/long-plt-format.d | 4 +- > ld/testsuite/ld-arm/mixed-app-v5.d | 26 +- > ld/testsuite/ld-arm/mixed-app.d | 26 +- > ld/testsuite/ld-arm/mixed-lib.d | 12 +- > ld/testsuite/ld-arm/movw-merge.d | 4 +- > ld/testsuite/ld-arm/non-contiguous-arm2.d | 10 +- > ld/testsuite/ld-arm/non-contiguous-arm3.d | 12 +- > ld/testsuite/ld-arm/non-contiguous-arm5.d | 10 +- > ld/testsuite/ld-arm/non-contiguous-arm6.d | 12 +- > .../ld-arm/stm32l4xx-cannot-fix-far-ldm.d | 2 +- > ld/testsuite/ld-arm/stm32l4xx-fix-ldm.d | 8 +- > ld/testsuite/ld-arm/stm32l4xx-fix-vldm-dp.d | 2 +- > ld/testsuite/ld-arm/stm32l4xx-fix-vldm.d | 2 +- > ld/testsuite/ld-arm/thumb-plt.d | 4 +- > ld/testsuite/ld-arm/thumb1-adds.d | 12 +- > ld/testsuite/ld-arm/thumb1-movs.d | 10 +- > ld/testsuite/ld-arm/thumb2-bl-as-thumb1-bad.d | 2 +- > ld/testsuite/ld-arm/thumb2-bl-bad.d | 2 +- > ld/testsuite/ld-arm/tls-app.d | 4 +- > ld/testsuite/ld-arm/tls-descrelax-be32.d | 112 +- > ld/testsuite/ld-arm/tls-descrelax-be8.d | 78 +- > ld/testsuite/ld-arm/tls-descrelax-v7.d | 78 +- > ld/testsuite/ld-arm/tls-descrelax.d | 112 +- > ld/testsuite/ld-arm/tls-descseq.d | 20 +- > ld/testsuite/ld-arm/tls-gdesc-neg.d | 14 +- > ld/testsuite/ld-arm/tls-gdesc.d | 22 +- > ld/testsuite/ld-arm/tls-gdierelax.d | 8 +- > ld/testsuite/ld-arm/tls-gdierelax2.d | 10 +- > ld/testsuite/ld-arm/tls-gdlerelax.d | 4 +- > ld/testsuite/ld-arm/tls-lib-loc.d | 14 +- > ld/testsuite/ld-arm/tls-lib.d | 4 +- > ld/testsuite/ld-arm/tls-longplt-lib.d | 28 +- > ld/testsuite/ld-arm/tls-longplt.d | 30 +- > ld/testsuite/ld-arm/tls-thumb1.d | 36 +- > ld/testsuite/ld-arm/vxworks1-lib.dd | 12 +- > ld/testsuite/ld-arm/vxworks1.dd | 10 +- > opcodes/arm-dis.c | 2660 ++++++++++------- > 238 files changed, 5146 insertions(+), 4518 deletions(-) > > -- > 2.25.4