From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5D3453829BEA for ; Fri, 10 Jun 2022 13:01:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D3453829BEA Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-513-z3xSNPcdMaywqirlgEc8Eg-1; Fri, 10 Jun 2022 09:01:51 -0400 X-MC-Unique: z3xSNPcdMaywqirlgEc8Eg-1 Received: by mail-wm1-f69.google.com with SMTP id m22-20020a7bcb96000000b0039c4f6ade4dso4991191wmi.8 for ; Fri, 10 Jun 2022 06:01:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=cHR0DBdWPzm9MArZVr/iPM34eRhQFrVS9QuLmrU/KH8=; b=gWEGSPIwSCM1uAdU+Zljq3OG0mgV0Yrvi9NmJaXiGSxYL9lycu9hlJS0aYP0Y1Umoz zQywnGsiYdatQvXxHA8wxG/IRnR9srZLPpUiZee03nPgAWnDfC+tsMr3up5fhZ9K2Kc2 ibWe1HyaBBotVoU+NWzaIljvKZDraAMe+Cjdv+/WyzoSqkgV4/ylnyAHNa4qfCVhmuDl y3R/DFszZorVPdzsZ5QI1LoYlCph3oEFqcvFzOw2YNd6fW/D3r5Xic6OAZXxkwRdnSYr ZEUQor1Fvc9ISSwQUstpC2c3ehXLpXi4/qGkSM+BzseWiU0zp1P+PS11HRRnYfTDEETL uFjg== X-Gm-Message-State: AOAM5301CO6FAkrVik0rkatI9wzeEUWR6gfxt4QnaHFagUGcfJxE6Iz4 yUwl0wW2ZWjtpylGv8hX58i+2iPX1+50dHdzPVCbJsarSPhLiBifYLdNdHvciKzgNfM5zSjlDXP ggFe68ksyKUa9sEt5/A== X-Received: by 2002:a05:6000:2c8:b0:218:4982:7f90 with SMTP id o8-20020a05600002c800b0021849827f90mr23647377wry.64.1654866110084; Fri, 10 Jun 2022 06:01:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzJnPECbiJb6gd0Hvkl9Y7urmAHsux/q/W0/rYWL9Xb7jmA0V3OZ47NNZ6+2ZOOvCEILZzeBQ== X-Received: by 2002:a05:6000:2c8:b0:218:4982:7f90 with SMTP id o8-20020a05600002c800b0021849827f90mr23647295wry.64.1654866109298; Fri, 10 Jun 2022 06:01:49 -0700 (PDT) Received: from localhost (host109-152-215-36.range109-152.btcentralplus.com. [109.152.215.36]) by smtp.gmail.com with ESMTPSA id s21-20020a1cf215000000b0039aef592ca0sm2821522wmc.35.2022.06.10.06.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jun 2022 06:01:48 -0700 (PDT) From: Andrew Burgess To: Jan Beulich Cc: binutils@sourceware.org Subject: Re: [PATCHv3] libopcodes: extend the styling within the i386 disassembler In-Reply-To: References: <20220509125414.3526554-1-aburgess@redhat.com> <20220527174443.223739-1-aburgess@redhat.com> Date: Fri, 10 Jun 2022 14:01:47 +0100 Message-ID: <874k0sfz9g.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2022 13:01:55 -0000 Jan Beulich via Binutils writes: > On 27.05.2022 19:44, Andrew Burgess via Binutils wrote: >> @@ -11595,11 +11750,15 @@ OP_E_memory (instr_info *ins, int bytemode, int sizeflag) >> print_displacement (ins, ins->scratchbuf, disp); >> else >> print_operand_value (ins, ins->scratchbuf, 1, disp); >> - oappend (ins, ins->scratchbuf); >> + oappend_with_style (ins, ins->scratchbuf, >> + dis_style_address_offset); > > Is there a reason you changed this to dis_style_address_offset, but > not the other cases where print_displacement() is used (always for > similar purposes)? I'm asking because I'm going to touch all these > instances, so if dis_style_address_offset was always meant to be > used there, I'd switch that around kind of as a side effect. I think they should all be dis_style_address_offset. Sorry for missing these. Thanks, Andrew