From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: Nick Clifton <nickc@redhat.com>
Cc: hawkinsw@obs.cr, binutils@sourceware.org
Subject: Re: Missing indcall-badoperand.d
Date: Tue, 20 Feb 2024 12:05:53 +0100 [thread overview]
Message-ID: <875xyj9yzy.fsf@oracle.com> (raw)
In-Reply-To: <874je3fmnt.fsf@redhat.com> (Nick Clifton's message of "Tue, 20 Feb 2024 10:35:50 +0000")
> Hi Will,
>
> Your recent commit ecd16ae4e471 appears to have omitted the new files,
> resulting in an error in the gas testsuite:
>
> ERROR: couldn't open "gas/testsuite/gas/bpf/indcall-badoperand.d": no such file or directory
>
> Please could you check and fix the issue ? Thanks.
My fault.
Fixed as below.
commit f1efdade946d7dab958c4ecbf5feea9aba01e280 (HEAD -> master, origin/master, origin/HEAD)
Author: Jose E. Marchesi <jose.marchesi@oracle.com>
Date: Tue Feb 20 12:03:43 2024 +0100
bpf: gas: add missing indcall-badoperand.* test files
This adds teh following files that were missing in the previous
commit ecd16ae4e47118f66447641d93a6aa1334e550d4
testsuite/gas/bpf/indcall-badoperand.d
testsuite/gas/bpf/indcall-badoperand.l
testsuite/gas/bpf/indcall-badoperand.s
diff --git a/gas/testsuite/gas/bpf/indcall-badoperand.d b/gas/testsuite/gas/bpf/indcall-badoperand.d
new file mode 100644
index 00000000000..bf2e9e8e643
--- /dev/null
+++ b/gas/testsuite/gas/bpf/indcall-badoperand.d
@@ -0,0 +1,3 @@
+#as: -EL -mno-relax
+#source: indcall-badoperand.s
+#error_output: indcall-badoperand.l
diff --git a/gas/testsuite/gas/bpf/indcall-badoperand.l b/gas/testsuite/gas/bpf/indcall-badoperand.l
new file mode 100644
index 00000000000..d791435a2ac
--- /dev/null
+++ b/gas/testsuite/gas/bpf/indcall-badoperand.l
@@ -0,0 +1,3 @@
+.*: Assembler messages:
+.*:7: Error: unrecognized instruction `call %0'
+.*:7: Error: expected register name, got '%0'
diff --git a/gas/testsuite/gas/bpf/indcall-badoperand.s b/gas/testsuite/gas/bpf/indcall-badoperand.s
new file mode 100644
index 00000000000..cf19c0a56b6
--- /dev/null
+++ b/gas/testsuite/gas/bpf/indcall-badoperand.s
@@ -0,0 +1,8 @@
+
+ .text
+ .align 4
+main:
+
+ mov %r0, 1
+ call %0
+ exit
next prev parent reply other threads:[~2024-02-20 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 10:35 Nick Clifton
2024-02-20 11:05 ` Jose E. Marchesi [this message]
2024-02-20 17:52 ` Will Hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xyj9yzy.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=binutils@sourceware.org \
--cc=hawkinsw@obs.cr \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).