From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 13F053858D33 for ; Wed, 1 Feb 2023 15:32:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13F053858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675265537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6myIFt/i5CqKVuHBkcoCH/SAkQuJRTWPizR1qxe35hw=; b=RSV7PevlO4yx5nC9eOHJ1HX3wCwd1NTeA6gU/+Kk2JxNz4rL2s9msGj34FwsVhO3HMIfUk kJyuWCNOww0MIeU/5N2zR2sGd014ZAsbeeTcIfVOBBrZB1CvegywuR4O1GpMLIaP4hhDFc x1XYKihwLNNMUCeK1ZRzUCyvH+/G/GQ= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-199-QeP4eIXoNuCU-3ONXKljGQ-1; Wed, 01 Feb 2023 10:32:16 -0500 X-MC-Unique: QeP4eIXoNuCU-3ONXKljGQ-1 Received: by mail-qv1-f72.google.com with SMTP id mx2-20020a0562142e0200b0053807f3eb76so9475246qvb.15 for ; Wed, 01 Feb 2023 07:32:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6myIFt/i5CqKVuHBkcoCH/SAkQuJRTWPizR1qxe35hw=; b=dxv8gnOBPGo1+eiyufNYymDwrVSSxBGs1fuoBLPPFe1NxXNS94j26me2D/DmmJqcpO vfyOD1iIBwijU+S8kW+YLObVSG/KQ+N/k8A1vuzDWtgYvYRjNr4iWn0k8xjY+UFa4YM+ 4nJLa+N+OkROIbdk8bzhdSWvYvaGRSz2n2VNM4VgetHM8mLSqXZqCgLUR8n1oS//gX4d Y9J5WRr1qvYRQniHz0mGnJxxQump0GdnfgHLWE8lj7sp7GqCLUynLGX/ro5xpvdMayOh glddqK53aBPI/fRS+u/AXfRcu0o69uoJ9LDiVi4TCxXag31spB8diA1e04dhpjsD+2fB UNyA== X-Gm-Message-State: AO0yUKVusQNb27fMIT2nSy1nQmPRUD29qhBp0rmxJWQ7nCN0P00yjOkx 39zVToBftBLhtGVi8ZBUpjxHTCkTRr0oMjDizxB1l/Jwjicr36506Yh80UwjFa+WPm6Dtq05I8W mQ0qSL9d3N2ScHvH1wQ== X-Received: by 2002:a05:622a:1828:b0:3b8:6c10:2cc0 with SMTP id t40-20020a05622a182800b003b86c102cc0mr4561437qtc.38.1675265535398; Wed, 01 Feb 2023 07:32:15 -0800 (PST) X-Google-Smtp-Source: AK7set8D80z/D/WuyMAp0BEGoeJNJbNBSpSNCAjwqC666g6lVi475tJQvYUSlin06cpaiUh2BAiwJw== X-Received: by 2002:a05:622a:1828:b0:3b8:6c10:2cc0 with SMTP id t40-20020a05622a182800b003b86c102cc0mr4561408qtc.38.1675265535058; Wed, 01 Feb 2023 07:32:15 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id x19-20020a05620a14b300b00706aeebe71csm5266577qkj.108.2023.02.01.07.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 07:32:14 -0800 (PST) From: Andrew Burgess To: "Maciej W. Rozycki" Cc: binutils@sourceware.org Subject: Re: [PATCH 1/2] opcodes/mips: use .word/.short for undefined instructions In-Reply-To: References: <87fscny5tr.fsf@redhat.com> <87a62hfoa5.fsf@redhat.com> <87o7qguzzx.fsf@redhat.com> Date: Wed, 01 Feb 2023 15:32:12 +0000 Message-ID: <875ycltn9f.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: "Maciej W. Rozycki" writes: > Andrew, > >> I've updated the patch. Let me know what you think. > > I'd say it's OK, except that I put your change through my MIPS regression > tester and that revealed failures from your new case for numerous > targets, Can you let me know which targets I should configure for to expose these failures, then I can ensure I've fully tested this before posting an update. Thanks, Andrew > e.g.: > > mips-elf +FAIL: microMIPS source file contains reserved encoding (o32) > mips-img-elf +FAIL: microMIPS source file contains reserved encoding (o32) > mips-img-elf +FAIL: microMIPS source file contains reserved encoding (n32) > > etc. The usual suspect is section padding owing to different alignments > used with individual MIPS targets, e.g.: > > extra regexps in > .../binutils/testsuite/binutils-all/mips/micromips-reserved-enc-o32.d starting with "^ > \.\.\.$" > EOF from tmpdir/dump.out > FAIL: microMIPS source file contains reserved encoding (o32) > > See e.g. binutils/testsuite/binutils-all/mips/micromips-branch-alias.s for > how to add suitable padding at the end. > > And then: > > mipsisa32r6-elf +FAIL: microMIPS source file contains reserved encoding (o32) > mipsisa32r6-linux +FAIL: microMIPS source file contains reserved encoding (o32) > mipsisa32r6el-elf +FAIL: microMIPS source file contains reserved encoding (o32) > > etc., due to: > > .../binutils/testsuite/binutils-all/mips/micromips-reserved-enc.s: Assembler messages: > .../binutils/testsuite/binutils-all/mips/micromips-reserved-enc.s:3: Fatal error: `micromips' cannot be used with `mips32r6' > > We don't care about different ISA levels here, so let's set a reasonable > one, as in binutils/testsuite/binutils-all/mips/micromips-branch-alias.s > again: > > .module mips64r3 > > (it could be `.set' too, but let's be consistent, and it has to be a > 64-bit one for the n32/n64 ABIs). > > OK with these updates, thank you for your contribution. > > Maciej