public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org,  binutils@sourceware.org
Subject: Re: [PATCH] Sync libbacktrace from gcc [PR31327]
Date: Mon, 11 Mar 2024 23:12:59 +0000	[thread overview]
Message-ID: <877ci8mkg4.fsf@gentoo.org> (raw)
In-Reply-To: <87cys0pt31.fsf@tromey.com> (Tom Tromey's message of "Mon, 11 Mar 2024 11:38:10 -0600")

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Sam" == Sam James <sam@gentoo.org> writes:
>
> Sam> Note that this includes Nick's fix from edf64cd235f5ecb3725e7cf1ff83bbdb6dd53340 which
> Sam> landed upstream a bit differently as r13-1566-g9ed57796235abc in GCC.
>
> Sam> This pulls in libbacktrace as of r14-9404-gc775a030af9cad in GCC trunk.
>
> Thank you.  If this makes it identical to gcc then I think it's fine.
> If not perhaps posting the diff would be helpful.

Thanks. I've pushed it with a tiny diff compared to gcc after discussing
it on IRC (Simon pointed out the difference):

--- a/libbacktrace/configure.ac.gcc
+++ b/libbacktrace/configure.ac.binutils
@@ -84,8 +84,6 @@ AM_CONDITIONAL(HAVE_DWZ, test "$DWZ" != "")
 LT_INIT
 AM_PROG_LIBTOOL

-AM_CONDITIONAL([ENABLE_DARWIN_AT_RPATH], [test x$enable_darwin_at_rpath = xyes])
-
 AC_SYS_LARGEFILE

 backtrace_supported=yes

.. with the corresponding regen. It's described in the commit message --
it's from a top-level Darwin change which would need other syncing that
is best done separately.

>
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom

best,
sam

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]

      reply	other threads:[~2024-03-11 23:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-11 17:21 Sam James
2024-03-11 17:31 ` Simon Marchi
2024-03-11 17:43   ` Sam James
2024-03-11 17:38 ` Tom Tromey
2024-03-11 23:12   ` Sam James [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ci8mkg4.fsf@gentoo.org \
    --to=sam@gentoo.org \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).