From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 4E0443858C78 for ; Tue, 27 Feb 2024 15:05:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E0443858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4E0443858C78 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709046335; cv=pass; b=Sxxh6p8HiC8EihgEkCx6bg3CwGJ17VkYm4Ud2t0rda7awNnfwd31H5EopISXiXDp6H3Z4HloMNNYH3DSWsjKkPfNAs+p4fhGdhdOPGox4A43ezsdllX0Qwl6AGEoyqs+cYxEhNGNRw11ty9czN0iazHj5hoW654j0z6Cn/rR8og= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1709046335; c=relaxed/simple; bh=9oNxvMd8FYkA7fyEa1oAuy9+tl+v9YiTxib5aGS8tcw=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=d8ZVdqtqs1iJUaZEaNIrk02G0y/DfxPqL6unrx+mkw0zr17fQs3rUqlVue9A3RxyuEK//JN9xaQs5RXrTmQ2aZwHnK/j3kgMOx15mKgivNtWxcTfslpEhi45ND1KxJyq8ET51xUL4fM19Cx1f6908wHJqAEfDsiBa2dxtZrkpwU= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41RExkex009433; Tue, 27 Feb 2024 15:05:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2023-11-20; bh=fNXW9HV8cfRe80NJKhhHKN31aUD1bW3mDwHOOpA1URE=; b=kRGgd5JxGARpMP+aEzORl1G8gGLeNbJg48pVZ5towyRxfYjKU+rKRJDlqJZb+MvrwwWm ilOH/k6ABur0eU8CvWSeIoRUcnQ6RSPu3NKr7gYoYQQUl071sfONUZOO1wGVXOwjZCEx oF0ByVxdwJEUHvQPkDF2WvgSOAORiu/MYCw3wdA2DH8L98ZaAg0FCKxSxy+jt9mxpbAn 8apjDxkJXonf4L7tGM6LEMTWwQKuAjruKA6qDE1oZZ13STFA0LUBH3ip9ld75zEYfG0S RnXvwDoqfhODACX+s7DFFCj55IwiE27PBNjF6AeUXNcMiCDUw464cc5HchE59U/Rz3ij fQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wf7ccfg23-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Feb 2024 15:05:16 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41REk8sA025496; Tue, 27 Feb 2024 15:05:15 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wf6wdtget-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Feb 2024 15:05:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M/BR1SIB2xvbHy8+hpUp7H+4eRjuQPagMpKsRNv+nmDi11Lc829l22LBZ5E5Bh6cfQsPCIowLFMkQ0oCxVpNpvzqFsmwN3HuAVD6W3I+NUHJqO/uXtOsHLc4tFWS4+ORGXtMX3Z5p/hU8I7yD2qIkjCUFMWEb2RHOM++wlI7dFw+OuARLP9RHy9mkpsgMN0gSZvPWSs4Tbw3U7clvcUiMZiOWfLO/ufJJJhN2bRb6odiuR/yUCiQULk4C2Mf57hgKjz5ea1eR5jvHPp87dOVJpdOZLkwofO7lCOUIjnM3zUtLpIyWpdiFL1+e3WcKDXQbsXQLeCPRobyyG0IPIx70A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fNXW9HV8cfRe80NJKhhHKN31aUD1bW3mDwHOOpA1URE=; b=el41Oshx6vQMOM026pNu9xR2F6fCwLIg48ne2/cvl2xRDbTlFLHmTLE6vBeLhdtG3leYdCuhtZP5z1KaugbQLXC3NwyvQ3O8QEdfdgdxAX6WEsprAVVQPrbtBb7rbbXB/3MzMm/Zt4vsu1bJajI0LHfxjLnCVzxNM85izMKKcwTuyLiIYcAZWMtbr4sO0L5lImEGVpvo8kTCAFDrNly/18K5OBne0LpkoHLNu/wPXiHjdtaOgwA4sdF+0bYax1kYbrxG23NdFx5EWo/qAq3uoA/BBa0gUP0Bu8vt4OudJVhXBNNiyNr9x+d9eDKs+wgrRRC1KG81Uwip9bVzj80Aaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fNXW9HV8cfRe80NJKhhHKN31aUD1bW3mDwHOOpA1URE=; b=e/1EiSCVDEmHB+zEdfdcw8VIxqphY4pWym+uFLF0j9n1yRwcdMOl6GabevsB+7abtwEnFT7faX9BiZxTFuFRpt1Kgra0sWM0YzW2QgnvKfDf/2J7xMTHDQQQNkPTBCLsQ7MZ5EotqHqitK/r2vw1gl6UOa16+nkIMhlEW5gMGlQ= Received: from MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) by SN7PR10MB6953.namprd10.prod.outlook.com (2603:10b6:806:34c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.36; Tue, 27 Feb 2024 15:05:07 +0000 Received: from MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751]) by MW4PR10MB6608.namprd10.prod.outlook.com ([fe80::67a4:9544:7249:7751%7]) with mapi id 15.20.7316.034; Tue, 27 Feb 2024 15:05:07 +0000 From: Nick Alcock To: Sam James Cc: Nicholas Vinson , binutils Subject: Re: [binutils] libctf: Remove undefined functions from ver. map References: <87bk828z6q.fsf@gentoo.org> Emacs: a compelling argument for pencil and paper. Date: Tue, 27 Feb 2024 15:05:01 +0000 In-Reply-To: <87bk828z6q.fsf@gentoo.org> (Sam James's message of "Tue, 27 Feb 2024 01:37:33 +0000") Message-ID: <877ciqvtgi.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO2P265CA0394.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::22) To MW4PR10MB6608.namprd10.prod.outlook.com (2603:10b6:303:22e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR10MB6608:EE_|SN7PR10MB6953:EE_ X-MS-Office365-Filtering-Correlation-Id: 949421f0-dacc-4b3b-71db-08dc37a57c3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RFV3Tu/qNcpNN2ViLzHLsZ7MCe+napmyXfNUKuVVUVaMHFp42NHWnNJmmVDZuPvTWbvOqB0JBa0Nw78QHQBV3qQDhA7e05SE4edk1RymhvJpZpB+JQcAWBX2K2prqPaVpu8Mt1VLHEkBEjLgNgKguz1xa91AVIdsaG16FVBOzd2Hgvwe4/Ot3OQCSUqclO8T1/UPWFm/ljHeRxR0JbI563CsQ4MyX5+ZygZtoIOlAesTOMaf4yN0KYvInfo6PZDRSwzZxEZ8/MC55npCRySkFVXhPzSEZl/6KvakAvgZFONQb3m2F+/0VFyby+O5BqFvpCywWJC1KtWwjbHXGCWd2naEMdmoGwkqLQ9J4+zWPuNHSoYl8IECRhxXyXiGzCidyUs9ZgCflKYM2ah+n/2sy5wgwHzkZ6MyLB+lNq6f+w3Awnw5694apzU+3T0HCCVhUiJMINrtKCZ5vSpYHDhoxvIr/y3b4TCxd0d4hk/JXiRySuO1lWYmlZ7yQ+2vdUreIqDWeBhlwWSAlh3E0xvQaU7dnoUWC993kPBrqTqYN7Hulq/fm8eeJzM97mmhY2STMeEd3vpK9hvPKisIP3VWNmOB5H2UBHUEsPM4zuZoPKaHxGGhgsH+s24aq4tt1yDK X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR10MB6608.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/m5yGfACsd90TCiS/yBHQtVXaTYTFNJi2FEkQSsZh9UclyTfdzJ5L2VrpZcL?= =?us-ascii?Q?evoXE2MX2QQ8WzfGAo0790qzuus7Lbm8G1u0Wkqc9IZkzKR3kaC9A6JqmtEI?= =?us-ascii?Q?/8VFGWS1e3CWfjNzJAI6QlzK2lR0ygCHaYwcRYqfKGlDNFXm36hM/KxqxcD7?= =?us-ascii?Q?VRio36wh4BAyOWDtTX6W4CpRn4y9DbV7Na2v19+AsOw54RoiXc5mjCC21USu?= =?us-ascii?Q?lO7bY1yn7u+eDLNNL73em49xDDz3HjMjRAy/LXSn07H97BGIUbJxEbTTskrl?= =?us-ascii?Q?k26OGdwZsHZXhNOlwBTJ5gNNHhdJ3KD3fvhjGXbra4TF3rX/u+7hYyVi18p5?= =?us-ascii?Q?Pk7Z9y7XjGeSpXhbyt3PJ6fatBMcAXvrNgG9Ys/z1VzRvhjZLUbA2WBxP7Og?= =?us-ascii?Q?YQ4hhp+bpWHNg8MMFiEIj0mbK5j7infkiVp19PPcao1dLzWMPqXX1WgR30yq?= =?us-ascii?Q?X1cJ2fP+sjr9jJtvWjvAydBneVYe+AC08F/0N5vNVUeluRQMet0ixovgJQew?= =?us-ascii?Q?Gsm9iu+lOmd36qUsJd1iKTMWQsKH4nbMvtqA9dxFKH9ptj/Ra01fiyGZiPnE?= =?us-ascii?Q?R1rXjUVeuLq1M5tH+0wxohf9bmf10dy1lC1GMGa7kT0Tr2kfmyTFj0NjFRbt?= =?us-ascii?Q?B0WB1tbApONPTpvxHy12TZHAT9iAbf2qvVYJ8mtB0lTgb5Wt6aTl+E2yjgVb?= =?us-ascii?Q?Z2O5fyaF27YqBLGzFE4Ss2tMd/Q6QnJFUxDShfsHyjAXy+sfXYfpQdsmEiWs?= =?us-ascii?Q?ey/grE/IvG/i9CFULuPomPLbECE3mYS/aZDySuKz15+lPFEsjyCp0MVn+Gu1?= =?us-ascii?Q?YTlfHkq7AtFlf3CU03RL2X6ebTrmmY4UyyGqAFpTkCfi0MqSrg72IhKXKNyh?= =?us-ascii?Q?6WGPB0N3KwODDeu8VWEqGYV6BK8xUcaenZSKBD3WWZpkgJEDch2qDEcm5pHQ?= =?us-ascii?Q?3eR7+RRVE/uv9ZC8BzYoYd3DJG2TsTPZ69qI8Lcn9qs23DaWZKPhBHm5EBZJ?= =?us-ascii?Q?4jGSmSV2MLHuxX1E8WAmQTzlenGZE0GgiwYDY5H2u/XKj8W+W6KunojtoJot?= =?us-ascii?Q?Tv8LhQgQVoBfh1wtLgBEaLZMoiIn0apOvi74pQlajiHHYnO0OxpHXhCl73yn?= =?us-ascii?Q?piYXt0z5k49EJTPxnmSeP8dA+eQ6OjpQIYQrM+rwv5WLt5jIKJchX1315kUC?= =?us-ascii?Q?oOvnEaPRvIpft4ktEVHT6q9fBujdUvYpOFOxVsBDCDFVut7hymC8xR66wrGc?= =?us-ascii?Q?nvmJTpmiwo+P1Vhjv9gw4EbuMBKshRTWUVQjSQ24RhpILMfle5PWSwti0WUY?= =?us-ascii?Q?s554B7oM0j7KuUSJrN7oMbU9T/OiFJDuXADjN05CNsKqxO/NG5SwxjtwdTp+?= =?us-ascii?Q?IZGp9NJaYCQ/aOJy6n5U+/WutMmQnuvij0EGzXeVo1jGIpVQzCj6t64bQU6N?= =?us-ascii?Q?u5oRXDw3FFyGXendNPp+IKaAA5tJ58GsTkcYSpcKUbUMSbBNjWNFZDoeuNXA?= =?us-ascii?Q?Rk2DoigGNyX3zDRLVQaWDzdQM1bzEcq4zJNLFGKIg/ZETRQiIEPIqvw66Ptg?= =?us-ascii?Q?cu8PJ+7K+Omv682TZiMZj0bxMn9V+FdBIOkUcuQTKnqNvFkMhyWmjCjp7s2j?= =?us-ascii?Q?Wg=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GpP5FjLKK6v+flG3m4KKeoysAzZvPaJVKWWF62DBcaUKF9mvF8Cvt+9jNBiZU7SBM0Kg/T6EBl9SfxEmJOGqWljJyp5TIHfIxLyrLJvDVg2//1y7Obfgpyx67nGDgHiqgcOeoP9fBwuTdsBkNx5EiTRwfCilqXtzf7lpljuyyshvrcPtRvLyChtkd8Q6Va1XiyGQuZwMbOSGMCpYuR7ExVvxOju0iE7N33hORfe1RxAiebU9XvAXEzx7qHHpSZJq+/mocVzmTCqMymeXyZ+7NYW+cGvs0ZfFQz86sAa2AVwa4cSTM08q2bXEk8lhheNSbQVMv9rjuhNqP3z8JKca2dcAwMX2tNzUhih74U3nG1IGxsKdbPsEVzV2brD7XXrfFq0O2yg1Vu/xez+mxw9h4NEfLgN229I2wu5TCXkDrdokid4AJiki/XEOCrtvopFmTurovAHYCN9S6x6RDtnz5IcBC+3ctjsBuZnFJRAG4tJ/khsAtqSUlpIuqJWP1hVHAO1J9Xn4HI3idyDW5G/MwjBOtFurysb51QJNlM1vM597VXAclAyZ8y6ZpxKtfZhdg41kzRcVNmMIoYuj+jRyRnaFmqbpNg8l2pb/3UEFGoE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 949421f0-dacc-4b3b-71db-08dc37a57c3a X-MS-Exchange-CrossTenant-AuthSource: MW4PR10MB6608.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2024 15:05:07.5385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CNs4dUpM7NLAJk4kJHI+t5RKGlQ6CfNImDeToPqKCOcs46ivJKKvBbedz7+R9fJLSnnZBP2eerKQHd+FZ6yCWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6953 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-27_01,2024-02-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 adultscore=0 mlxlogscore=707 malwarescore=0 spamscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402270116 X-Proofpoint-ORIG-GUID: NK5cFRQp9Md-I2E_AKAHDQ-hjtBu6G7r X-Proofpoint-GUID: NK5cFRQp9Md-I2E_AKAHDQ-hjtBu6G7r X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27 Feb 2024, Sam James said: > Nicholas Vinson writes: > >> The functions ctf_label_set(), ctf_label_get(), ctf_arc_open(), ctf_fdopen(), >> ctf_open(), ctf_bfdopen(), and ctf_bfdopen_ctfsect() are not defined. Their >> inclusion in libctf/libctf.ver causes clang/llvm LTO optimizatiosn to fail with >> error messages similar to This is definitely not right. They *are* defined, but only for some libraries built from this version script. You can't just take them out. >> Fixes Gentoo bug 914640 (https://bugs.gentoo.org/914640) >> >> Signed-off-by: Nicholas Vinson >> --- >> libctf/libctf.ver | 8 -------- >> 1 file changed, 8 deletions(-) > > [CCing a possible reviewer.] > >> >> diff --git a/libctf/libctf.ver b/libctf/libctf.ver >> index 0ff825d033b..08e1b27341f 100644 >> --- a/libctf/libctf.ver >> +++ b/libctf/libctf.ver >> @@ -80,9 +80,6 @@ LIBCTF_1.0 { >> ctf_enum_name; >> ctf_enum_value; >> >> - ctf_label_set; >> - ctf_label_get; >> - >> ctf_label_topmost; >> ctf_label_info; > > Can you explain each of these? Were they ever in binutils/libctf > (possible typos) or did they get removed? The ctf_label things are historical artifacts from the Solaris days used by their old stabs-based deduplicator. Some of the code remains, and I have hopes of repurposing much of it and the unused CTF file format section for a better way of encoding child dicts with conflicting types in them in the future, but ctf_label_{set,get} appear to have been nonexistent for as long as I've had anything to do with libctf. They should be removed from ctf-api.h too. >> >> @@ -139,7 +136,6 @@ LIBCTF_1.0 { >> >> ctf_arc_write; >> ctf_arc_write_fd; >> - ctf_arc_open; >> ctf_arc_bufopen; >> ctf_arc_close; >> ctf_arc_open_by_name; >> @@ -165,10 +161,6 @@ LIBCTF_1.0 { >> ctf_link_shuffle_syms; >> ctf_link_write; >> >> - ctf_fdopen; /* libctf only. */ >> - ctf_open; /* libctf only. */ >> - ctf_bfdopen; /* libctf only. */ >> - ctf_bfdopen_ctfsect; /* libctf only. */ >> local: >> *; >> }; These are definitely used, and exist -- as the comments note, some of them exist only in libctf.so, not in libctf-nobfd.so. lld is not the first linker to complain about missing symbols: recent Solaris linkers do as well, so we arranged to mark such symbols as /* libctf only. */ so that they can be removed from the version script used to link ctf-nobfd.so (see libctf/configure.ac for the code that does that). But here too we have a bug: ctf_arc_open is in ctf-open-bfd.c, thus is not found in libctf-nobfd.so: it should be at the end of the version script like all other such symbols and marked as /* libctf only. */ as well. -- NULL && (void)