From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 614D23858CDB for ; Mon, 8 Jan 2024 18:45:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 614D23858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 614D23858CDB Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704739537; cv=pass; b=GS7PP54/CF9eyDkpxSt6BUJL0qrXLtFj0coUeMBCMaBJMqcPw/VFOCLdwXWWfthgsjADdm44SUScS/fLKW3hKE9ZKKbfWTpSQw/cRrgprHARjJZXYY4VE0hw0soWTsoyPuKc/syBPCrB+T3cz39D2iOFQJzPYz1hmjFKx+kaRUc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704739537; c=relaxed/simple; bh=SbM0ReaL5m347El2Z7iOpr0D77flYnZ98upHJ+MkzjQ=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=tGX7PO7vjALiyeAS667PnBX71Iwi21KgJQpoGLiQVcYEZIwJHrLqJ4n/AVasGMI3xleLNxP5vNbJfzCKS32qCv/xM7x/Y7VLv2xlltLlcmrT8nCFsin2joQUsoh36L8QZ5qn2xkL6K6vlIEdNZ3UHQ7hZn9FQKa4NDBkGmGoFFI= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 408IiRm1001605; Mon, 8 Jan 2024 18:45:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=BKUHvjK1TQ2Ra2a/mUDe+17l+pbVyWqeVu5rFDHy3MM=; b=HuEQbVwskunq1N7HZIVM/i5mlaAQptsCNj2wVV8Wm4Nn2R25SctVThDipDFUp9L1U5pG QBOn0CJIhdx5TicCsT5hxDAgxQTrjwh7SjLIoPxVbXqZ52Ci8Ain1f/kgW5JMsjaCZWK z3yElylmE2f5nEZPg76ZoYvUb8R1LRYuw3blD2k7cd/+Rl2erA7C359hLwv6tndT9Oou zH/OR67M654d+vo9KpoEwVeeSp9KGBCwpeQtvCgmsGEvpZhqTe3mbSRKyD+feOt/CIr6 LlyX0+wMYAFRVTGZNov99E80QjDFDT0IzAfCYkd/R/Mf5XA8jDZvPE6iqCaGorK3NAHm 9A== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vgpkdr027-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jan 2024 18:45:33 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 408HZtpd035296; Mon, 8 Jan 2024 18:45:33 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vfuu3a54u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jan 2024 18:45:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AI+9bsD+ADuer1m3GcQU8fOMvGTRY5L7oq4Pd2GZc77FIEameEb4fI9sXWlcDVVracSz58VsN2oqkWLQ/v2+ncXhkt7vj8vAuUlae384c4Sui1pZeDfXCDfZ3/Z7/CuWnjXIQuyFqZNqSvcRAJFUVQ4Ni4POhYV4RU2JZDRR2qMtJI0s5RniRk7nkwrv0+kq6puVUgYlVSJm7Xzd0GaywwZXT6asj4U7IEXj0JmOi2OhkvVcEsFEFnayKhcxtXYlVB38GplJvNReAFsgfrU0fIAVKnxvfvh0G9D4I293OOxhokfyJ6shvP8jSHjsJcYMUpKcg5REOUpW1SSRQbvYqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BKUHvjK1TQ2Ra2a/mUDe+17l+pbVyWqeVu5rFDHy3MM=; b=QOp9zEGulnTW09psnQNrP5RMt2T5dYQ452SCyg79NBRMAuvNxKPoEhKQEO0neO0HTkXJPzTUdDzdvfH3ur6Dw6GVaS8WRi6BcQsx3nHNVTjPMl+wVuuW0ig3YfZHmh7JbvmkENZNvWy2BfvqWmvNUutM4fty5h7pvohLX34HOYOLKhkdmN4+06f7A/sSdae9Zj/hevb4zWn7OlSigohy0B7Btjekmjl+t4zDKMp72hv1Ldy/sIZAzfgOTKQI4ZchAVBVi2i/C+cjUguwbyGJQdpVFN0U424Teeq2N56VQAgTfyLLDG5NdUXsasFhtvT6LcBrNDbxqHtcrGEXBOgXZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BKUHvjK1TQ2Ra2a/mUDe+17l+pbVyWqeVu5rFDHy3MM=; b=GpKWi2/LSd4YwV5BucwMnm49AU2kHdd9SgL+rYtyLn+WL6aAN/mQZwBWeVDFZQR1G7RtbVh8G95JDJ6+vIYW1yanaGoTSvVka56n7vVvXzkBopdStm9FDjd0yd07K57YmWyAlbsEx25465Ley6TZWKfD62LD3yUL7cbY0hsSwnw= Received: from DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) by IA1PR10MB7214.namprd10.prod.outlook.com (2603:10b6:208:3f3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 18:45:30 +0000 Received: from DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::a45d:77b4:ce0c:9146]) by DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::a45d:77b4:ce0c:9146%7]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 18:45:30 +0000 From: "Jose E. Marchesi" To: Cupertino Miranda Cc: binutils@sourceware.org, nickc@redhat.com, elena.zannoni@oracle.com Subject: Re: [PATCH] bpf: Added linker support for R_BPF_64_NODYLD32. In-Reply-To: <877ckk6sg9.fsf@oracle.com> (Cupertino Miranda's message of "Mon, 08 Jan 2024 10:16:22 +0000") References: <20231220132305.459519-1-cupertino.miranda@oracle.com> <874jfug0yj.fsf@oracle.com> <877ckk6sg9.fsf@oracle.com> Date: Mon, 08 Jan 2024 19:45:25 +0100 Message-ID: <877ckj7jga.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0390.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18f::17) To DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3113:EE_|IA1PR10MB7214:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b5cf178-b745-4b5d-9ca3-08dc1079fcc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aEg5+Me1sOMSkTBRKP4hz/otrgoCnBq2vL8GPJT2KDiDixjuiBht7YFGDnibQaMSvyMaxKJINnjX+uuTV99aB9iZ48CpZgLLHv0QJtD5siHo84wghHjsm8W34czjvkRixhtcttlBc5VfPSxAKRihjcaUSb2W2/Vf3SFgxoYupd4Q3yXs0XUaYznVjfVhjSAcPKhb4tDQL4aXN7YFQ2cIPv3Cg/6hFWAxSnQc49kT9/AlUcCq5geUxeF+hbdRlbK5yWZPnZn99TO/V6IXzJMDh2TFLNOpxS8P5bE+49yYnOKStoksJRY6hAemfH/CGoRmda4o2ZUGgq1+Otw0aqxSU143XBes+MJWG75rvjaCf7j2ZAr7578g1fX0z3PmmNGcLXcVueFUS+XIiHCatcP5eD2NoPYpeY+s9x35XKE5vO9O95EEI78uR1AVz+SSNq07Hf9q2xTr+VqcUsTr/x91d1NoYduGyDh60V+8Cm44YjLtxvvSpkuHBVK0zGLFDRGvMaaP5OlMWGMPCIpWJSdRYCrVXf84uEQ6zzQju9NkdyrlF8Db4LuWPxfQVcCDDsjX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3113.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(376002)(39860400002)(366004)(136003)(396003)(230922051799003)(186009)(64100799003)(451199024)(1800799012)(6636002)(66476007)(478600001)(37006003)(316002)(4326008)(86362001)(6862004)(66556008)(6486002)(6666004)(66946007)(38100700002)(26005)(107886003)(2616005)(6512007)(6506007)(53546011)(83380400001)(8676002)(5660300002)(2906002)(36756003)(41300700001)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mb+okOJTtPEJOstpOkkkuU24l4crctDCd5QDESU+mBBvsknAAb0qaJHr09Bw?= =?us-ascii?Q?oPnxZbPUTUZl2HSC3cyTAU/n+shOhR00oMytGBBNl+rxpdkPZV3DbZYYwEHr?= =?us-ascii?Q?Wdn4dt+P6l/Q2+sh5DHQcU1Fhk8sfHBXS+SKNeNVc8VOQC+RmwIIWlV/rrU9?= =?us-ascii?Q?wN+A0fO1dZwILei1RAB96aOs20EZlQ4YV5V4ZoFvY1wNQckk456BBp2YIJxQ?= =?us-ascii?Q?us8ubV3yGFe5x3aaafYVVWlZNtu+l0ID1xwcF61oPJI/ic4EiFZ/KdeaayDF?= =?us-ascii?Q?v/YeGPraP3l9KJ3IwO+LXTGgDaBiws/JwR1DHv1mvRfPnWoVOKfBEgjslY20?= =?us-ascii?Q?KymjQ15cirtAiZrS8aDrbklN14hMiuGEeBej8pcGyIXNlgbCzqraFvORbCtn?= =?us-ascii?Q?GV0jXIqWiBNjlRrXz83pbp2hjfVXzqls7dPiVGypR192d0PqMjcBUZxnqrmE?= =?us-ascii?Q?RavqhvbYejUnUWOge9+z+F0lgKXHbhLcqbCtZImb88O5iKrffDzZLMP0SmB+?= =?us-ascii?Q?xLFb9bB8cppHi9i2dCCv9i1lslJe0PlIHbDYiKLT4pgv6oL6A6y/s7Rs+zrW?= =?us-ascii?Q?lPMqIzPa2ZvY6r6O+aQMgcuheGuCwbAaDfrLQDv5Ogwx1Ck50WrUeFFqLVfP?= =?us-ascii?Q?MIuL7Ie8LN/CbUq2WJlVRb89Bz0u13JSV1vt13goE9ENu813Ik0bw/ffY5BM?= =?us-ascii?Q?LJ+0o+zvMBA7Ah7BT13/pEOURqbRm67sIEXhV6qpUN3FPfsQc529TwQ/ouDg?= =?us-ascii?Q?E3CajbhZAPIevt6fQ++MJ4ZX3X4v5zXs5d6JxpwtChlmS4OJF6+HCGq8hrbp?= =?us-ascii?Q?fAz9nphw7KhRAfL9ifKB1BYEK5H8nHdy3uFKvp5NFtdl0sRY+0/gwQynZigN?= =?us-ascii?Q?2yLhpKXDekF56DTr6Q0EcCoYgUUE2/SIBf3Ug60ESMbzkbFLs0h0po+fDzp1?= =?us-ascii?Q?edL/IrhdioZjLBmoPv5deBLVDZyfkEPuqFEKgzXisSavyiYKHLulf5vWG43H?= =?us-ascii?Q?2ZYQdADsHtwBuQSFJibIJ0j9Ip5/bE0jLlYvsDq0H72M/JNsKEFF+ZzR2rdg?= =?us-ascii?Q?YQ4kqj8HzzLzo95alS5uo4REkuXemqbfK3ATevhttysjhcKiRc3aLHHhJjcB?= =?us-ascii?Q?EJoA/qs6tVQJiJftjwDv4cFV9rdXXSwbsLoe8CJ8C8R8fDpTiOMbT/3jTd70?= =?us-ascii?Q?UEH+HhBMWBQU6ZjJpLH4xflnocnFn+jnbvkk8XwQv+aWZZUw64UMHiITH3Ab?= =?us-ascii?Q?xp1u6XP/ngM5BOGz3o5NJLrQDHxT+ckBdVAGFbStGBMkawmLGLI4MYs0l+Qc?= =?us-ascii?Q?mQhOhG0JsECFZkGFjiUepZfjYK4FpIiJLnLSN9Kp1FcSG2V1Dwq75MMluOqg?= =?us-ascii?Q?LfgZVuDkhnkkuxINcTCoAMdEibnb9T1fWLnCwoOHR3AwRAVVJwzqxKaDt2JB?= =?us-ascii?Q?VuH1QoOtMaRNeqqkG1mYzUEbzWSx5udjJB0C6EcGZALOYCsddzyhvdwqSbDT?= =?us-ascii?Q?TMZrT39JxEIAG4IZTVt0tK0OVYkva+THXjONHtcROH5r6vF+8WxF6UVEsP4I?= =?us-ascii?Q?yUzQnW6MK9b4doSMjHhD9BWJkPFTpftpMmxDzhxHFEIx00xiSgCn14uzrGAF?= =?us-ascii?Q?ug=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: thuj1NAeHDA3PbvugtXhDxKxuefLBxZUSiT1JldyLOL9ONjEcZCqVitD0BqTmB0h2nn/qFqxpfX8dkha5oRQ9E3Wz3rPUpIr3Bwx+tFckl4h90PT+T8g10NXFfkMXpmVyUxIA2JCMQDf8H+06aHyC4QQ0zUp998FJOSpayy/w24JANodpLTZtC1eUkMjZnSg08fKGD9V4RfD30yibsClCgAzJU0nbLeBzfxCIUhCScDiST24N3QkaN3tSjnmrkA1VfAGAdxqmLkUGExrgrThCDcwU1Sb7kMcUVUA7OS3kfzK0Na3Ewusede+ZMy8QHKk4Po4zZbwOwnASIQgd3MAv6OmD1UDH7qX1G/ANwmUarv6tY91bY2IZ07K++IIJzPi197XrHbF0XBybFWCN3py2WbAKUYO3Cj27cIOWUOwG4jPzKoxxcknPFJ7QQVaiU9uxxONuqwRrPWjJA9EoB1en/MXxLqcZffYgiymlqDoLkLkdAo1TY1YByypU9bUi5MOEPFjQqZMf7DP9n+lIFz9zhcgpTS5yo7rZ2z4uWDYXgO//uG9eI3bBIfyWoyQbEhDmgM5E7ld2EIqty91LN3OQwRxhs4tFmgxUhZOy15/quM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b5cf178-b745-4b5d-9ca3-08dc1079fcc2 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3113.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 18:45:29.9597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NN1ljpFcUWtv7ylDmAAd864hnWUJNkSxt+JMPRUNCrxEClpyT8k2r8WduhyRzraJ6UnBoAop5MIbd2fJIllVAe2FnYuVUE0T5VcegABIf9M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7214 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-08_08,2024-01-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401080155 X-Proofpoint-ORIG-GUID: Oqh9twTFdK5UUiyjbJctis_3LQBhH-uh X-Proofpoint-GUID: Oqh9twTFdK5UUiyjbJctis_3LQBhH-uh X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Cuper. OK, thanks. > Hi Jose, > > Thanks for your review. > I realized I missed to update the macro for the relocation where the > properties like size, overflow check, (etc.) are defined. > I have added the comment near the relocation macro definition. > > Sending the patch for review once again. > > Regards, > Cupertino > > From bb8afde9a8f17d42393067c3a667bec1f08b252a Mon Sep 17 00:00:00 2001 > From: Cupertino Miranda > Date: Wed, 20 Dec 2023 12:24:03 +0000 > Subject: [PATCH] bpf: Added linker support for R_BPF_64_NODYLD32. > > This patch adds linker support to patch R_BPF_64_NODYLD32 relocations. > The implementation was based on comments and code in LLVM, as the GNU > toolchain does not uses this relocation type. > --- > bfd/bpf-reloc.def | 17 ++++++++++------- > bfd/elf64-bpf.c | 1 + > 2 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/bfd/bpf-reloc.def b/bfd/bpf-reloc.def > index 7e7497892fa..42ba1a169ea 100644 > --- a/bfd/bpf-reloc.def > +++ b/bfd/bpf-reloc.def > @@ -90,17 +90,20 @@ > > /* R_BPF_64_NODYLD32 is not used by GNU tools - but it is generated by LLVM. > We provide an entry here so that tools like strip can safely handle BPF > - binaries generated by other tools. */ > + binaries generated by other tools. > + R_BPF_64_NODYLD32 should be fixed at linker like a R_BPF_64_ABS32. > + The difference to ABS32 is that LLVM execution engine does not resolve > + R_BPF_64_NODYLD32 relocations. */ > BPF_HOWTO (R_BPF_64_NODYLD32, /* type */ > 0, /* rightshift */ > - 0, /* size */ > - 0, /* bitsize */ > + 4, /* size */ > + 32, /* bitsize */ > false, /* pc_relative */ > 0, /* bitpos */ > - complain_overflow_dont, /* complain_on_overflow */ > + complain_overflow_bitfield, /* complain_on_overflow */ > bpf_elf_generic_reloc, /* special_function */ > "R_BPF_64_NODYLD32", /* name */ > false, /* partial_inplace */ > - 0, /* src_mask */ > - 0, /* dst_mask */ > - false) /* pcrel_offset */ > + 0xffffffff, /* src_mask */ > + 0xffffffff, /* dst_mask */ > + true) /* pcrel_offset */ > diff --git a/bfd/elf64-bpf.c b/bfd/elf64-bpf.c > index c932a4024ba..0bffe2c5717 100644 > --- a/bfd/elf64-bpf.c > +++ b/bfd/elf64-bpf.c > @@ -276,6 +276,7 @@ bpf_elf_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED, > } > case R_BPF_64_ABS64: > case R_BPF_64_ABS32: > + case R_BPF_64_NODYLD32: > { > addend = bfd_get (howto->bitsize, input_bfd, where); > relocation += addend;