From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 48667385842D for ; Mon, 8 Jan 2024 10:43:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48667385842D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 48667385842D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704710593; cv=pass; b=L/kyAJCkfnogk3q6v5+jwHxiNPKHbkUeMarGMp6jv5a6/3Dac3L+nSiVhuXAPveSjhlXWZ6REJnDghJWO6C0dne0FIYRlO9s+esePl90Myu1MBNWYvx0PzSlNt7gtt1s8qW/sxOGlpzEwyi9c6ydzB+jvRs05VcfNXf9GRvlyaY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1704710593; c=relaxed/simple; bh=ZnbPzckJ7vb0Vi+WhUYuyF5Ol5DECEEmsJWXJfzO6YQ=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=dByCeDT+I3B2884DLCKhIqJLSmQGAsLd8bt88rYK4MZqH/MWIYSqjSU8Ht5AwOYjRuQvw9z7VHWicoUnON1duujSjj5G5osUCcUmVYr5NWQBA76x5UcLUrCOOvELfgMFZ+bLOQ9/tlu8IFFcqce/iNoSrRA+TxbSVDYQRIECBl0= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 408ATQ9Q003532; Mon, 8 Jan 2024 10:43:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=Wj6sL7yIKhpuSB+/yWzhJ3llN1r2Vla5sfGmdolSGJY=; b=RJYOt7qhraDS/AvNj0r6LDX7ecfs3OGzl7gXdYKZDmScoc86wm2m3aHbjytKAkll8STo tKOkfDx/kbVYWmrQ8E1TlEbFcUWe8hlIqsK5/QKTOnongQguWDzudtOKKHk2P8xk/ERV FH/J3lhjt53cqWmEIZ/anZuSD1anzZOG7sw1VGuEdDFAmwRVo1DsFGf1FcEgGz8E8vgf iLa0u7UornfucfAg5d0ghJk4V7Bu6KA+V+XosTCpjDRSKEs2A34hWy+IU/QJ+MM//PYE PAHvwCR+xiP2o/aaI49WWd9vCYAHS3AG+OIl93iqsy2y0N8Gm/f/m/6ofl+4NNtCFgkY mQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vgfbcg1hd-18 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jan 2024 10:43:07 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 4088g7u9013691; Mon, 8 Jan 2024 10:16:29 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2041.outbound.protection.outlook.com [104.47.51.41]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3vfur9dx9k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 08 Jan 2024 10:16:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PSs9SBb4BQkMycpVWpHv1yQFhz5giC/jgRZTU1zy423WKkogBOlTuTQEuFnTGlL+hScInM7vqIyU1eQfyvFhl0EuhVk7CkdMbbIdQc8rLk2Mp+g8Gjyn9vI1zOV1yXASCUCYhm56mtUO/9SPdtaxfJja/apRjn1uo5W3/g50Auyuw5Js3JUU5MYlkl97zHH7scqO00EPJ6Y5bI57dZ7gUEimcfGb+ZZhfTPrXfHnxJE82Es77wmtbbOp0BIfYwhpGf1sFiDpfFjwb+9qjUwBcMQROUzHymF3S08xfFJNSr+JrAJ211/5NWv8uqKKmcezaSPYWFXSrG5hThRZ2D8lPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wj6sL7yIKhpuSB+/yWzhJ3llN1r2Vla5sfGmdolSGJY=; b=i/jF5Tb055XBTFyh/CxA/dxJQIa7XhmgeY4Ps1fw9AzV5l2dzkOWKiA6sQOenQ2HnhB6J6fqWEJpoHAPAxXAfRple/n7JOqiLQqUJ3sH/6iFP/NJJOkuqlTvYvTD61FyJKKAj02lyu3ejDdW6FvDPxe9Z0JyZ5anCYdhMGdwRxdAB2SsJ5H/GBXbGlPOWpcco75GxPhmELGiqnCXmw0hJDbxaiQDBE/h7JntXDj9xe9+pfGRt36ptxSyle8nKkg3tnsKbTIGZVAjIp8YeKDKr2JYLdW0xUn1YMpEazXTdBAYDnXxuv0/s3iEtukJDsddeX/a0LfGingpxb7I7JzmfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wj6sL7yIKhpuSB+/yWzhJ3llN1r2Vla5sfGmdolSGJY=; b=gmeTA1qCyza+OUIaZDeyFSp6bJ+kOfOjJ7yF9gMVoKUdYr4mqX2datgTmP3ASoTO/ePfYB6dNcGpGpym2HU1cZ0mvg9+K6T4jimrZBfW4yTEas7YVtbsr/kQXW540lPOexrao3X/TtTyQMfhkNS57CkpzfQMgU9CyCa7G83YHHg= Received: from MN2PR10MB4382.namprd10.prod.outlook.com (2603:10b6:208:1d7::13) by DS7PR10MB5973.namprd10.prod.outlook.com (2603:10b6:8:9f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 10:16:26 +0000 Received: from MN2PR10MB4382.namprd10.prod.outlook.com ([fe80::5252:c588:583e:7da6]) by MN2PR10MB4382.namprd10.prod.outlook.com ([fe80::5252:c588:583e:7da6%5]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 10:16:26 +0000 References: <20231220132305.459519-1-cupertino.miranda@oracle.com> <874jfug0yj.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: "Jose E. Marchesi" Cc: binutils@sourceware.org, nickc@redhat.com, elena.zannoni@oracle.com Subject: Re: [PATCH] bpf: Added linker support for R_BPF_64_NODYLD32. In-reply-to: <874jfug0yj.fsf@oracle.com> Date: Mon, 08 Jan 2024 10:16:22 +0000 Message-ID: <877ckk6sg9.fsf@oracle.com> Content-Type: multipart/mixed; boundary="=-=-=" X-ClientProxiedBy: LO0P265CA0013.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:355::8) To MN2PR10MB4382.namprd10.prod.outlook.com (2603:10b6:208:1d7::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB4382:EE_|DS7PR10MB5973:EE_ X-MS-Office365-Filtering-Correlation-Id: 10d6d0c0-63ca-44fe-0af1-08dc1032df6b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PMlPlrvDBO8svFcn0Bwn2E0p4Fm8P/NaTdf0DB+a5y0UsUYVdMI/hw+NWCq8sLQn4ALyistl/vlIWjGh6F1NSSJniy9Mhi/Q3u9ExB5tZk8r3nYHS8G7aA66eddsj9TBRwcLXPmfbMrMbHWt8pojOhRN0s5RyVJDGhFajl2m3dihgLUGD4cfvr1intrWxGRruckUM9tjG0b1aq60MlVk9BaxfjXFyqOXuyZgoJqGoANz+laZ2ajsJ8K2utuWagY5KJSvQQI2K71USE30Xs6wLI/TSCarEqq50fERQwYY2Ob10LzVqNxAYHDj9wz3fecn0uRgJ9YFr60zOn5MIZ94EXnq0OSOL/k8UBUYepYFMI5hE+QIa1tdoexl9sPU9ud1xEjtlTivtDc8p7dYtVXwkthEy7YwFSf7G1COiZJSLNnoZo66pooYFYWSEub13IaB4+IbuIJ/9xG1rbqzBJXq3ercTGrwnXaS/Q/Ghf3Dnl/EcPF2p/3en9XaDSoCmIDCSuv3mW6nYj3afTwEhxJhfOn3WcHxpum6vUpjLr5qOWFutRUKbW0fjp9oFokkoj43 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB4382.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(39860400002)(366004)(376002)(136003)(346002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(66556008)(66476007)(8936002)(8676002)(44832011)(6862004)(4326008)(316002)(37006003)(36756003)(66946007)(6636002)(41300700001)(2906002)(5660300002)(86362001)(2616005)(107886003)(83380400001)(38100700002)(478600001)(966005)(6486002)(53546011)(6512007)(6666004)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HSgZKqZTRYNrjiUWxMSTiIV6BFcIx0NqlRQgAkvEHg080Uj6Vb7ynJJtH1FZ?= =?us-ascii?Q?rSD9L03qHjF7tnP3g5Hg2v0Bun1JO0rMDHI0qTkDGAA+VeMTQvamyyyTt0Tq?= =?us-ascii?Q?rBwyI8qwCXkuzB/y8xq+jWQxm/4GriWOHpJ9d9hqERLfzCa8189rK3uHRSkT?= =?us-ascii?Q?yecPG3bKZVg1rjRVAgjxzWFHcMW3r7N93bnALYxTPoAR6h6lr0WuYrIcQ7oc?= =?us-ascii?Q?hrRtZT+O/MrzbM/vuRdzEmjP6dKTfIJe7Rz2sjBllSfIDyTQhqIDUA8Hnzf3?= =?us-ascii?Q?PbLS7ah4G7QfTtlCwgZlpfOL25NX6gGhPmW4Q56uq3ZaXktVTsX/stCXS0zT?= =?us-ascii?Q?zZYkBJoqIZHURvno4mCnnqHfktFzP0HJdE3eWRJQz5a+04GhNZv2QQbbhfNx?= =?us-ascii?Q?6jo1D2mvLEiJtCw687vwURDQd0eXJf/7eNP8eT5BPH8asiOnGbHkHzhyvn12?= =?us-ascii?Q?cb996pm675WXaWHs//18ji7i/YmDpHi3tz2ysDJ4b0AL5tyAVto9qid101aZ?= =?us-ascii?Q?5tvfbBAkgUMlUZ+OxSR6QiO1toZAVB3ISznfKYET9Y3YKTB5TQ0PxxwD8CZl?= =?us-ascii?Q?zq0YTNS06dcTrkk+3nkyybP0ZCe98Jgw9/fdmfDxgKvYKQZpgiT8w0mczmlS?= =?us-ascii?Q?svQ3leW3dVSciIDE5nSoHSEgpnpI8mQGDXC4RjSEFhztY87bXSSIXQlz/9f6?= =?us-ascii?Q?m1JBCIT93ad2Fia0YFwa4WmTkxBXJluIgezF2yzpz1+/DnLV26ga9HXz5kCk?= =?us-ascii?Q?okFgGHNax0WtAJ/UwGI12GaLjloDCtQgzgPymisNoY+S3sPWFBbOt5vaoyjm?= =?us-ascii?Q?c2wvHkwp8cKzr3IgcuA4s5DoQRCvFCI5OvGt86Z0VfTdACTXeoBfs7r/cYFA?= =?us-ascii?Q?8JUtSAZcAqXTL1v+xmUGLFlvFvDvpcMCdCjsinBrqGFaWgpAThuIBxPpxygV?= =?us-ascii?Q?f3I8LAD/y9dX9lLX8PnePtgZKcFtICcNGpqJHrAGQc6ie8iLefIkC0PeE2Lb?= =?us-ascii?Q?WJwVglyoyAZqywLGWWWWap1/7vR5rzHXDus1C8AUB+5kj3/8YUxKn/zC4JEU?= =?us-ascii?Q?3aUa6WOyD93Q/qOJ1/vrCOmSBLpDfS2+iEbW39LBhi4s/+yVsaJTciStAVK3?= =?us-ascii?Q?/PhuL3m8N8OhI/K6Byih4qJf6jvPz+amG1oHomT48ymD/HzjfZKkRdedGtHK?= =?us-ascii?Q?gEvgyQwJAeD9z/2dJ6Sndw4s8y5RE6iHJnFhTHeXaigWoUe9L7nE9eLEhJEG?= =?us-ascii?Q?GbdNkWcclrELREvvh3XTUrMo0NAHjfL5sN+qfI1b99dRaDi1YRCu6vv8rVfm?= =?us-ascii?Q?8A1AT1G92Lkupaf1l7KdTm3NDGF9fZqs3DLiRlFVQlTqLvhygjpjjG9vK3ys?= =?us-ascii?Q?F07IeZw95TBemvnPsq3pWhqivMQCRKuyfdU5Dqf6z3xkgR/gk1wgYIhnXmAX?= =?us-ascii?Q?ic9HrNFzbg/cJWO+HJpdZRcUMCL/wQeGCaYLd6kZGzv3xCvZrOWlaASjO4aH?= =?us-ascii?Q?ociLbDSPc1RTD0BJil614mJguNubTBindn5fZWdV707g4RS5TQ8TfaKIISIQ?= =?us-ascii?Q?lyVvWZHzrnDZ0DxcLB8cQigyrBzC0ZdkN76gFo8w/puxA+hBvmXsm2QdAJSG?= =?us-ascii?Q?ozOx3b3/E1OPiMGlaL8ukvj8+z+qWiveQ69+uavdsuy3?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1PdcbOGj08TJaoK2TjRroui/CWNoUYzSDHNBgyiu2eKWj/ulneYcP0hLJYg6EkHwhnuaovhV9f2AFAz087Eu7bKzXkQ8cRYCNHi9s8mngI5tkxCGdM1p7FKpa4n7sXl5wSAGwRjLncVfRvCFtk0SPGVkmeUH0EM2AGXfmp4OHiIyzLbt6ViMzBTtQ3MVudgmghl+ODCAZLL4pt4B3gXcKZND1CX/QR78FGBnua9WX77yAtOd3hhGsHyCkWV0vGFbr6V7RLZwhnkqp9l4nnE8FFO0/mf1J/V8KV8TEiSvAnTR86qXMNEyqoYd4zg+9HliRWTqLebN5oayQJH8p5QiJmqHvs7jZXI7Lo6NKcs1/J2pChb8Be6rqw9eKaUv6F4krmaAWlbiMg+7K5EWyO9w3NMRuuS7sZK7TZeghldXy/z0RwO3ak3enIw0OcYb7Z4OptLZNowrdgyg6bpRC4TeRMPfWn4VdX1sasLa/D9CpAL5Zyjx4IoLPuB1qwHCZeS82szCjtRKQedTE8QuIHcjvm5XImiVFiQPYD5qw7NeGIt/xwYabl8nPvUGDILAFWZVBvEak/1WJiHY50/D7Krfi1gqdSmFjJlO/xqlQlPGEic= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10d6d0c0-63ca-44fe-0af1-08dc1032df6b X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4382.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2024 10:16:26.5230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jgJOwL9FRoXh4h+ELTR74dfSm/5EjzAGVH00YyQ1riHdx3mFKBc/BMYKMU48lckvl4i7TMImFw7SJF5pwtXYaXvq0PWSGDf9Rm2Ob36VOtg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5973 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-08_02,2024-01-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401080087 X-Proofpoint-GUID: ab-WhcMZGKhAfAHLker5HCKvuRs_EKRV X-Proofpoint-ORIG-GUID: ab-WhcMZGKhAfAHLker5HCKvuRs_EKRV X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain Hi Jose, Thanks for your review. I realized I missed to update the macro for the relocation where the properties like size, overflow check, (etc.) are defined. I have added the comment near the relocation macro definition. Sending the patch for review once again. Regards, Cupertino --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-bpf-Added-linker-support-for-R_BPF_64_NODYLD32.patch >From bb8afde9a8f17d42393067c3a667bec1f08b252a Mon Sep 17 00:00:00 2001 From: Cupertino Miranda Date: Wed, 20 Dec 2023 12:24:03 +0000 Subject: [PATCH] bpf: Added linker support for R_BPF_64_NODYLD32. This patch adds linker support to patch R_BPF_64_NODYLD32 relocations. The implementation was based on comments and code in LLVM, as the GNU toolchain does not uses this relocation type. --- bfd/bpf-reloc.def | 17 ++++++++++------- bfd/elf64-bpf.c | 1 + 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/bfd/bpf-reloc.def b/bfd/bpf-reloc.def index 7e7497892fa..42ba1a169ea 100644 --- a/bfd/bpf-reloc.def +++ b/bfd/bpf-reloc.def @@ -90,17 +90,20 @@ /* R_BPF_64_NODYLD32 is not used by GNU tools - but it is generated by LLVM. We provide an entry here so that tools like strip can safely handle BPF - binaries generated by other tools. */ + binaries generated by other tools. + R_BPF_64_NODYLD32 should be fixed at linker like a R_BPF_64_ABS32. + The difference to ABS32 is that LLVM execution engine does not resolve + R_BPF_64_NODYLD32 relocations. */ BPF_HOWTO (R_BPF_64_NODYLD32, /* type */ 0, /* rightshift */ - 0, /* size */ - 0, /* bitsize */ + 4, /* size */ + 32, /* bitsize */ false, /* pc_relative */ 0, /* bitpos */ - complain_overflow_dont, /* complain_on_overflow */ + complain_overflow_bitfield, /* complain_on_overflow */ bpf_elf_generic_reloc, /* special_function */ "R_BPF_64_NODYLD32", /* name */ false, /* partial_inplace */ - 0, /* src_mask */ - 0, /* dst_mask */ - false) /* pcrel_offset */ + 0xffffffff, /* src_mask */ + 0xffffffff, /* dst_mask */ + true) /* pcrel_offset */ diff --git a/bfd/elf64-bpf.c b/bfd/elf64-bpf.c index c932a4024ba..0bffe2c5717 100644 --- a/bfd/elf64-bpf.c +++ b/bfd/elf64-bpf.c @@ -276,6 +276,7 @@ bpf_elf_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED, } case R_BPF_64_ABS64: case R_BPF_64_ABS32: + case R_BPF_64_NODYLD32: { addend = bfd_get (howto->bitsize, input_bfd, where); relocation += addend; -- 2.39.2 --=-=-= Content-Type: text/plain Jose E. Marchesi writes: > Hi Cuper. > >> Hi everyone, >> >> This patch is in context of Nick Cliftons request in thread: >> https://sourceware.org/pipermail/binutils/2023-October/130194.html >> due to bug reported in: >> https://bugzilla.redhat.com/show_bug.cgi?id=2245296 >> >> For the time being the linker is not used in BPF infrastructure. >> Considering that and without a proper way to validate the code, the >> following patch is what I think is missing in order to add linker >> support for the particular relocation. >> >> Looking forward to your review. >> >> Best regards, >> Cupertino >> >> This patch adds linker support to patch R_BPF_64_NODYLD32 relocations. >> The implementation was based on comments and code in LLVM, as the GNU >> toolchain does not uses this relocation type. >> --- >> bfd/elf64-bpf.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/bfd/elf64-bpf.c b/bfd/elf64-bpf.c >> index aefad7da5ac..5820dd3d7d4 100644 >> --- a/bfd/elf64-bpf.c >> +++ b/bfd/elf64-bpf.c >> @@ -276,6 +276,7 @@ bpf_elf_relocate_section (bfd *output_bfd ATTRIBUTE_UNUSED, >> } >> case R_BPF_64_ABS64: >> case R_BPF_64_ABS32: >> + case R_BPF_64_NODYLD32: > > I would add here a comment explaining that R_BPF_64_NODYLD32 shall be > handled/resolved like R_BPF_64_ABS32 and that it differs from ABS32 only > in that the LLVM execution engine is not supposed to resolve it. > > Given that, the patch is OK. > Thanks! > >> { >> addend = bfd_get (howto->bitsize, input_bfd, where); >> relocation += addend; --=-=-=--