From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 825C93858C78 for ; Tue, 1 Mar 2022 10:10:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 825C93858C78 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-480-OoxMfi00MdGgyaxhNwTy0A-1; Tue, 01 Mar 2022 05:09:58 -0500 X-MC-Unique: OoxMfi00MdGgyaxhNwTy0A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B51BE801AB2 for ; Tue, 1 Mar 2022 10:09:57 +0000 (UTC) Received: from comet.redhat.com (unknown [10.39.193.226]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 316DF7B6FB for ; Tue, 1 Mar 2022 10:09:57 +0000 (UTC) From: Nick Clifton To: binutils@sourceware.org Subject: Commit: PR 21964: Fix testcase compile time warnings Date: Tue, 01 Mar 2022 10:09:54 +0000 Message-ID: <877d9egf0t.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2022 10:10:01 -0000 --=-=-= Content-Type: text/plain Hi Guys, I am checking in the attached patch to fix a compile time warning generated by GCC version 12 when building the source files for the pr21964 linker test cases: ld/testsuite/ld-elf/pr21964-1a.c: In function 'foo1': ld/testsuite/ld-elf/pr21964-1a.c:7:25: warning: comparison between two arrays [-Warray-compare] 7 | if (__start___verbose == __stop___verbose ld/testsuite/ld-elf/pr21964-1a.c:7:25: note: use '&__start___verbose[0] == &__stop___verbose[0]' to compare the addresses There are similar warnings for the other source files for this PR and this patch fixes them all. The presence of the warning messages means that the tests are considered to be UNSUPPORTED when in fact they do work. Cheers Nick ld/ChangeLog 2022-03-01 Nick Clifton PR 21964 * testsuite/ld-elf/pr21964-1a.c: Fix array comparisons. * testsuite/ld-elf/pr21964-1b.c: Likewise. * testsuite/ld-elf/pr21964-1c.c: Likewise. * testsuite/ld-elf/pr21964-2a.c: Likewise. * testsuite/ld-elf/pr21964-2b.c: Likewise. * testsuite/ld-elf/pr21964-3a.c: Likewise. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=pr21964-testcases.patch diff --git a/ld/testsuite/ld-elf/pr21964-1a.c b/ld/testsuite/ld-elf/pr21964-1a.c index 680bda4dbfe..a060162ddad 100644 --- a/ld/testsuite/ld-elf/pr21964-1a.c +++ b/ld/testsuite/ld-elf/pr21964-1a.c @@ -4,7 +4,7 @@ int foo1 (void) { static int my_var __attribute__((used, section("__verbose"))) = 5; - if (__start___verbose == __stop___verbose + if (& __start___verbose[0] == & __stop___verbose[0] || __start___verbose[0] != 5) return -1; else diff --git a/ld/testsuite/ld-elf/pr21964-1b.c b/ld/testsuite/ld-elf/pr21964-1b.c index 1507b228088..688bbeb6870 100644 --- a/ld/testsuite/ld-elf/pr21964-1b.c +++ b/ld/testsuite/ld-elf/pr21964-1b.c @@ -4,7 +4,7 @@ int foo2 (void) { static int my_var __attribute__((used, section("__verbose"))) = 10; - if (__start___verbose == __stop___verbose + if (& __start___verbose[0] == & __stop___verbose[0] || __start___verbose[0] != 10) return -1; else diff --git a/ld/testsuite/ld-elf/pr21964-1c.c b/ld/testsuite/ld-elf/pr21964-1c.c index 996a9e182f4..58322bcc227 100644 --- a/ld/testsuite/ld-elf/pr21964-1c.c +++ b/ld/testsuite/ld-elf/pr21964-1c.c @@ -9,7 +9,7 @@ static int my_var __attribute__((used, section("__verbose"))) = 6; int bar (void) { - if (__start___verbose == __stop___verbose) + if (& __start___verbose[0] == & __stop___verbose[0]) return -1; if (__start___verbose[0] != 6) diff --git a/ld/testsuite/ld-elf/pr21964-2a.c b/ld/testsuite/ld-elf/pr21964-2a.c index 6331ff063b9..8b1afca2acc 100644 --- a/ld/testsuite/ld-elf/pr21964-2a.c +++ b/ld/testsuite/ld-elf/pr21964-2a.c @@ -4,7 +4,7 @@ int foo1 (void) { static int my_var __attribute__((used, section("__verbose"))) = 5; - if (__start___verbose == __stop___verbose + if (& __start___verbose[0] == & __stop___verbose[0] && __start___verbose[0] != 5) return -1; else diff --git a/ld/testsuite/ld-elf/pr21964-2b.c b/ld/testsuite/ld-elf/pr21964-2b.c index 1507b228088..688bbeb6870 100644 --- a/ld/testsuite/ld-elf/pr21964-2b.c +++ b/ld/testsuite/ld-elf/pr21964-2b.c @@ -4,7 +4,7 @@ int foo2 (void) { static int my_var __attribute__((used, section("__verbose"))) = 10; - if (__start___verbose == __stop___verbose + if (& __start___verbose[0] == & __stop___verbose[0] || __start___verbose[0] != 10) return -1; else diff --git a/ld/testsuite/ld-elf/pr21964-3a.c b/ld/testsuite/ld-elf/pr21964-3a.c index 835040ee342..89f7b883573 100644 --- a/ld/testsuite/ld-elf/pr21964-3a.c +++ b/ld/testsuite/ld-elf/pr21964-3a.c @@ -3,7 +3,7 @@ extern int __stop___verbose[]; int foo3 (void) { - if (__start___verbose == __stop___verbose + if (& __start___verbose[0] == & __stop___verbose[0] || __start___verbose[0] != 6) return -1; else --=-=-=--