From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91115 invoked by alias); 29 May 2019 14:19:36 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 91104 invoked by uid 89); 29 May 2019 14:19:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy=H*i:sk:16cbfa6, H*f:sk:16cbfa6 X-HELO: userp2120.oracle.com Received: from userp2120.oracle.com (HELO userp2120.oracle.com) (156.151.31.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 May 2019 14:19:35 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4TEJExr018541; Wed, 29 May 2019 14:19:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=t9sNeQvCJ5xqFo/KNarD0ZtSBX6WwJj39+55kEI9+X0=; b=RoAFSj4mTkR3stJDcSNLpGYdOUTSdj0VF9jbtGK/NXNxtxJEWZ7sHs8Kqp7E+RwbKE7r fKijcZkBxEteTA9OY/afWD84r9Bj+rXBTCn1F1lcMf7i9hF72qRON8V74IMkDFH1n6uJ /Yw8Y8SU7j9jIvfR7FoZkch/IkmpojlqcGBp3+2m+NIq/ZOjORHd9lemXEG9gULyfZll hRQ9Q2DsGeOWHVhQiuNW8OnssZ/9+xvepN31y31GPbLrkWmPChZRSPORCLbuMHJ45w7P F+iBiaSccizYXWtJZEh0GL71os186AjHz4FDuFhdKAIlRsxXGrisN0M1UsoOf7l0xg5K CQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2spxbqa00y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 May 2019 14:19:31 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4TEI2Ma114501; Wed, 29 May 2019 14:19:31 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2sr31v9r0r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 May 2019 14:19:30 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x4TEJTCf011942; Wed, 29 May 2019 14:19:29 GMT Received: from loom (/81.187.191.129) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 29 May 2019 07:19:29 -0700 From: Nick Alcock To: Szabolcs Nagy Cc: "binutils\@sourceware.org" , nd Subject: Re: [PATCH v2 08/19] libctf: creation functions References: <20190517221002.408822-1-nick.alcock@oracle.com> <20190517221002.408822-9-nick.alcock@oracle.com> <16cbfa6c-8d2f-afa7-d795-968ae2f9035a@arm.com> Date: Wed, 29 May 2019 14:19:00 -0000 In-Reply-To: <16cbfa6c-8d2f-afa7-d795-968ae2f9035a@arm.com> (Szabolcs Nagy's message of "Wed, 29 May 2019 14:09:00 +0000") Message-ID: <877ea95onp.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00423.txt.bz2 On 29 May 2019, Szabolcs Nagy spake thusly: > On 17/05/2019 23:09, Nick Alcock wrote: >> --- a/include/ctf-api.h >> +++ b/include/ctf-api.h >> @@ -27,6 +27,7 @@ >> #include >> #include >> #include >> +#include > > is zlib guaranteed to be available everywhere where > ctf-api.h may be used? I hoped to be using the internal implementation in that case. > in particular i see > > In file included from /S/libctf/ctf-impl.h:25:0, > from /S/libctf/ctf-archive.c:20: > /S/libctf/../include/ctf-api.h:30:18: fatal error: zlib.h: No such file or directory > #include > ^ > compilation terminated. > make[2]: *** [ctf-archive.o] Error 1 > > when the host has no zlib.h > (in that case the binutils internal zlib.h should be used, > ZLIBINC etc should be set up in the Makefile of libctf) Hm. I thought I'd done everything necessary for that (deps in Makefile.tpl etc). Clearly I've missed something. I'll do what other zlib users do... -- NULL && (void)