From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id D76673858296 for ; Tue, 12 Sep 2023 14:23:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D76673858296 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38C9nZD9000918; Tue, 12 Sep 2023 14:23:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2023-03-30; bh=V752Sm84xR2YpjutkanB66TiNTtX0LVogy5h2JgkbDk=; b=i1au/EQxMQHWTXSwsxBAqYZ6fJs84o9X10I809c34R6c+ayYKpdmL/fMk02Uz54LlK2H 7H0jmfuZx/DEp0iOZ6B1Tmv+pNWua2zC6zxcA7nG6SUJiSccVlQoKe7rBRWBeZgj4fMU HCj5ZpbXOBha0fxvDxJ4jK69bdYH3NvQRPEb0xMYI3dthKLsZ0wtdIq2QTYuw3B0bnIG Ik6F7H1jcoAjoX5wcMxPx1VMIvOb8t5gFEa7gZ+9Q9T9ajVneCn+yPdN98/oP4C41XBN kZ38wGjA8Feec+aIaSVms/bQGYbQMhZSwM0NulJFCeAJfJoDa2JAzvADR2KGr+QKkM56 rA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t1k4cc2mh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Sep 2023 14:23:39 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38CE2rDE023156; Tue, 12 Sep 2023 14:23:38 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2107.outbound.protection.outlook.com [104.47.58.107]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3t0f562mn4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Sep 2023 14:23:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jCAvu9Tf7eY3+YYvHM8W3+PeJ0+5ZLURSQlIY0GgjguTwgCy1CK9/tz7s3U5PtKXTZkyRpcfQ8vtpqGRbPL7ZiHb9SgbSGVlTD8e6slxGxk6sd+Gs1T1Uo9WCADP9xQ+lsca1nOwtHeXZtyJROYbkYViGuZe6Su/qKG1notyMFG3r3kf0GEwmy0w6sL7XoKkHfUTzqk92FZvGV+kKRqGKDzHcGU/Qd6h6gUat4YcFKFrZAxlhOejeYHiVQGtdybiW2d37qXLBfGDPyKGE/AExTogDeHS/+pekaKZB4C9Io4Kqs/VZDMceyKu1yVNMTn76u/2d2cIqfkwkA3hPMMFtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V752Sm84xR2YpjutkanB66TiNTtX0LVogy5h2JgkbDk=; b=OJUevE1DvowdQu9YU6J3JPDyCRAT4cHT2JBt7BxKyO5HHXdN3ruyh385+nA69b81AFBuw6JhYyzAZR/sE0zoXALdxP84gaJGN49YbloTZkXTDQzKNO8ukn3K52l4QoLYxh/mPAe/s5OvqOTOJRu/6M/7H15/DU8WCvSv+K89YN9Mp22GZay355o4kYeAKUJqqzZfpvjWTs14FacUB8pDxqEf67a5tBPeCYmDFt11rZN5p/mTD3nUCyXumOChdOk7ugUbAZLmW7rz59gc5MqPT38oP0vfnNm+fxrruUhI1ZeLnd0LV/A7Iau7HrFl3FP2AXCuHx8o4oZgFgmokln1Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V752Sm84xR2YpjutkanB66TiNTtX0LVogy5h2JgkbDk=; b=zt5fBNhw+gu9zBXfTN6rvTKlfmaya1DfEkxOLLrfOBVUc5Tdpj4N6c7qkgOLC+EyQPAclZmjXhWbIi7x5sCCj+bTw3TjI6gwVgSr0Q2zDtJfrS3LQNZXx6JPlFpjnjzh0lszWNSe/Ki4b6hb/Taf23ikoYMPrhf1MtPCA/gQgL8= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by CH0PR10MB5034.namprd10.prod.outlook.com (2603:10b6:610:c9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.38; Tue, 12 Sep 2023 14:23:36 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::63e3:4634:f484:efc6]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::63e3:4634:f484:efc6%3]) with mapi id 15.20.6768.029; Tue, 12 Sep 2023 14:23:36 +0000 From: Nick Alcock To: Torbjorn SVENSSON Cc: Alan Modra , Yvan ROUX , Subject: Re: [PATCH v2] libctf: ctf_member_next needs to return (ssize_t)-1 on error References: <20230825165333.34510-1-torbjorn.svensson@foss.st.com> <54adb46a-aaf6-2dbf-9df1-f7fd857dac7d@foss.st.com> <87wmx2dw0j.fsf@esperi.org.uk> <7f7ea2fb-c690-b48e-bfa8-99ca89690ad7@foss.st.com> Emacs: Our Lady of Perpetual Garbage Collection Date: Tue, 12 Sep 2023 15:23:28 +0100 In-Reply-To: <7f7ea2fb-c690-b48e-bfa8-99ca89690ad7@foss.st.com> (Torbjorn SVENSSON's message of "Fri, 8 Sep 2023 14:58:04 +0200") Message-ID: <878r9ba2sf.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: AS4P250CA0015.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5df::14) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|CH0PR10MB5034:EE_ X-MS-Office365-Filtering-Correlation-Id: 1db121bd-9f86-413c-2ded-08dbb39bd9c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eT2j9wYPRMcAUZ0KabTDM2zng17gvgrDp82D+eJpKljyM2muejZc5S3kBY1rg/lvkvVCPFXyhyR4MN4X5v5x1oVFZ2gha1nzX1E6e5o26W+5Qrc59AVbdtFa34/bJVhaXgEAkyqbZoEaBxUZv05MJ6364TSbAD8PtoVgc9i/7EZqrZD9xheEasO9zyt6vdlJmzS3IvcuvsCKB8+CQb6UVJtE3DXGELw/hISQ22jzLRjOFsLTX+wJE2R2IwaW+KGCA5i3+k5+OVjTKZ1W3ByXyTUhcWjzQBFT1JO262qJCz/zW0E1bTY9SOEZY5V6ubE6VDEFhj7AcoLCIx5P5SziU4v94lrioyIyqMbcWIIWjEyafNvc9H6j8fAseyi5n200ln36lQWlscRpu70XwNrvT9G1JUogDrooN8Cyaz92xw+ZRCE2RVRcEqZEwQgjA+0c/7P1phJBRzgRbFI1gtexpY6vGbgEwdjUiaeQrlhnAcGum/nIBqw4Qwe+bDKRdKWWKAPRVSpk4FyYZpBfIvU2V4Mbc4XfSKdMJsLsyNkFeFc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(396003)(39860400002)(366004)(376002)(136003)(451199024)(1800799009)(186009)(66476007)(54906003)(66556008)(6916009)(316002)(66946007)(478600001)(966005)(2906002)(38100700002)(86362001)(8676002)(4326008)(8936002)(41300700001)(44832011)(5660300002)(83380400001)(9686003)(6512007)(6666004)(6486002)(6506007)(53546011)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7QivBZSXcE7opBdUxTFxh9m+2nca0WDTWyUIPazZpZV/UwS2mOtER1ysuPYK?= =?us-ascii?Q?k3kMM8zOqpNA8Pv/03/2ep7dHiv+uZNlRVCmTytlCTBTI6ihJWjE8dV4IBDT?= =?us-ascii?Q?9PXaYm6KMiyN7lJzPl8OntxmBN7DDPkUljowOouzKt8SYZKyShUKVD7eXWik?= =?us-ascii?Q?Z/6e7t3Fnl8eL6CtjD+7vCryrrK3bh2I95E/sxoW65Ak7WvH/PH0sVeGy5pt?= =?us-ascii?Q?vlkL626SFBLctKjtuK2iZAnPFhMbg1g/pXaNzOUhFbugw7UOMJPogKKu6uQp?= =?us-ascii?Q?1KyT9I/fRfi/FEKTHVuH2O3enP/NjdgFiYIk/QN9UUWjltu8x6/2WWwKCLJ3?= =?us-ascii?Q?P75WifSvuQV227vvrY8Ij/xhLm9gjlMtxTshFZwwFFGEvlIUavXcW/xohkOq?= =?us-ascii?Q?zAyjxX6KbnR0KCXWvMCjY+qbqbr5ZKkzORtBOHbHuqpTR247uOLmVeIpmVSB?= =?us-ascii?Q?T0Mon1bB7zhnqgaCXbDaAPq0M6nQ0NvRAwRNA6mTBCdLT23CQtMGKs9tW1yF?= =?us-ascii?Q?mJ21LDqxjNNpbxNc2c6PNGAMbbDsHYSpY22utpIwQG1mJWSa/Jhxy6VDW212?= =?us-ascii?Q?ennS7Hhh9hmxQRcYRBjjbDGZ9S09dSw5a7ra72dmS/J2k+ZngAbipNzUias4?= =?us-ascii?Q?YvlN3bBrEKOvdTltTkbeH/Z6KHfr1bJGhaM6lPfFKur0SAAlc/vxoqt0UM3b?= =?us-ascii?Q?46532PdvaJ2+bdrxTGtTAAGuevbY5QqN+XMa0g8wH2Tj4SSY/YOFVKoEvrcl?= =?us-ascii?Q?YgXpB1potZhl3WoyF/w3bWfB1bK2//lbUrXL9WbdP6G1ux6i+LGtZuKOzb5U?= =?us-ascii?Q?RI6j0Pg04V86+5b5BMF/oPfFN6CO1Ho2h7GRIq7SvT7a+I70anYf8CUvr0bB?= =?us-ascii?Q?SO6u3Fp9WVPZX4eW9X1G0ck28L6f/zcHgdOuKpuGROm4nnhVHVEoVVkE364O?= =?us-ascii?Q?ytF8Orbn6/RJrH430kmbV+d5zXt4D+xpU8Y8oU+XGxkjW4+ATHNGzMUMUNwF?= =?us-ascii?Q?1lzTg0CEDHjf1gVOZ65tmH2/1Q9ZkCButF8cdOI7ATEcUXyyEK/bflGuhKv2?= =?us-ascii?Q?tGBNwkv4o0OF8ojwYiRPORzW12xUawMaGtsiGHFM5jHz4eJ21x3a2dAlQRMQ?= =?us-ascii?Q?sYDTHrs5AAGTOqRvHeD95zQPynFI574unIpaNPDGvaU3DLpcRrfUXiqolNuN?= =?us-ascii?Q?il5B6CAAPmJiRpBqLS8VuBZy7WhPfiMVMKZnaFiu3cGKg2Z5DiQOIBCR5HRJ?= =?us-ascii?Q?Wi8XwHm1+ZnBguUSlLDOJTWWnGS5sp119W/YkO0V32sSNrmy1hGT03if8zoW?= =?us-ascii?Q?XeAY6o8VwCykLBryNemQbPs2PtqliRh8GHY05Uw1npOsDjyRoScoGrO7ljXR?= =?us-ascii?Q?lsszK6M0YzJt1aJ70CiaBNEWOyveKwX25FlVo/HLC2p/pa/bdXKzJDwxj5Yu?= =?us-ascii?Q?NL1by1P1yRLAcz9i6s93GUiMDqK0oF1h6LynFiVtq7IfZPircmbDR3omTINS?= =?us-ascii?Q?kNImQsAnq4T2dT4U9Xwg9wR+oXjIq3GvkeeGgvpD7t+ohH7/wwLLtN2bq+Tb?= =?us-ascii?Q?cf1/gF+EjK6EvCpxJi4azb5/D1jcvo20w/Glrn7CYRlS3MtTcPQyaF1DXTEJ?= =?us-ascii?Q?mA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oS7o89XizboJs2jn2Uy6BkeAmkExrjejDM3Qi9KjvCovS96YhBVXggV3ZwtXqANor40b94Mvc+cuJdC7MPn27K3VIXhs17GGBvbeVEs0vow5zIgqNbiYvjIjn5wn/EjTW0h3goMFIKvmktXDylVl4Bhl3uQu43lC+gOY+6lPtcwBeD36rbUO18tIzZZimWgbt8bfoZqFkMJ4pCdorbz7QiKR/rSlz+QlM7u8yQSqAxtQXQsqx+03cdldQJUJ3er0vXOob+76pJ5dce/UoFDbWxTfq9EXsCBnZvZw22mfKF0WfhPBSRfQa/hZ15DAgHtPPm0EWGPu3hkw8agOnr+hk46wzNj4MKWyiT4IGm4CtmBpDHpqgoriqEOCdXMR9Inu4TrQMOFdd+onq2QZ6mdXnR+F/LzhNwKMHzHpAHBlfOfPlRyUFeHh3toJFA0uSH70GmAJVZTwHMt1UaXKf4qhFdqi7tTGcVJ0YWrQrCvbKnP5oSiTNsRznxK+bp777fJ50AATk45kkaXvFRXGmRNG6TTt5z9LO1Nuh/nk/EKeIRupCxILIm+KnoG/yF5ZOxtuV+YimLsWip9J5Ea1vHw91nu9HMgjIOmH2oxyf1SgNkJSn+/tWwM6fiLO1Bqt7QNCwr0Y65lNSjcfKKdRIqzZO+hwAJlbxjauUR9MeeOeDva1vKofECBXQ30whWqiSBhH+7DWhvKPCPjqSe6HLrZpAyDibeCoXqVvVxKNfpQ9jqMfYrEq7t67cbTIvI3oa0NfsbWTMsA+4O77Y1kbLxDTzFT94mYSUy68MIxMI6VtabbnAc1VQWMgQTXhW//SlSQ4 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1db121bd-9f86-413c-2ded-08dbb39bd9c2 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2023 14:23:36.0904 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qzj77OBcrmG43y7Nf0bGOdQvYBxZPRQgGhOSwlDbSmygVZ1T+2G8yhGIl1nMgJ3ihBYa5gssbiWpMK40OZV3ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5034 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-12_13,2023-09-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 mlxlogscore=846 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309120120 X-Proofpoint-GUID: 6Hh2ZbGcz9jD8Cd0zIESpWRX7X9BLQTE X-Proofpoint-ORIG-GUID: 6Hh2ZbGcz9jD8Cd0zIESpWRX7X9BLQTE X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8 Sep 2023, Torbjorn SVENSSON told this: > On 2023-09-07 14:10, Nick Alcock wrote: >> On 30 Aug 2023, Alan Modra via Binutils outgrape: >> >>> On Wed, Aug 30, 2023 at 10:34:05AM +0200, Torbjorn SVENSSON wrote: >>>> @Alan, any additional comments on this updated patch (except the missing >>>> semicolon that I mention below)? >>> >>> I'm leaving it to Nick Alcock to decide what to do here. >> I agree that we should indeed be returning -1 from all functions that >> return an int (it used to, but ctf_id_t has to be an unsigned long). But >> I think it might be less disruptive to do so via a new >> ctf_set_errno_int() which is just like ctf_set_errno but returns an int >> rather than an unsigned long. That eliminates a lot of {}ery and makes >> each individual hunk smaller. > > Ok, I can do that instead if that's considered the proper way. I think it might be a good bit neater and a good bit less work :) >> My concern is that it's really hard to validate all this -- can anyone >> think of a trick that would emit *consistent* warnings if we called >> return (ctf_set_errno()) from a function returning int? I mean this >> returning-int thing is a change I made ages ago, and despite making it >> *and* attempting to validate on 64-bit Windows I have clearly not got it >> right because it's drifted right out of correctness again. >> >> (Similarly, does anyone have a build/target triplet on which this goes >> wrong? because it's not going wrong on any of my mingw64 or cygwin tests >> as far as I can tell.) > > I discovered the issue using the GCC12 package for arm-none-eabi that Arm released > (https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads), but built using the x86_64-w64-mingw GCC compiler on Linux. I'm wondering what the configure options were for binutils itself -- anything? was it a cross at all? (I'll admit this description has confused me a bit: is this a cross from mingw64 to aarch64 or what?) > I've opened a ticket for the issue where I've attached 2 object files that you can use to reproduce the issue without needing to > rebuild GCC + multlibs to verify the problem. > https://sourceware.org/bugzilla/show_bug.cgi?id=30836 Thanks! I hope I won't need them, but they might well come in handy... >> I kinda wish we could rely on having C11 -- type-generic macros are made >> for cases like this :( > > Looks like it would be a nice fix indeed, but is there anything else > that could be done to improve the situation without needing to go to > C11? I've been trying to think of something other than adding whatever the build is you saw this on to my regular test matrix. -- NULL && (void)