From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id CDCA33858C60 for ; Fri, 7 Jul 2023 21:49:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDCA33858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3fbd33a57dcso26392345e9.0 for ; Fri, 07 Jul 2023 14:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688766546; x=1691358546; h=mime-version:message-id:date:subject:to:from:user-agent:from:to:cc :subject:date:message-id:reply-to; bh=9mm8cYZKQBUanaqIrnBxJO8cwbz8LJcZNzFRk9/YBPc=; b=mmC9hQ1n24tM3Z23CCkY8cEzzOOigvnY4JGZtpnd82QO3Fu3MvLfcV5pxrunZbkUK9 STmzDS9gUaCmoFTCVuHJ/HSi6gWIqu+Cq868rJNBsNgTRuaz3qMfSPsdYXulu7IEoFDK m1NzcVEf7HO+2MBgsf271r+y93BS53J3DNpdz9mlM62qiClvgddeVx6440cW+EvZ1+/U fJ8A/d3v0doJK/17nrcKLtvtQlAJ+bPIsJqV8hi5zLHFLyV471CFCeJ247HpcoFA9t7p gkG/JA/r86kn6a8JJl9cCt/Dk+Nnud3IZ5WXeUkg6crff0oKkNgZxWI9jGXYdxQMY150 2bzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688766546; x=1691358546; h=mime-version:message-id:date:subject:to:from:user-agent :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9mm8cYZKQBUanaqIrnBxJO8cwbz8LJcZNzFRk9/YBPc=; b=kprIZd+/jOaOLUNxMrzY9K6h5LtLZp03dGEa3M5kNvyXdoWpyCtgNtnPGo/Ep15W2a NMOBQRzr6R8TwjTfFwD5C+9u7q/RRCVeBDxdZVbboFvJ1fBUG3lb5hm6gTvMKMIrRLCB 155suMCt4iATgc+6xe6bnWe/2Tw59vBBd6lApaU1+dWS9ILNfa1LTF+JDV4jo4ZBqIZp iWAT3nbk48C+/sxRSQq/D8rKbPcjYr4lIpLTMr7JXWsacO/DmkedpT9lX6/h0/WXFAOI Hd+F2hi6uecnFnjtT/SLtY12YadxmMzkrIz/xo4PLokbw54UYnbveqa0l5J1jQjTcUGc aGGA== X-Gm-Message-State: ABy/qLZl4JodAFxE5lEuBQweRbodKJBynP70rXBsDHCOZPxKm3HK0SvU mQMb5YHcrHICtu8AtuHi22mCxYU72ZI= X-Google-Smtp-Source: APBJJlHvLV9ks+7s2Wz/uigpCZTzUqbAmHo1ai+Zw8oZ99JIcDk3ibP4Amfz0gA8hfUPydTvUCbgQA== X-Received: by 2002:a7b:c7d9:0:b0:3f5:146a:c79d with SMTP id z25-20020a7bc7d9000000b003f5146ac79dmr4745272wmk.15.1688766546403; Fri, 07 Jul 2023 14:49:06 -0700 (PDT) Received: from wractal (c-5dabe455.023-86-6d6c6d4.bbcust.telenor.se. [85.228.171.93]) by smtp.gmail.com with ESMTPSA id v7-20020a1cf707000000b003fbc89af035sm3464534wmh.17.2023.07.07.14.49.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 14:49:06 -0700 (PDT) User-agent: a.out From: Waqar Hameed To: binutils@sourceware.org Subject: [PATCH] objdump: Round ASCII art lines in jump visualization Date: Fri, 07 Jul 2023 23:47:48 +0200 Message-ID: <878rbrgzoz.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Lines with rounded corners are easier to follow (and easier on the eyes). Use `,` and `'` instead of `/` and `\`, respectively, when drawing lines for jumps. Before: : endbr64 test %rsi,%rsi /----------- je | sub $0x8,%rsp | xor %edx,%edx | call | test %rax,%rax | /-------- je | | mov (%rax),%edx | | cmp $0x14,%edx | | /----- je | | | /-- ja | | | | cmp $0xc,%edx | | +--|-- je | | | | cmp $0xe,%edx | +--|--|-- jne | | >--|-> mov 0x18(%rax),%rax | | | | add $0x8,%rsp | | | | ret | | | | nopl (%rax) | | | \-> cmp $0x15,%edx | | \----- je | \-------> xor %eax,%eax | add $0x8,%rsp | ret | nopl 0x0(%rax) \----------> xor %eax,%eax ret nopl 0x0(%rax,%rax,1) After: : endbr64 test %rsi,%rsi ,----------- je | sub $0x8,%rsp | xor %edx,%edx | call | test %rax,%rax | ,-------- je | | mov (%rax),%edx | | cmp $0x14,%edx | | ,----- je | | | ,-- ja | | | | cmp $0xc,%edx | | +--|-- je | | | | cmp $0xe,%edx | +--|--|-- jne | | >--|-> mov 0x18(%rax),%rax | | | | add $0x8,%rsp | | | | ret | | | | nopl (%rax) | | | '-> cmp $0x15,%edx | | '----- je | '-------> xor %eax,%eax | add $0x8,%rsp | ret | nopl 0x0(%rax) '----------> xor %eax,%eax ret nopl 0x0(%rax,%rax,1) Signed-off-by: Waqar Hameed --- binutils/objdump.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/binutils/objdump.c b/binutils/objdump.c index a35982ea969..ca4813ce872 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -2873,10 +2873,10 @@ jump_info_visualize_address (bfd_vma address, { if (address <= ji->end) line_buffer[offset] = - (jump_info_min_address (ji) == address) ? '/': '+'; + (jump_info_min_address (ji) == address) ? ',': '+'; else line_buffer[offset] = - (jump_info_max_address (ji) == address) ? '\\': '+'; + (jump_info_max_address (ji) == address) ? '\'': '+'; color_buffer[offset] = color; } } @@ -2907,9 +2907,9 @@ jump_info_visualize_address (bfd_vma address, { if (jump_info_min_address (ji) < address) line_buffer[offset] = - (jump_info_max_address (ji) > address) ? '>' : '\\'; + (jump_info_max_address (ji) > address) ? '>' : '\''; else - line_buffer[offset] = '/'; + line_buffer[offset] = ','; color_buffer[offset] = color; } } -- 2.34.1