From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 1C901385B50A for ; Fri, 6 Jan 2023 14:12:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C901385B50A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 306AONJC031887 for ; Fri, 6 Jan 2023 14:12:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=Xoh4r12I4JsehBK1BTh32NgsD4sLTYoVQ+C9sW7TZ8M=; b=aOCoRs8U6DGrl75hw2UVgncDNz0D2lOFFw3K9Cmyh6lmeaTZyQFOGQH97TA9mUivtv1a IB4bznn3XbqbXARG//bOMoLRwirYFr0SrhUzP8BsNK4NW8INUy1E/XG0c4t/JDSR78Rm 6DiB9LJQMCG1q46JfdYv6XgK2vQ857Dk3QRqrYRNool8xj3VXykUAwZaA4+i0aP23Qzt vnlnqz8yjCtWmBn8kn2RxWifTIOBjavFHi1xZjrMKFvYoRgyIbqqUsGPBXmshCBXLjg1 x8lOAhswAPHTn1T52FdjxzzabvrQxDfIfFJM+NBHuvIr5uhElWtEpltv6VhVVXxNp/hk AA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mtdmtu4ae-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 06 Jan 2023 14:12:53 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 306DRMt7007639 for ; Fri, 6 Jan 2023 14:12:51 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2106.outbound.protection.outlook.com [104.47.70.106]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3mwft13rhd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 06 Jan 2023 14:12:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XxF/ustCiH4amZ27fDWme8i8fJ0CsIOXfR6GRWRhXZ3HS+W++AomqYqvHkULg7w+8OdjUvbLLgrZbiAma7xBR9DwJ42Gkr/Hf2qN35A6JMkNI0rogtFg0xTLNzXDoV/S57MuPDERGxt5LKgbEpta8hXzPftjkMy7lmtvvg7mnifhwBDSEIChEj6z93yyyfnauZwan8iQKufLP4ipLu+sN2HNaUJFlJXVP+VS9Swq1EG7iyTmGspmFd1UiN73pXdS/rUwernx1Z8pdU1j/cMN5DpCd9TtaLY7pxLHAlHEnloslLNqkOUlqFAOQoz6/Bja1RREXHYyGW/Q9Fe7hf5E5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xoh4r12I4JsehBK1BTh32NgsD4sLTYoVQ+C9sW7TZ8M=; b=WJKUT4+EGNsKX83kZSGhQyoB9cOqdU2545yTj8UGRa9g7q4t/ggBOLSga982t9YEZOmSBeiwkhhktw+nGQgeizPNx6zfXD05XAOf496J3dyG6ZfE5cHCt7neXgRZczNgMlw1ZxDPH84Av4SvLSc0B9jbVVh5v4tXTZHkr+Yqkld/9i7YyiR/wLr6VZjL6h9MAFcU/1lKhGnBAd9oFpp6YSDlP7c44dtA+86XX7PWJED+LLqDWBiPBRO8VrV6mUjh7mtbOWp077ATjJuu/539YcJEOnogRHz3bOyMKgnL2lRwqkF/VIsc6EraTa0P5jFndvnrD+ercHZw887XEu/kwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xoh4r12I4JsehBK1BTh32NgsD4sLTYoVQ+C9sW7TZ8M=; b=qkRaV+9cI06KagW6iT3tJ8CHlzKCE3zAXLyweMiFb6EnY6iGPWh27cvimGBxCnOEBli+vQHJ0Q6WEa2utTx7LdL5vvy2G4KeBVh6QTxHKlnWWeOQT+D1BShubDtxo20Rr3C4nVe6Ub1ol3XBpsQaj4T0Ls0GMEb+jXbBY1c6Gfs= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by SA1PR10MB6414.namprd10.prod.outlook.com (2603:10b6:806:259::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 14:12:50 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ebe9:b7c9:82ae:d256]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::ebe9:b7c9:82ae:d256%7]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 14:12:50 +0000 From: "Jose E. Marchesi" To: "Jose E. Marchesi via Binutils" Cc: "Guillermo E. Martinez" Subject: Re: [PATCH] bpf: fix error conversion from long unsigned int to unsigned int [-Werror=overflow] References: <20230106075816.387489-1-guillermo.e.martinez@oracle.com> <87mt6vg41b.fsf@oracle.com> Date: Fri, 06 Jan 2023 15:16:57 +0100 In-Reply-To: <87mt6vg41b.fsf@oracle.com> (Jose E. Marchesi via Binutils's message of "Fri, 06 Jan 2023 14:56:32 +0100") Message-ID: <878rifg33a.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: FR3P281CA0109.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::9) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|SA1PR10MB6414:EE_ X-MS-Office365-Filtering-Correlation-Id: 6b813f35-fe9b-4fe5-48c7-08daeff017f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mhucEZpgpUU8ct+q53qOO3Dzv0M1vQbwFD6vyaUJclGD+d2MArBF8wVTv4CY87ekGfTT5cernLkzUw3M0tLtCq/wdYkll0dMRGYgwmLq0WrfZXwm6CL1w7Loe6i8cO1WL59R/D1mV20JgVSRPSh/yyKeTge+3p6YezYhiV5hBODtSd04sbj9wT6O/Ut/foSxdWkEx1H7MbiY+pJ/HuBDhRO/EokSFYA1L1I5ZzbagM+/81O7UaiU/0Ogpe7/zya8tylnmMnPpyOIyfVZLO4V5jDDbBWHc0SewWy/PhIN4T6K7ukWyS/iSFhDUNbigakwWwHZ3ktCksDEwAifXyfM4qV72KXH8z+vnIvZQofqPEJ8qd+vwExVbqfc9kv8Pz1i5z8jxX+3HFusx3MyFcZ2KzRbfBEKaf25eDC4Dp5Vk1qk5UVLDFE6/uyiC2qwDF8lPrg0FBz7Hgo7zYkuE045APAFWtG5hBcmeHPI8aJwCMzRogfL12m3R+dAoSyANV5PtET32zg9q9/xDa17w2xfKNmkbfGiJLm5PC/3iRXzjWdp76dGShQ5nQcuR9StQ9rtzEeaid7NQTq2vKZDhlQQaiXdqW2OwID2o36F4FrrRKUPtz3KODYsihF9QYivuQ3DHyjredIFmz4mmfqQII5vBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(366004)(376002)(346002)(396003)(39860400002)(451199015)(8936002)(4744005)(2906002)(5660300002)(41300700001)(86362001)(38100700002)(36756003)(186003)(26005)(66556008)(6512007)(316002)(6916009)(107886003)(6506007)(8676002)(478600001)(6486002)(66946007)(2616005)(66476007)(4326008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fAwDS3VYTLShZgY+5rMrwADfscbs2fACKJF+MfBq4Xsq0wxyMZLPvACliYV7?= =?us-ascii?Q?GZvj+EZ3UfILPKRfpKFzNYkqD7JRT5vdKB37TuEXnhQsV+rCiOxIWwb6SYE7?= =?us-ascii?Q?5iSa9U4Nw1BNcBa3jXsowHNR8RfwmjSIJlFSWM5oBMoX5P7iuK8uDztXEeue?= =?us-ascii?Q?tETG47A4bBtuo1rui1XrP+BjUMfrAGuWIrhANzLw4zE11cITvCcSAl0PrpJf?= =?us-ascii?Q?fbFaYtvK1GVgWei2JFXZ0JYDTPjqRmqPVcbKCni/FuX7fZwGa/fgoCx8M2Oz?= =?us-ascii?Q?rH6yutGEqJB1HgW4tgvU9hNhi5LcaLtvs6/SX0conFomzhmb5KQBOWFbbtCO?= =?us-ascii?Q?jAJbvBrc0pMsCi5MWjqKchEYOppCWaHlyAyMqeNFy/pXC4hLSiNZfvGLW2ho?= =?us-ascii?Q?SsoXbEB/i38laISfYVTydwIepkfJBvDc7/Lkq4VlZnSKGodkYwLYA+2vKMrk?= =?us-ascii?Q?GBkRbscjmi3p+rGY8IbhcR6L/mlqKnV2/AUe+f3VJ0kKhtQliTcJAOCv32RW?= =?us-ascii?Q?/PXNcxdJ4qH0pGrscVXD1vslmqpZxJTQsk3USJW/sX/t2S3yw12kXxC3L9lr?= =?us-ascii?Q?R2ylvTxZ9JUhvaSBnOqIaBNC+XbVXINPCeJYwaGR+n9XWUKLXY2NdAv0u5xj?= =?us-ascii?Q?LeCvv8a2RrQ9z7TDvjoSENnUCSQrrJuOkqk3X8hYmNTcoHmyVPz+W4rFCtSj?= =?us-ascii?Q?EHX9fvILqN6JoQRCMDciVFh56r+/wpp/7XeDQJY5n22sjAN/JSI9nY5FMz3U?= =?us-ascii?Q?GJP17y2ZdDBDIrftxILokNxWUXT3jzaJAhtagt1n57V5NXMT1umHQrW5EBuo?= =?us-ascii?Q?KEJ0Z4Bai4FWr15TxZR9FKjrxFQksFSCpbMQX8y3RhNydSWUSlp7Vwhiu4EZ?= =?us-ascii?Q?pqzrcMqw+kTofJy7wwmosHgYifKvIBr+sYOo2m/sYYYt6PbkwQph69bRsZdt?= =?us-ascii?Q?S2uSGHeF0sXwNE6V89O+tieLjPy1ZwfaBhtTGD6OZwbkGde5UVvWkIViPbeP?= =?us-ascii?Q?ldkFrcqGtFnS6GZEFGdkV2v4+Bew/enhc4mJZQrpyBxOSlTqkVd2NscLjHf0?= =?us-ascii?Q?u52Q1/jKu8EDoRjzF4Fk94vKJLrPcY3C97dRTVdSP6AuBHjjni3SQF2vPs7L?= =?us-ascii?Q?cjjeGRnIxx6+35CrnCG7fIKocHPYieq3CPHdtqsST+a/uOvOvVpyeD2fCemH?= =?us-ascii?Q?W2qQMVkpOKT8tCN/HXVxAgFvX/3yRyAsCg0+Jr9kwRcHZR2YyHm6YwNzgVJR?= =?us-ascii?Q?im8UzW8M09v5mrsk8Dz9doUT3eHO+HEQQNnLRYjsnsapX49Pv2d4CKJypdTN?= =?us-ascii?Q?WllW5ctbpBtS8al1v4vIlBV7ZI67f07My2mo+Z7E93wAJiR3KkOtmy6lafZI?= =?us-ascii?Q?zbjfzgfQGgbLykN4aCPTVNBRQFzp8E+qIcF8E4Qy6YIX4BxqsXDrYbt6YYV6?= =?us-ascii?Q?2S47HRk8G+TNDPU1P6qUp1Q7yAENHiefzJCUPqgqx7IzAGVvPR7FFmKuw0zT?= =?us-ascii?Q?RsbR4xmvXrBZd+p28T0zdzEfl3d6+82OJIfY0e3xqtYBmCIvNYmUfbQQm3EW?= =?us-ascii?Q?0aTbo7pURvR7yVGk41tBhLfqOtXb0wsZg6BZ0UEA9GPISkeWetEOUNWXqhRI?= =?us-ascii?Q?rA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: K9Q/IhYETdvcT5IkeYOlxHvj16BDM8qXXrEpjwCruX4Pk1W89YM2Fi3CyvkGPESrNN2lfZj5oSZ/UxAwHrJ9SUXlCAHz92ELMfEHcLLQ7gu2XURO4qdAKyPk9rBlkqS5n2h9TvmCwYVdxnB1Tb8Im34wa0GeWSBR/jnOrnImZlV1jaK5dDGbzNhwivcPKDyk1f8KYRF3BOe8ot/EknWDc9gnfqnjshaK7xjxHwFE1Iiq4ON3AZCnvM4PUqZq2WmRGhDPX8kms1Rgq4pYzLYUtf27BLvxRpTcSPNlcKsi/1j19Dq92/XKMSVBMHIo8uY3iYq8t6iUnkRbPyR8cfmUxrZYIrOqT0RZaf/k99M+VjwNnfuaxbPZTwKlAa5/vZdcsy6hcDF8Tul2hTPoLTGKLjPSoOVeKKxx6uy0YR2MlzxtEVi7O2AJ6SAouYFuvoJmX3YjBnyo3EKwhDN7gfRkbDDskQl0RdIAY4xaEmDsKanCEnocC8iRhboKtTGmt+RlxMj8cw4mPZG3zQQ5rSpiyfB6SySLG4Q0WGJ0phniqPffmMM+9qtGhoI7SNX2EveJCQ1g90FT53WxSK3jN32evFXh71xedxnK1+awM093hIjUQ/xAOVnLuEG9gwOieGsRtfP1cLT8+cYidbXFGM6JZtfmG9ogXv9CYu6gnPywoGuzKgjG6ZyuIxj7Wrmgz8bURsgjD9LdQxGr055j/nMd4F6lZ3a0iU5pyJXO+OXmwUqMdX0x2dNNyNSngAOHkgHR X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b813f35-fe9b-4fe5-48c7-08daeff017f5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 14:12:50.0580 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cFqfUR1LVqXl10ekId/2Mhr05Xg0MVWk4QMgqf96bNtxoXNIayIbCC9FdlHEb6v05ZCyGvpjkTnEzGQeiuM/k66iT6m/jHOIWMJ8k22OLR0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6414 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-06_08,2023-01-06_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=914 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301060110 X-Proofpoint-GUID: v5KwK4C9tZ6ixe5ILoMTbCAGEvnn6OM4 X-Proofpoint-ORIG-GUID: v5KwK4C9tZ6ixe5ILoMTbCAGEvnn6OM4 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Hi Guillermo. > >> cpu/ >> * bpf.cpu (define-call-insn): Remove `src' field from >> instruction mask. > > I don't think this description accurately describes the real change? > You are basically adding an opcode for `src' to the instruction > format. s/opcode/operand. > >> diff --git a/cpu/bpf.cpu b/cpu/bpf.cpu >> index 13dde7094c8..2ae74fc4c18 100644 >> --- a/cpu/bpf.cpu >> +++ b/cpu/bpf.cpu >> @@ -768,7 +768,7 @@ >> "call" >> (endian-isas x-endian) >> "call $disp32" >> - (+ disp32 (f-offset16 0) (f-regs 0) >> + (+ disp32 (f-offset16 0) (.sym src x-endian) ((.sym f-dst x-endian) 0) >> OP_CLASS_JMP OP_SRC_K OP_CODE_CALL) >> (c-call VOID >> "bpfbf_call" disp32 (ifield (.sym f-src x-endian))) > > The BPF side of the patch is OK. > Thanks!