From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 253A9383D8F7 for ; Tue, 13 Dec 2022 13:20:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 253A9383D8F7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BDBxMkp004232; Tue, 13 Dec 2022 13:20:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=1/nRauWntFxzdXNIKY/IyuEwM+kWrmFNinmxxU3o/58=; b=IM0GWOIdztN5csSGmcIpCU7UPxOYsgfS6tq+bxtzz6b1zT8UEVbO11tLcFRNvF2eM6nT MmZVZ55jPYvKrgez0YhtIeAf132hqDjKDOCeN5wejORf4BMurXrQ2EWgDXdFMx2g+9rz qgT5me1azgaRNh+iPvAVDPPrLLwfLxFFLnyfs6Q++KO9o1K7XjhVrXiTYtpAiBiFwdru 3fETRdY8IHEcOn2MvCFsZTJHKIIKEatty9EmL7K4Ig6BGE0OxSm/u3G06r5GXXYGlKEq Bs4p0DnXXtdW3IidHtUeLdePAfMei8/8N6gFeXL8OcSbJ3xU4gh12xUWHZ6zCbitS7QB ZQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mchqsw9uy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Dec 2022 13:20:32 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2BDD0GkG018562; Tue, 13 Dec 2022 13:20:32 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2109.outbound.protection.outlook.com [104.47.58.109]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3mcgjc9507-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Dec 2022 13:20:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RClODdjOoC1m5bxgnS/cDo2X61alKlR5oOzXouhSNyrwoXyqo+BFys7rS5wwjyZQzvw7K4HIW+ft1cyiCFQe4K6K7irDJVgYHwy2If6F83nijv8BNz9PZZv+Wt9jLiy7ggQBMEoweGFA0u3byIyHpJnyTdtRZajmA0C+DmJ7vDKKNdw8yOAtwpXXHMegkQutGqs12I5KVY6Hmvl6sCt6/JFiSlDVagyGRuLcPbq0CNXEFccDDZXw39rYJrY5CpX1dHZaQqYj1GwDkkfciUhCwefsUOXzDSmHicKMuxTi6lelaxCCoVCF3cIO6e5fUoBM/RiEowXOO6eHija5OREs1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1/nRauWntFxzdXNIKY/IyuEwM+kWrmFNinmxxU3o/58=; b=nArjPPCu3ZnD7hx9OdOxIhjLaOIPuOOEiVUH/zFxA8Jn0aaUbvYa++bMm8n1vpPQOleNo+Fm2RmdqM0QPrNbCQ7pOZGDH6hSdKrm7xEtnBnaPj5TvW9qY/8aeNlFBqB46ubvlqCmv9yoqsX7WXYGIVETIOzpXb0kgOEnvXRhClBGSi5IihPuozWQHmxXrZrWjQKzaJ3N1vfzw6Wj7icYyrYMKpQvMDNZWwtEH4H80pPu8BE+dxsndD9yww7QHIGWR0WmzuQZY2UWSVuLdRXEmXwc/ZZkDTuVoWl2n8vBaLw/puP4tlKG+JHcB2SIPRLr4sNbvUoZyPbnatqMJmE0eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1/nRauWntFxzdXNIKY/IyuEwM+kWrmFNinmxxU3o/58=; b=dzuOpPcZVL17B6x62+F1AWvLU+XuKx0a6+6C4K/m7Q8IPCgQQLJU9dJKFWejRV7MVZPnzAW7w0HcW6nQhMvjeUj2NOIgYSIOpUQGEpaRX70uzOKdTQhoHmcurzofLQ1wSDAidY8/9Nsk25Zeyo+uuQ4eqnTaaIyL/egNlvAmdKs= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by IA0PR10MB6795.namprd10.prod.outlook.com (2603:10b6:208:439::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Tue, 13 Dec 2022 13:20:30 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::6e94:e2a2:ca1f:2a7]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::6e94:e2a2:ca1f:2a7%9]) with mapi id 15.20.5880.019; Tue, 13 Dec 2022 13:20:30 +0000 From: Nick Alcock To: Mike Frysinger Cc: Indu Bhagat , binutils@sourceware.org, i@maskray.me Subject: Re: [PATCH] libctf: remove unnecessary zstd constructs References: <20221211002622.564875-1-indu.bhagat@oracle.com> Emacs: (setq software-quality (/ 1 number-of-authors)) Date: Tue, 13 Dec 2022 13:20:23 +0000 In-Reply-To: (Mike Frysinger's message of "Sun, 11 Dec 2022 16:33:42 +0900") Message-ID: <878rjbfnjc.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0029.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:151::16) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|IA0PR10MB6795:EE_ X-MS-Office365-Filtering-Correlation-Id: e47ce067-3ba9-4a01-e0a0-08dadd0cce6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xVe40PoUKeg8PPPKwOlYkc1QxUMlEH62TjBCrX4bZNXXMC5aBA+xNCN+1rkhVlCnw2oVfGgcCKLszROIqTC2OAbe/DD5B3hb9Xzj4D7upqMsZpuvQVzHptrQYSq6noExANrPSBw7wjGWjP/S35IHEwHlgrFDpNvSU1qNlKPbQxBFwRsp+BR6ceg28rNQmTnS+xoc2lzEvqFrLLAK6JjyUITYaVcxbYPqkySZ9X+Razcxu3GYCDmdakSwRQVsXo2j0T/XxBwBseghuAyaNIj11xJdrhvBUwkEpkHeHTlYNBac2UxSx2lZ5XbuqdR1waRwjSkBcJ5qo3azCiTvwSfGVZEy2oOn+jLA1CPYRRebwcIMuesWth0N6LF3+l72wWd64/cT4DBmNemiwmoXFVw9hqWNBBfTvjAUTNq4NW5rmM3+9gW6Rzn5gWW7Tzg+zN2AuKdtfgWm5Daa/e9r29ZTkniNffBOXANS/HSWDOPWAXs2eJMetJKf/uVCIwgIV5fFxiITRUE1cNrJIA6dKcD3UhKdSAoVlz0EnYAQCdXRfFHlre1e7uKCWMxtwhnmOftPuzRD1bjFBsFZ6KJpFMmNkFAocCaLduWKDmzc7gqtVn/4f4H6LdgsJQDeAYiNRy7x795FOlwEByrrKyJNPxpPFG3K1XQav1QjtQNoxlvYk/A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(136003)(366004)(346002)(396003)(451199015)(86362001)(4326008)(41300700001)(8676002)(66556008)(66476007)(6916009)(8936002)(36756003)(316002)(66946007)(6666004)(38100700002)(186003)(5660300002)(6486002)(478600001)(53546011)(6506007)(6512007)(9686003)(44832011)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1Vspp65OdmTnr+VpsZw7bizh0Zkt8QeOKjh3ZdJIr6cbFVlUe6OnPbSjrBso?= =?us-ascii?Q?/RxnkLI6o158qG+sBhWHhq7s4zLQfpJt4R4Sfx52tBkDO5yh9txmC1KHCbVY?= =?us-ascii?Q?a0+GcwThhlRJRX1P3Wowl8LY44f9Xt7nlV2pYeHazCx3864q1H4AOAoWf0R3?= =?us-ascii?Q?k6JKb6pEwdo30xc3K5n2vzyirk+YiBqOVzHHzpLVHfNw8PvVZgStdUKRCb72?= =?us-ascii?Q?N3wnqRgK/8ZoUm7qK8BWJbt4v3aQu+JG4x74EYI5QGDmReggzFE87E0qvX0S?= =?us-ascii?Q?ViF7fadDxCYQFOWGuvbuqW4ibHl50dpPy7+c+pcwHvNWNCgoSYb/meiZRlDm?= =?us-ascii?Q?MS0BTjnDb3ZeAr2KKuX2utpBjG6iewekzzMqYQkk4rbZS3ZGMv5sXuMg5QeY?= =?us-ascii?Q?Dp3p6++NWCLtT1CLgzs/mwRFANmDr4CleBqndYjFPisewK67lB+YVZG++Iqi?= =?us-ascii?Q?1knzlmzYCgI5WJ6msFW94pfK8+ddVPmjRtcMALBTTbjz4/linysSx/WC+Aol?= =?us-ascii?Q?qFwM4YTtX2qABV9eu9jIwgd87FqFh40AKyrTNuDMpYSUvqqt4TclvQlSznKa?= =?us-ascii?Q?vmg5X/qJJ71CU8J3Bd1zJIsX0AAgg1CburGvkIMWIkUFivh5QCscfRHkUpZr?= =?us-ascii?Q?YKeU3fmOEZcIRJya5eIiMfZZ1vAp52mU4dfGqW//7E9dfqyBXhp2NYbsVHk/?= =?us-ascii?Q?0trfkUPg8boA0dt5JzD3ktz3gQd8akugZZ7TKQL5Y5nnkXJLhIcEvWRgGKsg?= =?us-ascii?Q?77qDDgg10k4vvZS7IMRokq5tzO6bBXU6hBmAgXk7ZusD+nEPv+m/HmCRRlaJ?= =?us-ascii?Q?a9MjohCmOs6Gy/YgHLthfycpA6LOeLfHkGZ+a7uMf7pPzz/QzbHUUiMpE31T?= =?us-ascii?Q?WlDKdDjloj93sL1/e43zEM8yMba38uDKr3U2lpwFr3IsDu8TpMemOMAnYI2B?= =?us-ascii?Q?fE5fRw6cNDnItEwh9VZ75aOO/lDdAdic2v4SACSFIfDtgTbxOboJBcYZ0UFB?= =?us-ascii?Q?mBZBEddD2EHiNm2skT5aqpv5R603GwUCuUx1YQ0NLsZDqXwK6ylowpwnYkU6?= =?us-ascii?Q?b+YV5/LL12YHwZL11JaesyC2inX2a4e84IdoP1pp+JMaJNnG8KGEitGHUsnK?= =?us-ascii?Q?fvFwLp5E/zVM6IVLR9LDTmA7spnYmfZTpyGB/RVC14EiWgE+oX3XR+7eWHdo?= =?us-ascii?Q?aHEqe6vJkxAQdjYfMfuGZe/YzwbHFwVQQ8pBMPzxZEMJWqu7Zgq0Jx8MZkul?= =?us-ascii?Q?tP8bMj1+6LEawhqrDPpxk5mUWgzApeUqCV694/n7SX+N9YSAcJdPzpSj8cR0?= =?us-ascii?Q?UquTHx8XK12CTIkuvu+4Z2wBl5FIXabW+T99aVno4NGeGJWAWwC5FHSdEKG7?= =?us-ascii?Q?C314f2Pdu6Wa63jQaZ0Ox2FGwV5/9IFtyDkIrKyc8M0TRlkeifAwbONuAq+V?= =?us-ascii?Q?6uCnT1vZawop5FumcfmSWL8vCzA59U5HhFQeCdl5UnB0ov2u6MwOuMZlYLJH?= =?us-ascii?Q?h/4kRTRwkoJWEv+SG2XXUyPEUlSZ9z2Mj6kq3lxZ4lxBXMu5XZzFFpxceGJQ?= =?us-ascii?Q?locGv3mrSdaigLVbi9TPObwmZsOchk1GmpUpFgeSirWKgQR1fb0XmsHlXekl?= =?us-ascii?Q?fA=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e47ce067-3ba9-4a01-e0a0-08dadd0cce6d X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 13:20:30.0093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XE/GdNPaY2aKAZmOdkZuGu8Q7coWmV3nTo6iWq+dqIQTkV24CVdGVU6xitGZfYs1T7Kzcnrz8h9rpiIsbf3TQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6795 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-13_03,2022-12-13_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxscore=0 mlxlogscore=990 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212130118 X-Proofpoint-ORIG-GUID: s6JGVpe6jphThC_SsQHA3igkTw0YNhb_ X-Proofpoint-GUID: s6JGVpe6jphThC_SsQHA3igkTw0YNhb_ X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11 Dec 2022, Mike Frysinger verbalised: > On 10 Dec 2022 16:26, Indu Bhagat wrote: >> This patch is essentially a revert of >> commit-id: 8818c80cbd4116ef5af171ec47c61167179e225c >> (libctf: Add ZSTD_LIBS to LIBS so that ac_cv_libctf_bfd_elf can be true) >> >> As the specific configure check now uses libtool, this explicit mention of the >> dependency $ZSTD_LIBS is not needed anymore. >> >> As for AC_ZSTD, it was suggested to clean it up (https://sourceware.org/pipermail/binutils/2022-December/125026.html) >> as it is unused. Althought this patch does remove AC_ZSTD from >> libctf/configure.ac, I am not completely sure anymore: libctf may have >> plans to support zstd compressed CTF sections soon/later ? > > if libctf ever gains such support, it's easy enough to add back in. Yeah, that's part of the v4 plans, and adding this back would be a tiny part of that. (And pulling this out seems harmless for now in any case -- it was only there to see if bfd would need it to successfully link, and that is no longer needed with the bfd configure check using libtool.) -- NULL && (void)