From: Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>,
Binutils <binutils@sourceware.org>,
Denis Chertykov <chertykov@gmail.com>
Subject: Re: {Patch] }Treat avr as elf target in nm.exp
Date: Mon, 25 Apr 2016 09:28:00 -0000 [thread overview]
Message-ID: <878u02rq9f.fsf@atmel.com> (raw)
In-Reply-To: <571DD4A9.4000805@redhat.com>
Nick Clifton writes:
> Hi Senthil,
>
>> 2016-04-23 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
>>
>> * binutils-all/nm.exp: Add avr to elf
>> target list.
>
>
>> if { [is_elf_format]
>> + || [istarget avr-unknown-none]
>
> I think that this should be:
>
> || [istarget avr-*-*]
>
> since you cannot be sure that the user has configured the toolchain as avr-unknown-none.
>
> Approved with that change.
Thanks Nick, but I think I'll take Alan's advice and add avr-*-* to
is_elf_format and see if I can fix the failures.
Regards
Senthil
prev parent reply other threads:[~2016-04-25 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-23 17:54 Senthil Kumar Selvaraj
2016-04-25 3:46 ` Alan Modra
2016-04-25 8:26 ` Nick Clifton
2016-04-25 9:28 ` Senthil Kumar Selvaraj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u02rq9f.fsf@atmel.com \
--to=senthil_kumar.selvaraj@atmel.com \
--cc=binutils@sourceware.org \
--cc=chertykov@gmail.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).