{Patch] }Treat avr as elf target in nm.exp

{Patch] }Treat avr as elf target in nm.exp

[Senthil Kumar Selvaraj]

Hi,

  This patch adds avr to the list of ELF targets in nm.exp - without
  this, the nm --size-sort test fails for the AVR target, as it uses
  nm-1.s as the source file, instead of nm-elf-1.s (which has the .size
  directive to set symbol size).

  I tried adding avr-unknown-none to is_elf_format itself, but that
  causes a lot of failures in gas and LD, just as the comment says :)
  I intend to follow up on those failures as well, but until then, this
  patch lets the specific testcase pass.

Regards
Senthil


binutils/testsuite/ChangeLog

2016-04-23  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>

	* binutils-all/nm.exp: Add avr to elf
	target list.


diff --git a/binutils/testsuite/binutils-all/nm.exp b/binutils/testsuite/binutils-all/nm.exp
index 94f7f9c..34454f8 100644
--- a/binutils/testsuite/binutils-all/nm.exp
+++ b/binutils/testsuite/binutils-all/nm.exp
@@ -163,6 +163,7 @@ if [regexp $want $got] then {
 # all the ELF variants, but adding the patterns here to that proc then
 # introduces a whole slew of new regressions in the GAS and LD testsuites.
 if {   [is_elf_format]
+    || [istarget avr-unknown-none]
     || [istarget *-*-dragonfly*]
     || [istarget *-*-*elf]
     || [istarget *-*-freebsd*]

Re: {Patch] }Treat avr as elf target in nm.exp

[Alan Modra]

On Sat, Apr 23, 2016 at 11:24:19PM +0530, Senthil Kumar Selvaraj wrote:
>   I tried adding avr-unknown-none to is_elf_format itself, but that

I think that is what you should do, or submit a config.sub patch
upstream to make a plain avr argument return avr-unknown-elf.

>   causes a lot of failures in gas and LD, just as the comment says :)

I only see these differences

gas/
+FAIL: lns-duplicate
+FAIL: lns-common-1
ld/
+XPASS: --set-section-flags test 1 (sections)
+XPASS: ld-elf/merge
+FAIL: ld-elf/pr18735

-- 
Alan Modra
Australia Development Lab, IBM

Re: {Patch] }Treat avr as elf target in nm.exp

[Nick Clifton]

Hi Senthil,

> 2016-04-23  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>
> 
> 	* binutils-all/nm.exp: Add avr to elf
> 	target list.


>   if {   [is_elf_format]
> +     || [istarget avr-unknown-none]

I think that this should be:

        || [istarget avr-*-*]

since you cannot be sure that the user has configured the toolchain as avr-unknown-none.

Approved with that change.

Cheers
  Nick

Re: {Patch] }Treat avr as elf target in nm.exp

[Senthil Kumar Selvaraj]

Nick Clifton writes:

> Hi Senthil,
>
>> 2016-04-23  Senthil Kumar Selvaraj  <senthil_kumar.selvaraj@atmel.com>
>> 
>> 	* binutils-all/nm.exp: Add avr to elf
>> 	target list.
>
>
>>   if {   [is_elf_format]
>> +     || [istarget avr-unknown-none]
>
> I think that this should be:
>
>         || [istarget avr-*-*]
>
> since you cannot be sure that the user has configured the toolchain as avr-unknown-none.
>
> Approved with that change.

Thanks Nick, but I think I'll take Alan's advice and add avr-*-* to
is_elf_format and see if I can fix the failures.

Regards
Senthil