From: Tom Tromey <tom@tromey.com>
To: "Clément Chigot" <chigot@adacore.com>
Cc: binutils@sourceware.org, nickc@redhat.com
Subject: Re: [PATCH] bfd: add missing include <time.h>
Date: Fri, 15 Mar 2024 09:39:40 -0600 [thread overview]
Message-ID: <87a5mzjygz.fsf@tromey.com> (raw)
In-Reply-To: <CAJ307EjH-Pr4i0ktyxK0x5VKOvyZSyguR3tF6LdkT_JSzAfwNw@mail.gmail.com> (=?utf-8?Q?=22Cl=C3=A9ment?= Chigot"'s message of "Thu, 14 Mar 2024 13:46:44 +0100")
>>>>> "Clément" == Clément Chigot <chigot@adacore.com> writes:
Clément> This patch looks trivial. Though, I'm wondering if binutils might
Clément> support some non-posix systems where this new include could trigger
Clément> issues. Do you think this could be the case ?
FWIW a good resource for answering this kind of question is the gnulib
manual. It normally documents when a header is missing or when it
doesn't define something that it ought to.
On this basis time.h seems safe:
https://www.gnu.org/software/gnulib/manual/html_node/time_002eh.html
Tom
next prev parent reply other threads:[~2024-03-15 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 10:37 Clément Chigot
2024-03-14 12:46 ` Clément Chigot
2024-03-15 15:39 ` Tom Tromey [this message]
2024-03-18 11:49 ` Nick Clifton
2024-03-18 11:49 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5mzjygz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=binutils@sourceware.org \
--cc=chigot@adacore.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).