From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 0EC1D3858C56 for ; Fri, 15 Mar 2024 15:39:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EC1D3858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0EC1D3858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710517185; cv=none; b=eNlscV+7IpQKCdYWuG3uEbiDXqhTiZ2iiG5ZadzArabCArsrVu2xTb2Q35fOpqORP3dUb3136QRMgcwXhOGbZO5lc/a41vjCzxvV/dY4BeELLE/h5DXsKBiNRYJG4HtLK5TA9pL3HVcGoGdCF16EKa46t/T8LGWWbTPg/9BgflU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710517185; c=relaxed/simple; bh=f/umqW4mCpewbwCU8r0cZFd9TRxelxZZ83GVE4r1l60=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DJ9fAeDdQKdgCKIqWv7fgk3UV1a8KGbblB4Ls6ggUId9mr0pRa6q9w0tNMGFcO8YVXUuiBRHX8w6/AFcqtt6etJY8AMugqgynpFqdNNZj5Acp0zUtO6x0Bvf4P9E2sEB6WavNjR/CAak2hc0ECFP99dkReKu1wABsID4XqXiQIQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6006a.ext.cloudfilter.net ([10.0.30.182]) by cmsmtp with ESMTPS id l44or9PbKtf2Ql9eoryjjX; Fri, 15 Mar 2024 15:39:42 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id l9enrAqwyzZ0Ll9enrbBHt; Fri, 15 Mar 2024 15:39:41 +0000 X-Authority-Analysis: v=2.4 cv=TY2QtwQh c=1 sm=1 tr=0 ts=65f46bbd a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=K6JAEmCyrfEA:10 a=Qbun_eYptAEA:10 a=A8oJy8mYAAAA:8 a=mDV3o1hIAAAA:8 a=MzztuzClQUV_0qCAbjoA:9 a=QEXdDO2ut3YA:10 a=952bCUiw_ogA:10 a=v_usjJbvj4QA:10 a=MasS0_dV9q-jaWZIey9J:22 a=_FVE-zBwftR9WsbkzFJk:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ja513REK8Egjc6awZ3pccB4Xjgvnt5599LMHwVW7aZQ=; b=pFQR7N8Wm9wUvNU9Xu8woAJcRH Bgg8/+g7ZE0d4cJ1DkjG7Vs84wli9/dnEg88frE2MqvF8/AdYmSP15eYoBA1R1Y3dIvoTfnwPccqA DgC9ZT7ek3OSx0nWalGS1cnTs; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:35896 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rl9en-000XFr-0q; Fri, 15 Mar 2024 09:39:41 -0600 From: Tom Tromey To: =?utf-8?Q?Cl=C3=A9ment?= Chigot Cc: binutils@sourceware.org, nickc@redhat.com Subject: Re: [PATCH] bfd: add missing include References: <20240313103728.1253706-1-chigot@adacore.com> X-Attribution: Tom Date: Fri, 15 Mar 2024 09:39:40 -0600 In-Reply-To: (=?utf-8?Q?=22Cl=C3=A9ment?= Chigot"'s message of "Thu, 14 Mar 2024 13:46:44 +0100") Message-ID: <87a5mzjygz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rl9en-000XFr-0q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:35896 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPDIZkoL4WBozVUL97fdjP1lJ/9UIz6rp3TEn/ZOuw55LPhhuzmynbUYPknW1N2fA1tHNXZ5KndbTx0kQxMkhOmc3RPSQXWduN00c8mOXbzD6JtjhUB3 CrLAfpZwDoK1N6yd9vKh1kMbKuh+9Ig9Kt91vIKeOuAaWqg1v3oLxxpzxraMqG7gNwEWOc2TmZ3yCLen/ScTVNcJxGBSjGvg8+o= X-Spam-Status: No, score=-3015.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Cl=C3=A9ment" =3D=3D Cl=C3=A9ment Chigot writes: Cl=C3=A9ment> This patch looks trivial. Though, I'm wondering if binutils m= ight Cl=C3=A9ment> support some non-posix systems where this new include could t= rigger Cl=C3=A9ment> issues. Do you think this could be the case ? FWIW a good resource for answering this kind of question is the gnulib manual. It normally documents when a header is missing or when it doesn't define something that it ought to. On this basis time.h seems safe: https://www.gnu.org/software/gnulib/manual/html_node/time_002eh.html Tom