From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.esperi.org.uk (icebox.esperi.org.uk [81.187.191.129]) by sourceware.org (Postfix) with ESMTPS id DBB663858D20 for ; Fri, 20 Oct 2023 17:01:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DBB663858D20 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DBB663858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=81.187.191.129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697821308; cv=none; b=JfMEHY36V/CkgzflgT93FU6I/j/OKHsrdcXznNqpt2GM8dWnlU1xLCunpGiKzpkBmdQCmIVr1TOuIWr9k3zKJLTwBYPBefmGT51zr96MqtDFlBaIDfrs93EjZvVEUIkI5K1DAgvLFpT0lLeHEX43vvUoVMgmjzn6WN2Rhxz+fnk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697821308; c=relaxed/simple; bh=cIh+zO/f2UaumjCPPMjR0E6rAdT/We6au12v9AYNh6M=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=FGBCRTHYDrm4KNOk9E9fcr3QacOpHNMOMVxLmpCjITDqVd4CgYSbFwjZshICp6Qw6LeIqda4WXSok0bkWLm7OEF4bbwNmO9lbRtlkXTpji8YzBsStncJP1XxEE7Qx5pCqachFRdKWTyo8lhSZEePk8PjrhRDBAe5yiU04jUB6uM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loom (nix@sidle.srvr.nix [192.168.14.8]) by mail.esperi.org.uk (8.17.2/8.17.2) with ESMTPS id 39KH1h08010131 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 20 Oct 2023 18:01:44 +0100 From: Nick Alcock To: Torbjorn SVENSSON Cc: Subject: Re: [PATCH] libctf: Return CTF_ERR in ctf_type_resolve_unsliced PR 30836 References: <20231017185438.407796-1-torbjorn.svensson@foss.st.com> <87jzrl82b9.fsf@esperi.org.uk> Emacs: the prosecution rests its case. Date: Fri, 20 Oct 2023 18:01:43 +0100 In-Reply-To: (Torbjorn SVENSSON's message of "Wed, 18 Oct 2023 09:40:43 +0200") Message-ID: <87a5sd8byg.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-DCC-wuwien-Metrics: loom 1290; Body=2 Fuz1=2 Fuz2=2 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,KHOP_HELO_FCRDNS,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18 Oct 2023, Torbjorn SVENSSON stated: > > > On 2023-10-17 21:40, Nick Alcock wrote: >> On 17 Oct 2023, Torbj=C3=B6rn SVENSSON uttered the following: >>=20 >>> There were one more place where the incorrect return value was used. >>> >>> @Nick: Ok for trunk? :) >> By all means: push away. Dead obvious too, right above a correct one, >> and I still overlooked it. >> (I just checked for further instances of this in ctf-types.c and could >> see none.) > > Pushed. ... as is the testcase. --=20 NULL && (void)