From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id B60BB3858C54 for ; Tue, 17 Oct 2023 14:46:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B60BB3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B60BB3858C54 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697553976; cv=pass; b=pVPU/PH8xrmvHVQKX6ZNOLAuMLYzMHEamd2aaOZpmLaOyQGgigPd2N7Q6aCR1LiaIQDHUieKmcWL1fOy8mo7sQmK/agBByepPDrlbKU+QmkHsbAj0RjExv0L36sGtryU6kmhtshTqY12vGFgtEy+Ne2r2cH20xlr6Mg6hoE5NQM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697553976; c=relaxed/simple; bh=mmQMM6cOJZrmO2wXJ0idm4IrgMy4iMsmPaeiER0vvwQ=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=BbgGUbBh2LxoH3hn09ive0CvcIE6xqlPSdrnPsltAgC3uX6Ho31friW5uCy+SdBZjGwKc1BoXF31fgAY7tibsgrdw63b0aoO4RnaqJV8b0DWQOu1sNGW9tqkNFa216vXpK9cYG7bpdjUocqPk1IagYs7SnjL20qbsRuBxKEQqBA= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39HEjBnT022324; Tue, 17 Oct 2023 14:46:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2023-03-30; bh=v5ywFCp4tLKuigzIspu1LRWgH2eHF+EYtN8AMohRWE0=; b=h2hzaMeRdGokuOWKORhUpvCdci37/frJS+1wt/1tchaQksndzjg4iJSJCvJ4j27h8aBh qT2Lrx72DEgh1ueWTfHrLN1hgonjczm7GVhchOmVr+0xgP4qeY6rpHZl/3cxsaEJYPjg cb6XSpJ1l9yLVg4jhYXNvJb4NgMz357ME28sI+fZSVcXWzdQq9r7RPLjXYZ3djMhm6Ef U/3fxSrBIgQa00YFq/jJFWc0/7dGbP+2K7TZXSDCGhTLHkb61Dm6HQVV/jG2B0BUWUob oL0JclfeGO3R1iYqrAZkrGsZ1s7bRVNSLvymOEtxoedo1hX/VhYh8sU5QmxNzXkA7xH4 GA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3tqk3jncj6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Oct 2023 14:46:10 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 39HEXHhb040556; Tue, 17 Oct 2023 14:46:09 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3trfymdksj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Oct 2023 14:46:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SPSEOxb5Wkqw8W7gkCbSNXTMx2TJ1KyG56DGlvSOA2PZbNediGj/77DjPKmxM3Q3p3IzumOqNwn/wQ4e+Rfer3us5m0DZLdrt9JBr8MzWcVKRMgud+/n8juGecFXQpuQsUZ2BYkErrNcQXz5murpzPFMuFuTGDfhq9LZuKr4tt3mTkLnnxpahBWxstt//JR0Fj280ZrN5wtZCE7VhCGb5NOOX5633jmmI3cFDAhnlLACa0Dr8WepeWKB1d/7vz1JzJExZlcEKKxOY7In6kY85TB5SifVROUByOWIl5FBUVyYWCl2egRqzFq9uY+FXUj7otPUyVVlMdGstSp4OQOxug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v5ywFCp4tLKuigzIspu1LRWgH2eHF+EYtN8AMohRWE0=; b=oAzSLL8tI1+axWJXOve0GnzrqdhYD7nzQQyqeA642OSVSl7uZzE2+HkGcRob4UEhyqB4w5GAPr6iflD3kK6w0YiZBLZNwlSqg10wUtxZxVEmDcQ7lHUVhoU1I7RqFsN26n1OLpiVX/AXXL3og9ypWLwGS8BhFvWEg9aSp1rRpLPDADMHIcY5zcG0EXs2xObsyDWgSZ7jMNXGzNnbiQvbwHUzLIfLX88Y7Iw0Azd4FDXM0EHQ+3bCalWhMx0NxwLRGtQMkx8FwcwY2Ee2FcPhjL7/nzxURvVQcJeqlDy/uWUGprHArcfAqOOeGkl+BWIfYTwx9F1o2M8cqp23sKlojA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v5ywFCp4tLKuigzIspu1LRWgH2eHF+EYtN8AMohRWE0=; b=hP+Zu8fwzmdCDPGfQdizpgTIEpb1eDQEGzUb8OEjY7sjg7bpFoLCpx+YG3KzsEPRW6jh9zocaD/xwBPesCe0tojeB/Axm2jOxWPwvCLu1FPjngee904xK87L5HRbIR1foAeIWS4AL9RCx/fCH2JuCyg7sflP0dt61u0IUMFMytc= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by MN6PR10MB7468.namprd10.prod.outlook.com (2603:10b6:208:47b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 14:46:07 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::19ff:c8cb:d04d:8b5a]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::19ff:c8cb:d04d:8b5a%4]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 14:46:07 +0000 From: Nick Alcock To: Torbjorn SVENSSON Cc: , Subject: Re: [PATCH] libctf: check for problems with error returns References: <20231009151146.3818141-1-torbjorn.svensson@foss.st.com> <20231013140152.427376-1-nick.alcock@oracle.com> <482ae0a8-85c7-3a46-df1e-2d5850b7824b@foss.st.com> <87ttqrae3o.fsf@esperi.org.uk> <8c54b317-2ec4-49f2-813e-2e6b05f36824@foss.st.com> Emacs: impress your (remaining) friends and neighbors. Date: Tue, 17 Oct 2023 15:45:59 +0100 In-Reply-To: <8c54b317-2ec4-49f2-813e-2e6b05f36824@foss.st.com> (Torbjorn SVENSSON's message of "Mon, 16 Oct 2023 15:02:15 +0200") Message-ID: <87a5sh9ujc.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: LO4P265CA0173.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::18) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|MN6PR10MB7468:EE_ X-MS-Office365-Filtering-Correlation-Id: 32a5c6de-7262-4b2d-dfab-08dbcf1fcb84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IAYEjoxGM67eqMc7keAPR6QiSCGT3oKFEJpfCSacntZT3joXceOjipTAaCvguuRQTOQLg8LBBzgCwlTPLzmV6ekFFR3NQ3GFq2SeKZ2Q9NJeojR2SXq3b107xEJBbuma/WgrCR4MQBhy37Vr9LlxvioRuDqoyHlBySxEugiqI62D8ugiRU5CRxJ3BamV6mfJ08XP3j1sofmd3GujdlL8tSqtL2qVUEOaWFCI81sNS2D2T39HkWgdIc2PxUhEeA7o50QMKxM709z/hvuM0BEMEqiT8sJcUN9MuI5tzkxXtiRNRdiLkjJR8MiXp/dhvJu/3aWQFmIaPtxHr7QQVArX+3CfVKC6zEmf+6i1nvNFnh2kBUhCcALKdRv65tETaH/D9JV9e7nK4CVxq3l3EViuAZR5vNICtIgGkgbfGCD6Z4Ll9gaH5tYgC8D2PjKMU9rX9sgHVOKTXQJoeMJiC8EDNBerRDuTjwVKly6lsEoQLN5vLYEoq3jY5XCHuOfB9BoYYkGN6cAUS00L7rr2SnVd5a7YZIG+g2c32RmIQ04UtTQjlX2UYTgtmCG0bnbBNhKU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(376002)(39860400002)(366004)(346002)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(53546011)(6506007)(6512007)(6666004)(9686003)(83380400001)(41300700001)(2906002)(4326008)(4001150100001)(44832011)(8676002)(8936002)(478600001)(6486002)(5660300002)(54906003)(66556008)(66946007)(66476007)(316002)(6916009)(38100700002)(36756003)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xBh7MX9rDl12hQO5cx2MUv2Guhl1/92NfYYE7qwVRFn7ncCLqEFMHxrX4SH4?= =?us-ascii?Q?2EHacoW0Whd7C0/6RMr0fVuS8HPqeEvzVRYeClAwwFjfB2n/KfVMSpQh4MMy?= =?us-ascii?Q?SeTR0UcBKdCIiGHll/tnfPc55/14ken5YRyhCUpmGsrwQgsKo+I//9EzoQjJ?= =?us-ascii?Q?K7wW/kJ0FutMRPO9dpe4ZJ17EWyDyX74C0sbk2ubcKzAe/Vgt6kAaBhsrfT3?= =?us-ascii?Q?VidaeUIOjxS+QNyfUkmfTrJe2dNl0mZZ1i4YA0qm8YAtZ5DksRR2LHQuy0bq?= =?us-ascii?Q?wczwRXa5RuhH2lKYyLftmNjcMBgmtwUufifNcJcJ3eqeMcbhPWogkP/Qao7Q?= =?us-ascii?Q?LuNn8FHuOB76IPsLceNmeDoG6HB2smhuRPwD0S0SkHldWtwMXAYN+RoORcUj?= =?us-ascii?Q?/JU9M1nSiZY5k6cAA7FSJ9y9xVzIESJM5HyEfLGhYWBF6PO0ZI9Eu27aanKP?= =?us-ascii?Q?z1p5sit4FBncDH0Uq1VaLCKwoxPyv+M3R+v7BdfKJV2IFgsoF5ZEyJZyfRbv?= =?us-ascii?Q?hLrXtilsVbNhuvy7YwAtpWcFotV3uCNyJsg/l7u4q/+330HKztDoug7tLZ9X?= =?us-ascii?Q?biiVLE2vqTNV8yt3/qvCm1/UB/kt4oHvoHBLRbbA9tJrSine52vsMwua2bh/?= =?us-ascii?Q?uGPth2Oc1hOXqFgggddyMynviLgxz0mZg1Rqp3SdbMV09OesWxHTLIcWbnrE?= =?us-ascii?Q?GK2PoP9rni65mrIXaP238FgMMVE3xDa4yeMMH0MLkh/t68NYlnvlSb93IJnG?= =?us-ascii?Q?zv4r9Vl19sjhq1GyM208V8WaDfDJgmpve6cmOyWyabtTs+eiw6rQ8loh3LUl?= =?us-ascii?Q?sst4zWjs3kFkJkpuzioFYQgl+lEkwS18TZdwU6/qKQD10e8uhvQ7CC8h29VT?= =?us-ascii?Q?RDYdcc1LMnZmQrW4tnQftuBeLxNwCGfOqzVRQ5T6LUokui4lNNZJhfXmi0R/?= =?us-ascii?Q?ep0TmU6TaBsuKVZhyymz2EkUUnmwtcG0FfB2CcY9npghP1ZNwf46PpuEvljK?= =?us-ascii?Q?NyfvF2TUyP5CFjEpHpXyHeeB0gNc8dYV3hb6f77jfQ54X8LBdZLCRYmMlr35?= =?us-ascii?Q?A4E+Zi91P4Vj9vanzsgzqjthEfZ4CKpwzG8KiTn2esDxSh9Zqd0R5vB9PqBe?= =?us-ascii?Q?H+tYtq1XFZK7Ya40B0pREOQa3x9ZtQjkJs7vG96XxH84MZnoAxReJKxoP3dN?= =?us-ascii?Q?gmmFjA3XhciuiMT9tt4w7N+WbuwFMma49RVIkvsoOujLXJcePewAjeeDriLE?= =?us-ascii?Q?66VrXVvZQnMJjUZ9zh0tt2uuTn+mscmdJWPpfTWUw7/R/fNN0j2DL6U71vyL?= =?us-ascii?Q?i4OwS7h+WSieAoUQbCtEfCemMFjHmxD3wJfxek66zjLT5SHUuv8oXcAT9EOI?= =?us-ascii?Q?dtIjhfpdPCNEmnDwVBbk1CdrTXQ4zFAMvtR+VXat/X/BYpTLs9YKj73BVqT5?= =?us-ascii?Q?T5vXb72FBM1K+m8MzPE9Q3d/jBDVLfnbwebpe+jIX0IcKkyD9FGXA5z1jX0r?= =?us-ascii?Q?5sdUCT7ZButBVsSq7yduhwjx3w2/WEjrt4NMB6MmZvjL1MbbN1jLBpuCwWBV?= =?us-ascii?Q?ZrwZ0pJRREoY+I+YjEz5ArV9/kthPE5HJ+A4nPnPaHqmQ8y1tbC8phUDo+vD?= =?us-ascii?Q?5A=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: PQZW6cQwzH3pv9oEp1Ljk5EQ0wIrn1k/35wqkkfQicmWxGYKJsK0QDFDy7mfyE6fiaDJKn1El/vm/l/4vo/djml3HdDfmjJqpURMy2pt1scQaQKQ0JAgr+yAA1eUxS2b52skdngzbFGpa/xHMJYkL1NCiJUVZqYUG7agSmSc0NOoPLz7KXNm1cExwhYlvcr1ywGlZkklc5//3ur2qrAxokAlzz1TaPMXtRoQjlUmpQtONr7RZ06dtu9rEJUJ0ijrn+5nbLklrKraGGbfLcTg1qzQNRzeocxuMEArnq99OAErofJNbchLQtZ5aGhAbzU8z7AfcEO/b/4nqsmzU77L/GJj6sRh4L+6UECEi3Ptcs9DMmFF+PmgheId944sC3LfOQcAyuzHw7rcQdEPEBiiatZhZb+qoqtZHwPRra7LXQcl2CuFuM5JyIa6zjroIAbmgE0ZNZRfnPChdWcUJjAw8CRgdM9Wv1pJgNEOY3MuKMtQLtZnE+LNdkagXQpkbI/nKwHg3AC1vVFv2t1/nhh11eC2iJGfODrLzeNAtU9u996Ciz7qK83h9gaszxJERmMCfqoJq2v5st90qFIOG8gNZMZZOdUk1YxcwSmElEscJ7sIKiyfX97EVoL/v0Y3ZxSDSG+yXS/ejUhotazDViXWrgNqAz5cS5vb5c8kgArUZNF4pcWe0K929AMzP+cTbiDRQTS+AcO2XbLpp9yyMn0OVGvcaM5vwVTtXc/yk2ozP9pRftWRtrsQyW3YLFTiNPnxct91g8xytk3IXHTEfK1qFRuN4BLBn56ViBl7aebfbrk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32a5c6de-7262-4b2d-dfab-08dbcf1fcb84 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 14:46:07.1262 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ihefHhazjdspm5d42FzGmcVK+tX86GyBfdijSb/vbWKV+BQkKGnGnKU50elGHqvdBZSNtEfEZfCePG16bFCiIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR10MB7468 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-17_03,2023-10-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=973 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310170125 X-Proofpoint-GUID: GJNy32THq7RiAUKdCLYmK7AGOAWgsYoB X-Proofpoint-ORIG-GUID: GJNy32THq7RiAUKdCLYmK7AGOAWgsYoB X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16 Oct 2023, Torbjorn SVENSSON told this: > On 2023-10-15 21:18, Nick Alcock wrote: >>>> + if (ctf_member_info (fp, stype, "bar", &mi) < 0) >>>> + fprintf (stderr, "cannot get member info: %s\n", ctf_errmsg (ctf_errno (fp))); >>>> + >>>> + /* Iteration should never produce an offset bigger than the offset just returned, >>>> + and should quickly terminate. */ >>>> + >>>> + while ((ret = ctf_member_next (fp, stype, &i, NULL, NULL, 0)) >= 0) { >>>> + if (ret > mi.ctm_offset) >>>> + fprintf (stderr, "ssize_t return: unexpected offset: %zi\n", ret); >> (here.) > > Ah, okay. In any case, I think it would be clearer if you get all the lines in one go that fails than just the first one (in case of > multiple failures...). - But, that's only my 2 cents. We do that for failures that actually relate to what's being tested, but these lines are only setup, and each depends on the one before: if any fail, all the ones after it are certain to. I think I might change it to not do the actual tests if we can't do the setup, though! I'll give v8 a quick sanity check: more in about an hour. -- NULL && (void)