From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 5EE203858D20 for ; Wed, 13 Sep 2023 18:37:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5EE203858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38DHFq5o005559; Wed, 13 Sep 2023 18:37:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : content-type : content-transfer-encoding : mime-version; s=corp-2023-03-30; bh=mfB8qCrHvZe5LrQzo/sJwIzI9RAm/Jv4y4tEbLQ5F2A=; b=vEJ6+PbTI0yVFRq0vR7b0pj6dCd/VOMTWUe5uE6ezutlz/KVi/Mdvz0jo780WPvlJlNG af6BWUSxWzcReDmN+oFRIcLbUCWbRa23wTbcfLlaeni8hBeYJlJCopOPbPgPSvuBVyzB DCy3HUzPERaixNZU4T2Q6i9gjvf2CDH7JPNBEgLW+PGlx+IRdqbOzeuvidCHlMkUC6Qi t+IfvuYSnygaMlPbIehP+k23oRwuycWgYF+ZxvG8T/Sqx9UayXPFd3CQ+BboQz6FbTNQ eDK8Gx2dxLojsPIR0IYsWS7c3f2t+BLykRhU1Be5tdVGGduPycJ5AAS6AXhNWlOh+5wU 3w== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3t2y9ktv1w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Sep 2023 18:37:27 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 38DHuUku007580; Wed, 13 Sep 2023 18:37:26 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2100.outbound.protection.outlook.com [104.47.55.100]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3t0f57nacv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Sep 2023 18:37:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WwvCs6sIi7Aoy8RxpqRc9JPcstDDvJ8CA+bKi8tG+Mhc9vqc10Vjrlf/RqHrpncGVA1x5KRZ3ymx4/mHtQ9ObOd5+yIuJIPgI29kjmjONMk4xerGOwer1gBeN8eaJBkqypN4HNc9o8UG3I99rApvvIgaf0P0uD9HKpdU0yqvf89H/giDgAqQi3lIYZT5Zvg76O9Yx7G+KncktiVVrA0cq1NIaLibBHuxwb0rhTnutPZTA5ZezjarYlCIOdBC7AP3r3JhlMX0Z9WUKk2WN/1DbGJi8QgoLQ17xeuw7skqeqtIFUIVwLCmi81sYRaY7RfWz2x6qflco0iYBLZr/J581Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mfB8qCrHvZe5LrQzo/sJwIzI9RAm/Jv4y4tEbLQ5F2A=; b=Rdi5KEJkdISW6XWzvKwoWrRB27UWc+eMLc4Z2fnjjKXtmo4YzpYH+Yicz1C+el2y/gR8Xq1GlkyozZpfAOTiKLc00cB/zOpQfTaUdg4PghxsX25EFTIGN0IOH1WOyulOfwtRb5Po/vrJjLyLv6BMr49DyVND2cI8dyG6wtFS3RYxSdOuhVLL11KK5ZQhC1EX8hywtrU6Afs4aNHffYlwLxECjw1r/wbxCYw2oVAFGTm7bJ7+q7Iq95NF3a1jUOKnVgpnyNCYKp9fLlLds1zQNk6qS/GX2neLBOuCaHLVw7d5l+AYji6ga2yAje7r1J8Gl5LTfe+WlJsUtd/s2j+YTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mfB8qCrHvZe5LrQzo/sJwIzI9RAm/Jv4y4tEbLQ5F2A=; b=Un6DK/V8j0wCkxpgei82zuYdq7FcXBO1K+0gNwFS20x5eNCI5OfF92MGNxu5SNH4afbLUAz++fTIO0Au/ygrZ4B0hZfkEswaRoOcg8TrvOKOzZBYaQpdCIVdAg50wX3prYtb6O36aDCrjMi+TwTYCCXdz5kHAbB5lza9wgOkvkQ= Received: from DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) by SJ0PR10MB4621.namprd10.prod.outlook.com (2603:10b6:a03:2d1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19; Wed, 13 Sep 2023 18:37:24 +0000 Received: from DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::63e3:4634:f484:efc6]) by DS0PR10MB6798.namprd10.prod.outlook.com ([fe80::63e3:4634:f484:efc6%3]) with mapi id 15.20.6768.029; Wed, 13 Sep 2023 18:37:24 +0000 From: Nick Alcock To: =?utf-8?Q?Torbj=C3=B6rn?= SVENSSON Cc: , , , Yvan ROUX Subject: Re: [PATCH v3] libctf: ctf_member_next needs to return (ssize_t)-1 on error References: <878r9ba2sf.fsf@esperi.org.uk> <20230913095727.1420654-1-torbjorn.svensson@foss.st.com> Emacs: the only text editor known to get indigestion. Date: Wed, 13 Sep 2023 19:37:16 +0100 In-Reply-To: <20230913095727.1420654-1-torbjorn.svensson@foss.st.com> (=?utf-8?Q?=22Torbj=C3=B6rn?= SVENSSON"'s message of "Wed, 13 Sep 2023 11:57:29 +0200") Message-ID: <87a5tp2a3n.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0292.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::9) To DS0PR10MB6798.namprd10.prod.outlook.com (2603:10b6:8:13c::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB6798:EE_|SJ0PR10MB4621:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a0c16dd-afac-421e-c593-08dbb48878ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pmltcAsUOTaVfhN+I9MFMlSbQ+Xl9kj2ucyapBV1qtt9elW6fJPnt7T0a+jgEzVr2kKwZsPXlpke8rHnEbQ6e0WsItEMxNDfVg+tQ0j89PqxchVPjQJJKlxbhTbjX5Y8RLcrxwDQa8MyNYqg8PVCMsNdaxDyKWzWlFIQ4/63L3TDQY1bBn3TCoW8v01mw6ohgFCCisktRsLskm9W6uI820Q0J5LsB/JvzIKRBpbShAa8Xr9HEmaQ9jhR2BbBmDL1S6R5/Ei5Mkeb4lrH3B5lbNU7rc02G9bE6TWDDVrWATN7WcvV+lRwm3mfhtPviI/KWvqVKAmzOxIvUFfMLe2Awbez1QNQ46Yo1nBAniMzFhR5Ma45B/15REqzolF8rJKRhG8k1WJkxO1D9xJQDP8KztSU5zOJohcRxgSo2uVtUAROb8nZlXLl/k4Xh9q0/BybWU9pQI2kX6WBqrlVwy91jk/+HnqZLt5q0BgmuFjMce6KktSmMhVNxdUPigfS5YcPsyJDQlgL+ow5XiHiXKlxvo7kxAI3UfG1wSUx0j8NWbEjrQjA7Qy/K0xufRAhHKD8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB6798.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(396003)(366004)(376002)(39860400002)(346002)(451199024)(186009)(1800799009)(6916009)(316002)(54906003)(6666004)(66476007)(66946007)(66556008)(44832011)(478600001)(9686003)(6512007)(6486002)(6506007)(41300700001)(8936002)(8676002)(4326008)(5660300002)(36756003)(38100700002)(2906002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWhoZ3VBU01XR0o2d2xDcGNEQ0YxaDBLYVo3VmNOVnpoTERHQzIwd1FtbXVu?= =?utf-8?B?Q3V5UXlZb3RpV2s5UzBpQ3NHN0NSb0VwYnNrRUVqUFM0UUIwUlB2V0hrQWVK?= =?utf-8?B?YithUzVLNExLM3d2U1ZTNm8rOUJwRmJlaDlPVnp3clhKR1BJYzFlc1FtalJ6?= =?utf-8?B?ajY0VWMrNVpuYi9UZFNjNmp0UEFIcjZvR0RYTjNUV0NDeVY5VU92SGgvU1lB?= =?utf-8?B?YmEvcFJSOTdKRE94T1RBTWJ0bkc5U0c2WlBscjZ3cFhLL0tFMGVVU25oaHFC?= =?utf-8?B?MlY4SnRVMFFHeHZTeE1wOW44WENvKzV0TkJiU2ZnSXJVb3lTbmlpVlhnRkgv?= =?utf-8?B?YWFCbE1WS1BBV0lpNkJsdkM5NnYxMmo3K21oUVk4eFhZaTBJVDlZT3BhWnZM?= =?utf-8?B?MWhLMDhybXlPTHdqbWtBd3ozTWN2QVpIdlBlazZVUDY3SzFMVUhBTjEvWjF0?= =?utf-8?B?U1NxUUhhcG0wK3E4R1RTaGV6T0drUnA0bE5UbFBhazFmVndPV2hEaEh3em9C?= =?utf-8?B?NG9MSWJaSmFwTFdEMkJxbGtEL3FnN2xwakJGaUs5cGtkU29OL0pIOTM2TG8z?= =?utf-8?B?Qzl5OTJSRHQ4Y1g4Ni9IWGc5R0ZSRGVvbHoxRTgvaWk2Q0crTW90YzQvcFRu?= =?utf-8?B?dTg3U0FVeGk3MDJqQ0srOFZxQUpaZHg4OElXMlVQRkRGZFAxdVdqWm9rMVFK?= =?utf-8?B?cjQ3MU0rbkk3RlpQMEgyNFVsNy9IV1hwSHdYOWZ1K3FqRGI4aW83QURJZkl1?= =?utf-8?B?em9NTDJXWHNOV2NWSE51UDJFNjJiUHlncHVRRVZFN3pKTDQrZWdYYlUzK2xF?= =?utf-8?B?bVU5ZVJEZldYUkdzNlU2VTBBbzMyRnRJd1dWMlVpOFJGS2hWMWF3VjFQN3Ns?= =?utf-8?B?SDRUQVZEK0pNYXQwYUNVWEk3aHAwYzZCUEVMbHdJb1BLeS9lTkdvOGVRdUFx?= =?utf-8?B?NkxCRUt3VDVYeVpNYkVhRDJjLzl1WUR6cTlKUnZ1WFkyTW1iNkRlaE1qem4z?= =?utf-8?B?eHYwSGRTa3cwSzhrRnd5ejZFTkppa3VFNnl2RUJyUDBaVzFuM253TnRFQjZI?= =?utf-8?B?b1ppc3FWVjBmYTN1MWtkb2lyRURaRXoyRU1ablhWV0hUbFEwTHVjcVR5bEVM?= =?utf-8?B?c1NpY0lvb2pDcWhHRGxaa2R6Yjl1Y0IxVnJ3Vis1WGoyWCtwNmJ1Qk1YTU1n?= =?utf-8?B?cGtqOGVoQnJBS0kyUFNLWlArOHNSRktJTWxNVVVYVmNrRFBsZ3FNZmQrYkZ2?= =?utf-8?B?dGxjTHhhNzZwdk8yR0Jac09vd3cvdmp5SlFkaTU1cExxeUVLR1JSWVNSYnRW?= =?utf-8?B?M2EvSDFMRDhhdzQ1ckYycTJHbUlOZmdxa1dTWEpjbitnUkhrOUlDYnRQRkp5?= =?utf-8?B?U2Z5NCswR3lxWjVRc1R4TEZPUk9NdnB1NVJ2dVZiY0l6NzYxZ3hnRFdZQVJk?= =?utf-8?B?NTNKUVlzSXFEQ3M1M01kMTNHdXc4cHByM0dKdkhnUHN5Z1lwQW5xZWJ0YlZz?= =?utf-8?B?ZXp3MG11SWh0RFFhd1VzdFhsYW40K2FNbGZZWW5FdjRTS2g3cmpvMUpLT0Zu?= =?utf-8?B?M1JkTlc1WlEvMGJZOHlocXZFT1hHWGJOOXF3aWQ2VjBCS2FQaWg1MU9ZQUlt?= =?utf-8?B?Z3BNWnhNbU9NNko2aWhtY0RqemRJa0FkSEI5ZmRSZ0JWd25LUHluaU9QTEtl?= =?utf-8?B?RUd5SUNCL29UdmhLUE91dUkvVUwxNXAxVittdE4rMm0wbGhBaHZ0aGdTcnh4?= =?utf-8?B?WGRJeFFtV3RZdEc2L1d2WHZ0QlhuM25UaGtjT0hWNVZqbktnN2VlYzRQRk9S?= =?utf-8?B?NHUwaFMzU0lPUW1XVVM1Y25lZEFYdFM5aGNEb0QwMlR3ck9hY25ia0tFYVlH?= =?utf-8?B?blptRC9uYU16MzQyM3FhOWd4Lzl3TkdNTzVSNkMwd1lVUzZDTVhzMU9RRVcv?= =?utf-8?B?akZGejIzd1NNSU15KytESGQxMGI3b1lRMUJhYlpVTGNkVG5xSzA0VEV2OVFI?= =?utf-8?B?TWtJd0kvT3h6TEtNZzQreHlSaEdTQ2p0N0dhN2NSUTNDdkFCcmNOQTFFU2hk?= =?utf-8?B?NFhlRjdkN1drcEl5d2lPMGhwazhIbGg2SGJIN2EySFdqbnpmUWRJbGdJZ0t1?= =?utf-8?B?NmdBT2lSL0d3dUU3NlQzK3JzUll3clhrbVQ0U1hkOG5TUDhyK2tMemE1c3U3?= =?utf-8?B?OFE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2tpgzAunDKYk/fb/Tz8liEiZ3TSffV3J9s8gmhl3r40Z5gqTv3gXOZc5y67RDCLtQnsYUqdGtNwGlwADzKKjlwfcm3AegAtLlwlw/vtKSMqrCJ6H++hw/nAbxVtcs9y20whcp87ZSxLZlzGhwsTawt0vTHkDNXhTZStVIAR8bg9tC89AD420IyKQNNAou0z2LwaBwGPUPgL68/EVS2TzmohIEgt8iZNBwO8vTHOBitOqMMhLjVz1h+/Lb/mMQ0Tr8pgvw2HVBF7pvaw1hkXOwm+6lftercBUKT5hWD6T4dS5/bUAZrP66IVKQI4odF64SUtcuk4XXuJVlTSyXNJzdRrY/A2ENNc/WJD/ezDEwNJjcg/AGwRsR+zaWvya3V6HELiidp8vhONnZLQ2MWujqgLYs4kpuiPwycAuG8ItY77C8VvXRhd/2VCD5aw5sWWEerGdWNnWN4Nq2iQihr8V4ZxPPlzb+M7IBNgyIQgDomi7Mo2FfmxGpR7mJT+hxsA2CX5AiN1D5qjgQeQUmertinyW5YFcSOPfGaWMhRfC54js8FsKLI1VhbwF948yYhkFEcF6H91CTHkgcrciV4PBX41bEXhcd9xNxeJ8Yk0tXmrAQHdSk21der+aqsxQEYLtOy84TnmR8HsboWZqZlxPUlMpTKYxFhaxCqn8DyXt1/C47c18i7XNE3ua08cUVxda270X8dQ0xzpbeM5jj91xg4erzsvtmixM/a38Dn7uoYu5l8Ydzlil2VJAQTgtOXr4Jzf1jzW4M0AQZich/6mgBj3tCYkkt8aJYX2uy4BzbWTsHizeHc8ZOy+1gT4vJRQt X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a0c16dd-afac-421e-c593-08dbb48878ef X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 18:37:24.3483 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MLLSeRcAdWj9PV7tTeVaji09DNlGlk1WHIz0XqNDZ/224fFzxIh2qbZRSqFOlA9F04a5kpGHJ32I12n7sl/Lkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4621 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-13_13,2023-09-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxscore=0 mlxlogscore=967 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309130156 X-Proofpoint-GUID: Fb-NdZSqOQyqvZMXnWDePiIU8k5ejFK1 X-Proofpoint-ORIG-GUID: Fb-NdZSqOQyqvZMXnWDePiIU8k5ejFK1 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 13 Sep 2023, Torbj=C3=B6rn SVENSSON verbalised: > v1 -> v2: > Changed all functions with signed interger return type to return -1 based= on > comment from Alan. > > v2 -> v3: > Added ctf_set_errno_signed function to return a signed -1 value based on > comment from Nick. > > Ok for trunk? If this touches exactly those functions that return int, and fixes the reported bug, it's good as far as I'm concerned, except for a couple of possible comment improvements: > +/* Store the specified error code into the CTF dict, and then return -1 > + (CTF_ERR) for the benefit of the caller. */ It's not CTF_ERR in this case, it's just -1. Perhaps: /* Store the specified error code into the CTF dict, and then return -1 for the benefit of the caller, which is expected to return int, as opposed to ctf_id_t. */ > +int > +ctf_set_errno_signed (ctf_dict_t *fp, int err) > +{ > + fp->ctf_errno =3D err; > + /* Don't rely on CTF_ERR here as it will not properly sign extend on 6= 4-bit > + Windows ABI. */ > + return -1; > +} ... that Windows is not really the problem here. It's more /* Don't rely on CTF_ERR here; it is a ctf_id_t (unsigned long), and it will be truncated to a non--1 value on platforms on which int and unsigned long are different sizes. */ perhaps? (At least, I think that's what's going on.) This probably needs testing on a wide variety of platforms with different type sizes. I'll add throwing this through my entire test matrix to my todo list, and fix any bugs observed: but the basic idea looks sound to me. --=20 NULL && (void)