From: Nick Clifton <nickc@redhat.com>
To: binutils@sourceware.org
Subject: Commit: elfxx-loongarch64.c: Fix printf formatting issues.
Date: Wed, 31 May 2023 10:21:03 +0100 [thread overview]
Message-ID: <87a5xkua9s.fsf@redhat.com> (raw)
Hi Guys,
I am applying the patch below to add some casts to the
elfxx-loongarch64.c file where it prints vma values as
if they were longs. Whilst this usually works, on a
32-bit host (or a 64-bit host, compiling in 32-bit mode)
it produces a compile-time warning about the bfd_vma type
not fiting the %lx format specifier.
Cheers
Nick
diff --git a/bfd/elfxx-loongarch.c b/bfd/elfxx-loongarch.c
index 9cfbef1431f..ac644fff2f6 100644
--- a/bfd/elfxx-loongarch.c
+++ b/bfd/elfxx-loongarch.c
@@ -1669,7 +1669,7 @@ reloc_bits_pcrel20_s2 (bfd *abfd, reloc_howto_type *howto, bfd_vma *fix_val)
&& (val & ((((bfd_signed_vma) 1) << howto->rightshift) - 1)))
{
(*_bfd_error_handler) (_("%pB: relocation %s right shift %d error 0x%lx"),
- abfd, howto->name, howto->rightshift, val);
+ abfd, howto->name, howto->rightshift, (long) val);
bfd_set_error (bfd_error_bad_value);
return false;
}
@@ -1679,7 +1679,7 @@ reloc_bits_pcrel20_s2 (bfd *abfd, reloc_howto_type *howto, bfd_vma *fix_val)
if ((val & ~mask) && ((val & ~mask) != ~mask))
{
(*_bfd_error_handler) (_("%pB: relocation %s overflow 0x%lx"),
- abfd, howto->name, val);
+ abfd, howto->name, (long) val);
bfd_set_error (bfd_error_bad_value);
return false;
}
@@ -1715,7 +1715,7 @@ reloc_bits_b16 (bfd *abfd, reloc_howto_type *howto, bfd_vma *fix_val)
if ((val & ~mask) && ((val & ~mask) != ~mask))
{
(*_bfd_error_handler) (_("%pB: relocation %s overflow 0x%lx"),
- abfd, howto->name, val);
+ abfd, howto->name, (long) val);
bfd_set_error (bfd_error_bad_value);
return false;
}
@@ -1750,7 +1750,7 @@ reloc_bits_b21 (bfd *abfd, reloc_howto_type *howto, bfd_vma *fix_val)
if ((val & ~mask) && ((val & ~mask) != ~mask))
{
(*_bfd_error_handler) (_("%pB: relocation %s overflow 0x%lx"),
- abfd, howto->name, val);
+ abfd, howto->name, (long) val);
bfd_set_error (bfd_error_bad_value);
return false;
}
@@ -1787,7 +1787,7 @@ reloc_bits_b26 (bfd *abfd, reloc_howto_type *howto, bfd_vma *fix_val)
if ((val & ~mask) && ((val & ~mask) != ~mask))
{
(*_bfd_error_handler) (_("%pB: relocation %s overflow 0x%lx"),
- abfd, howto->name, val);
+ abfd, howto->name, (long) val);
bfd_set_error (bfd_error_bad_value);
return false;
}
reply other threads:[~2023-05-31 9:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5xkua9s.fsf@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).