From: Andreas Schwab <schwab@linux-m68k.org>
To: Cary Coutant via Binutils <binutils@sourceware.org>
Cc: Vladislav Khmelevsky <och95@yandex.ru>,
Cary Coutant <ccoutant@gmail.com>
Subject: Re: [PATCH] gold/aarch64: Fix adrp distance check
Date: Fri, 29 Jul 2022 22:44:06 +0200 [thread overview]
Message-ID: <87a68r8x9l.fsf@igel.home> (raw)
In-Reply-To: <CAJimCsFaZnnHW9v6i4DgQxf_P7j5SUOJmp5i42AWwMXau5uVKw@mail.gmail.com> (Cary Coutant via Binutils's message of "Fri, 29 Jul 2022 13:14:08 -0700")
On Jul 29 2022, Cary Coutant via Binutils wrote:
> The cast is unnecessary here for assignment to an int64_t. Once the
> result is in a signed int, I don't think you need to go to all that
> extra trouble to shift it.
Note that right shifting a negative value is fully defined only in C++20
and later.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-07-29 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-25 17:52 Vladislav Khmelevsky
2022-07-29 20:14 ` Cary Coutant
2022-07-29 20:44 ` Andreas Schwab [this message]
2022-07-29 22:14 ` Cary Coutant
2022-08-08 19:18 ` Vladislav Khmelevsky
2022-11-07 11:28 Vladislav Khmelevsky
2022-11-11 0:49 ` Cary Coutant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a68r8x9l.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=binutils@sourceware.org \
--cc=ccoutant@gmail.com \
--cc=och95@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).