Convert include/ to ISO C90?

Convert include/ to ISO C90?

[Andreas Jaeger]

Since binutils, gdb and GCC are all moving to ISO C90, I have a
question about the shared include directory: Do we convert this also
to ISO C90?

Or will libiberty always stay K&R so that we really have to
differentiate for include files who uses them?

I'm appending a first patch for GCC (which then will find it's way
into the src directory).

Ok to commit?  Are similar patches ok for include/?  

Andreas

2003-06-29  Andreas Jaeger  <aj@suse.de>

	* ternary.h: Convert to ISO C90 prototypes, use void * instead of
	PTR.

============================================================
Index: include/ternary.h
--- include/ternary.h	8 May 2001 06:13:58 -0000	1.2
+++ include/ternary.h	29 Jun 2003 10:33:45 -0000
@@ -1,5 +1,5 @@
 /* ternary.h - Ternary Search Trees
-   Copyright 2001 Free Software Foundation, Inc.
+   Copyright 2001, 2003 Free Software Foundation, Inc.
 
    Contributed by Daniel Berlin (dan@cgsoftware.com)
 
@@ -38,14 +38,13 @@ ternary_node;
    already there, and replace is 0.
    Otherwise, replaces if it it exists, inserts if it doesn't, and
    returns the data you passed in. */
-PTR ternary_insert PARAMS ((ternary_tree *p, const char *s,
-			    PTR data, int replace));
+PTR ternary_insert (ternary_tree *p, const char *s, void *data, int replace);
 
 /* Delete the ternary search tree rooted at P. 
    Does NOT delete the data you associated with the strings. */
-void ternary_cleanup PARAMS ((ternary_tree p));
+void ternary_cleanup (ternary_tree p);
 
 /* Search the ternary tree for string S, returning the data associated
    with it if found. */
-PTR ternary_search PARAMS ((const ternary_node *p, const char *s));
+PTR ternary_search (const ternary_node *p, const char *s);
 #endif

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Re: Convert include/ to ISO C90?

[DJ Delorie]

> Since binutils, gdb and GCC are all moving to ISO C90, I have a
> question about the shared include directory: Do we convert this also
> to ISO C90?
> 
> Or will libiberty always stay K&R so that we really have to
> differentiate for include files who uses them?

Libiberty must stay K&R until *everything* that uses it has completed
its switch.  The projects you list are not the complete list.  So,
it's OK to change include/ files that only show up in src, but please
do not change any of the files that show up in gcc.

Re: Convert include/ to ISO C90?

[Andreas Jaeger]

DJ Delorie <dj@delorie.com> writes:

>> Since binutils, gdb and GCC are all moving to ISO C90, I have a
>> question about the shared include directory: Do we convert this also
>> to ISO C90?
>> 
>> Or will libiberty always stay K&R so that we really have to
>> differentiate for include files who uses them?
>
> Libiberty must stay K&R until *everything* that uses it has completed
> its switch.  The projects you list are not the complete list.  So,
> it's OK to change include/ files that only show up in src, but please
> do not change any of the files that show up in gcc.

Ok, so let's postpone it.

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Deutschherrnstr. 15-19, 90429 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Re: Convert include/ to ISO C90?

[Zack Weinberg]

Andreas Jaeger <aj@suse.de> writes:

> Since binutils, gdb and GCC are all moving to ISO C90, I have a
> question about the shared include directory: Do we convert this also
> to ISO C90?

DJ has already addressed the question of when this can happen; I would
only like to point out that when it does, *all* appearances of PTR
should go away.  You changed the argument lists, but not the return
types.

zw