* [PATCH toplevel] libctf: new testsuite
@ 2021-01-05 15:25 Nick Alcock
2021-01-05 22:53 ` Alan Modra
0 siblings, 1 reply; 4+ messages in thread
From: Nick Alcock @ 2021-01-05 15:25 UTC (permalink / raw)
To: gdb-patches, gcc-patches, binutils
This enables 'make libctf-check', used by a new libctf testsuite in
binutils.
2021-01-05 Nick Alcock <nick.alcock@oracle.com>
* Makefile.def (libctf): No longer no_check. Checking depends on
all-ld.
* Makefile.in: Regenerated.
---
Makefile.def | 4 +-
Makefile.in | 13 +
This is a stripped-down top-level-only subset of commit
c59e30ed1727135f8efb79890f2c458f73709757 in binutils-gdb.git. (Because
it is identical to what has already landed in binutils, it should apply
without trouble in syncs back to there.)
I don't have permission to push this: Alan has offered to do so.
(I hope I'm doing this right...)
diff --git a/Makefile.def b/Makefile.def
index 089e70ae3ed..cc429aa8628 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -131,8 +131,7 @@ host_modules= { module= lto-plugin; bootstrap=true;
extra_make_flags='@extra_linker_plugin_flags@'; };
host_modules= { module= libcc1; extra_configure_flags=--enable-shared; };
host_modules= { module= gotools; };
-host_modules= { module= libctf; no_check=true;
- bootstrap=true; };
+host_modules= { module= libctf; bootstrap=true; };
target_modules = { module= libstdc++-v3;
bootstrap=true;
@@ -547,6 +546,7 @@ dependencies = { module=configure-libctf; on=all-bfd; };
dependencies = { module=configure-libctf; on=all-intl; };
dependencies = { module=configure-libctf; on=all-zlib; };
dependencies = { module=configure-libctf; on=all-libiconv; };
+dependencies = { module=check-libctf; on=all-ld; };
// The Makefiles in gdb and gdbserver pull in a file that configure
// generates in the gnulib directory, so distclean gnulib only after
diff --git a/Makefile.in b/Makefile.in
index fe34132f9e5..4fe7321786e 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -34761,6 +34761,12 @@ maybe-check-libctf:
maybe-check-libctf: check-libctf
check-libctf:
+ @: $(MAKE); $(unstage)
+ @r=`${PWD_COMMAND}`; export r; \
+ s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
+ $(HOST_EXPORTS) $(EXTRA_HOST_EXPORTS) \
+ (cd $(HOST_SUBDIR)/libctf && \
+ $(MAKE) $(FLAGS_TO_PASS) $(EXTRA_BOOTSTRAP_FLAGS) check)
@endif libctf
@@ -52366,6 +52372,13 @@ configure-stage3-libctf: maybe-all-stage3-libiconv
configure-stage4-libctf: maybe-all-stage4-libiconv
configure-stageprofile-libctf: maybe-all-stageprofile-libiconv
configure-stagefeedback-libctf: maybe-all-stagefeedback-libiconv
+check-libctf: maybe-all-ld
+check-stage1-libctf: maybe-all-stage1-ld
+check-stage2-libctf: maybe-all-stage2-ld
+check-stage3-libctf: maybe-all-stage3-ld
+check-stage4-libctf: maybe-all-stage4-ld
+check-stageprofile-libctf: maybe-all-stageprofile-ld
+check-stagefeedback-libctf: maybe-all-stagefeedback-ld
distclean-gnulib: maybe-distclean-gdb
distclean-gnulib: maybe-distclean-gdbserver
all-bison: maybe-all-build-texinfo
--
2.29.2.250.g8336e49d6f.dirty
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH toplevel] libctf: new testsuite
2021-01-05 15:25 [PATCH toplevel] libctf: new testsuite Nick Alcock
@ 2021-01-05 22:53 ` Alan Modra
2021-01-06 11:48 ` Nick Alcock
2021-01-06 13:18 ` [PATCH v2 toplevel] sync libctf toplevel from binutils-gdb Nick Alcock
0 siblings, 2 replies; 4+ messages in thread
From: Alan Modra @ 2021-01-05 22:53 UTC (permalink / raw)
To: Nick Alcock; +Cc: gdb-patches, gcc-patches, binutils
On Tue, Jan 05, 2021 at 03:25:10PM +0000, Nick Alcock wrote:
> This enables 'make libctf-check', used by a new libctf testsuite in
> binutils.
>
> 2021-01-05 Nick Alcock <nick.alcock@oracle.com>
>
> * Makefile.def (libctf): No longer no_check. Checking depends on
> all-ld.
> * Makefile.in: Regenerated.
>
> ---
>
> Makefile.def | 4 +-
> Makefile.in | 13 +
>
> This is a stripped-down top-level-only subset of commit
> c59e30ed1727135f8efb79890f2c458f73709757 in binutils-gdb.git. (Because
> it is identical to what has already landed in binutils, it should apply
> without trouble in syncs back to there.)
>
> I don't have permission to push this: Alan has offered to do so.
It doesn't apply due to gcc missing binutils 87279e3cef5b2c5 changes
too. I could fix that easily enough but I'm going to ask that you
post a combined patch to bring the gcc repo up to date with any libctf
changes.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH toplevel] libctf: new testsuite
2021-01-05 22:53 ` Alan Modra
@ 2021-01-06 11:48 ` Nick Alcock
2021-01-06 13:18 ` [PATCH v2 toplevel] sync libctf toplevel from binutils-gdb Nick Alcock
1 sibling, 0 replies; 4+ messages in thread
From: Nick Alcock @ 2021-01-06 11:48 UTC (permalink / raw)
To: Alan Modra via Binutils; +Cc: Alan Modra, gcc-patches, gdb-patches
On 5 Jan 2021, Alan Modra via Binutils told this:
> It doesn't apply due to gcc missing binutils 87279e3cef5b2c5 changes
> too. I could fix that easily enough but I'm going to ask that you
> post a combined patch to bring the gcc repo up to date with any libctf
> changes.
Oops! That never occurred to me, but of course all the earlier stuff is
probably missing too. Will come up with one once I've properly woken up.
(Sorry, I really should have tried to apply it :( )
--
NULL && (void)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 toplevel] sync libctf toplevel from binutils-gdb
2021-01-05 22:53 ` Alan Modra
2021-01-06 11:48 ` Nick Alcock
@ 2021-01-06 13:18 ` Nick Alcock
1 sibling, 0 replies; 4+ messages in thread
From: Nick Alcock @ 2021-01-06 13:18 UTC (permalink / raw)
To: gdb-patches, gcc-patches, binutils
This pulls in the toplevel portions of these binutils-gdb commits:
1ff6de031241c59d0ff bfd, ld: add CTF section linking
87279e3cef5b2c54f4a libctf: installable libctf as a shared library
c59e30ed1727135f8ef libctf: new testsuite
* Makefile.def: Sync with binutils-gdb:
(dependencies): all-ld depends on all-libctf.
(host_modules): libctf is no longer no_install.
No longer no_check. Checking depends on all-ld.
* Makefile.in: Regenerated.
---
ChangeLog | 8 ++++++++
Makefile.def | 5 +++--
Makefile.in | 42 ++++++++++++++++++++++++++++++++++++++++--
3 files changed, 51 insertions(+), 4 deletions(-)
This should be a little better (though I only had three hours sleep last
night so it's quite possible I messed it up again).
I reviewed the diff with GCC and nothing more libctf-related is missing.
This was generated against GCC trunk directly so should definitely apply
this time. Sorry about that.
diff --git a/ChangeLog b/ChangeLog
index bd87d5fc6ee..0a352870cd6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2021-01-06 Nick Alcock <nick.alcock@oracle.com>
+
+ * Makefile.def: Sync with binutils-gdb:
+ (dependencies): all-ld depends on all-libctf.
+ (host_modules): libctf is no longer no_install.
+ No longer no_check. Checking depends on all-ld.
+ * Makefile.in: Regenerated.
+
2021-01-05 Samuel Thibault <samuel.thibault@ens-lyon.org>
* libtool.m4: Match gnu* along other GNU systems.
diff --git a/Makefile.def b/Makefile.def
index c45be5bff45..3e38f61193f 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -141,8 +141,7 @@ host_modules= { module= lto-plugin; bootstrap=true;
extra_make_flags='@extra_linker_plugin_flags@'; };
host_modules= { module= libcc1; extra_configure_flags=--enable-shared; };
host_modules= { module= gotools; };
-host_modules= { module= libctf; no_install=true; no_check=true;
- bootstrap=true; };
+host_modules= { module= libctf; bootstrap=true; };
target_modules = { module= libstdc++-v3;
bootstrap=true;
@@ -463,6 +462,7 @@ dependencies = { module=all-binutils; on=all-build-bison; };
dependencies = { module=all-binutils; on=all-intl; };
dependencies = { module=all-binutils; on=all-gas; };
dependencies = { module=all-binutils; on=all-libctf; };
+dependencies = { module=all-ld; on=all-libctf; };
// We put install-opcodes before install-binutils because the installed
// binutils might be on PATH, and they might need the shared opcodes
@@ -561,6 +561,7 @@ dependencies = { module=configure-libctf; on=all-bfd; };
dependencies = { module=configure-libctf; on=all-intl; };
dependencies = { module=configure-libctf; on=all-zlib; };
dependencies = { module=configure-libctf; on=all-libiconv; };
+dependencies = { module=check-libctf; on=all-ld; };
// Warning, these are not well tested.
dependencies = { module=all-bison; on=all-intl; };
diff --git a/Makefile.in b/Makefile.in
index 2307c8dd083..247cb9c8711 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -41747,6 +41747,12 @@ maybe-check-libctf:
maybe-check-libctf: check-libctf
check-libctf:
+ @: $(MAKE); $(unstage)
+ @r=`${PWD_COMMAND}`; export r; \
+ s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
+ $(HOST_EXPORTS) $(EXTRA_HOST_EXPORTS) \
+ (cd $(HOST_SUBDIR)/libctf && \
+ $(MAKE) $(FLAGS_TO_PASS) $(EXTRA_BOOTSTRAP_FLAGS) check)
@endif libctf
@@ -41755,7 +41761,13 @@ maybe-install-libctf:
@if libctf
maybe-install-libctf: install-libctf
-install-libctf:
+install-libctf: installdirs
+ @: $(MAKE); $(unstage)
+ @r=`${PWD_COMMAND}`; export r; \
+ s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
+ $(HOST_EXPORTS) \
+ (cd $(HOST_SUBDIR)/libctf && \
+ $(MAKE) $(FLAGS_TO_PASS) install)
@endif libctf
@@ -41764,7 +41776,13 @@ maybe-install-strip-libctf:
@if libctf
maybe-install-strip-libctf: install-strip-libctf
-install-strip-libctf:
+install-strip-libctf: installdirs
+ @: $(MAKE); $(unstage)
+ @r=`${PWD_COMMAND}`; export r; \
+ s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
+ $(HOST_EXPORTS) \
+ (cd $(HOST_SUBDIR)/libctf && \
+ $(MAKE) $(FLAGS_TO_PASS) install-strip)
@endif libctf
@@ -61206,6 +61224,16 @@ all-stagetrain-binutils: maybe-all-stagetrain-libctf
all-stagefeedback-binutils: maybe-all-stagefeedback-libctf
all-stageautoprofile-binutils: maybe-all-stageautoprofile-libctf
all-stageautofeedback-binutils: maybe-all-stageautofeedback-libctf
+all-ld: maybe-all-libctf
+all-stage1-ld: maybe-all-stage1-libctf
+all-stage2-ld: maybe-all-stage2-libctf
+all-stage3-ld: maybe-all-stage3-libctf
+all-stage4-ld: maybe-all-stage4-libctf
+all-stageprofile-ld: maybe-all-stageprofile-libctf
+all-stagetrain-ld: maybe-all-stagetrain-libctf
+all-stagefeedback-ld: maybe-all-stagefeedback-libctf
+all-stageautoprofile-ld: maybe-all-stageautoprofile-libctf
+all-stageautofeedback-ld: maybe-all-stageautofeedback-libctf
install-binutils: maybe-install-opcodes
install-strip-binutils: maybe-install-strip-opcodes
install-opcodes: maybe-install-bfd
@@ -61566,6 +61594,16 @@ configure-stagetrain-libctf: maybe-all-stagetrain-libiconv
configure-stagefeedback-libctf: maybe-all-stagefeedback-libiconv
configure-stageautoprofile-libctf: maybe-all-stageautoprofile-libiconv
configure-stageautofeedback-libctf: maybe-all-stageautofeedback-libiconv
+check-libctf: maybe-all-ld
+check-stage1-libctf: maybe-all-stage1-ld
+check-stage2-libctf: maybe-all-stage2-ld
+check-stage3-libctf: maybe-all-stage3-ld
+check-stage4-libctf: maybe-all-stage4-ld
+check-stageprofile-libctf: maybe-all-stageprofile-ld
+check-stagetrain-libctf: maybe-all-stagetrain-ld
+check-stagefeedback-libctf: maybe-all-stagefeedback-ld
+check-stageautoprofile-libctf: maybe-all-stageautoprofile-ld
+check-stageautofeedback-libctf: maybe-all-stageautofeedback-ld
all-bison: maybe-all-build-texinfo
all-flex: maybe-all-build-bison
all-flex: maybe-all-m4
--
2.30.0.252.gc27e85e57d
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-06 13:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 15:25 [PATCH toplevel] libctf: new testsuite Nick Alcock
2021-01-05 22:53 ` Alan Modra
2021-01-06 11:48 ` Nick Alcock
2021-01-06 13:18 ` [PATCH v2 toplevel] sync libctf toplevel from binutils-gdb Nick Alcock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).