* New Sparc linker testsuite failures
@ 2017-04-24 10:48 Nick Clifton
2017-04-24 12:39 ` Jose E. Marchesi
0 siblings, 1 reply; 2+ messages in thread
From: Nick Clifton @ 2017-04-24 10:48 UTC (permalink / raw)
To: jose.marchesi; +Cc: binutils
Hi Jose,
I am seeing some new linker testsuite failures for binutils configured
as sparc64-linux-gnu and sparc-linux-gnu:
LD REGRESSION: 64-bit: TLS -fpic -shared transitions
LD REGRESSION: 64-bit: TLS -fpic and -fno-pic
LD REGRESSION: 64-bit: TLS -fno-pic -shared
The cause seems to be obvious:
regexp_diff match failure
regexp "^ +132c: 81 cf e0 08 rett %i7 \+ 8$"
line " 132c: 81 cf e0 08 return %i7 + 8"
FAIL: 64-bit: TLS -fpic -shared transitions
Which I assume is due to this patch:
2017-04-21 Jose E. Marchesi <jose.marchesi@oracle.com>
* sparc-opc.c (sparc_opcodes): Mark RETT instructions as v6notv9.
Would you mind checking that this happens for you, and if so, updating
the linker tests ?
Cheers
Nick
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: New Sparc linker testsuite failures
2017-04-24 10:48 New Sparc linker testsuite failures Nick Clifton
@ 2017-04-24 12:39 ` Jose E. Marchesi
0 siblings, 0 replies; 2+ messages in thread
From: Jose E. Marchesi @ 2017-04-24 12:39 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
Hi Nick. Happy Monday!
I am seeing some new linker testsuite failures for binutils configured
as sparc64-linux-gnu and sparc-linux-gnu:
LD REGRESSION: 64-bit: TLS -fpic -shared transitions
LD REGRESSION: 64-bit: TLS -fpic and -fno-pic
LD REGRESSION: 64-bit: TLS -fno-pic -shared
The cause seems to be obvious:
regexp_diff match failure
regexp "^ +132c: 81 cf e0 08 rett %i7 \+ 8$"
line " 132c: 81 cf e0 08 return %i7 + 8"
FAIL: 64-bit: TLS -fpic -shared transitions
Which I assume is due to this patch:
2017-04-21 Jose E. Marchesi <jose.marchesi@oracle.com>
* sparc-opc.c (sparc_opcodes): Mark RETT instructions as v6notv9.
Would you mind checking that this happens for you, and if so, updating
the linker tests ?
Ouch. I see the regressions here as well... for some reason I didn't
notice them last week. I just applied the patch below. Sorry for the
inconvenience!
---
ld: fix regressions with rett instructions in sparc tests.
A few tests in the ld testsuite were expecting the disassembler to emit
`rett' instructions in V9. This patch updates the tests to expect
`return' instead.
ld/ChangeLog:
2017-04-24 Jose E. Marchesi <jose.marchesi@oracle.com>
* testsuite/ld-sparc/tlssunbin64.dd: Expect `return' instructions
instead of `rett' in V9.
* testsuite/ld-sparc/tlssunnopic64.dd: Likewise.
* testsuite/ld-sparc/tlssunpic64.dd: Likewise.
diff --git a/ld/testsuite/ld-sparc/tlssunbin64.dd b/ld/testsuite/ld-sparc/tlssunbin64.dd
index cd7db1c..bc6b761 100644
--- a/ld/testsuite/ld-sparc/tlssunbin64.dd
+++ b/ld/testsuite/ld-sparc/tlssunbin64.dd
@@ -165,7 +165,7 @@ Disassembly of section .text:
+10125c: 01 00 00 00 nop *
+101260: 01 00 00 00 nop *
+101264: 01 00 00 00 nop *
- +101268: 81 cf e0 08 rett %i7 \+ 8
+ +101268: 81 cf e0 08 return %i7 \+ 8
+10126c: 01 00 00 00 nop *
#...
diff --git a/ld/testsuite/ld-sparc/tlssunnopic64.dd b/ld/testsuite/ld-sparc/tlssunnopic64.dd
index af4918c..cd872f2 100644
--- a/ld/testsuite/ld-sparc/tlssunnopic64.dd
+++ b/ld/testsuite/ld-sparc/tlssunnopic64.dd
@@ -83,6 +83,6 @@ Disassembly of section .text:
+1118: 01 00 00 00 nop *
+111c: 01 00 00 00 nop *
+1120: 01 00 00 00 nop *
- +1124: 81 cf e0 08 rett %i7 \+ 8
+ +1124: 81 cf e0 08 return %i7 \+ 8
+1128: 01 00 00 00 nop *
#pass
diff --git a/ld/testsuite/ld-sparc/tlssunpic64.dd b/ld/testsuite/ld-sparc/tlssunpic64.dd
index 5e94858..00dbc20 100644
--- a/ld/testsuite/ld-sparc/tlssunpic64.dd
+++ b/ld/testsuite/ld-sparc/tlssunpic64.dd
@@ -215,6 +215,6 @@ Disassembly of section .text:
+1320: 01 00 00 00 nop *
+1324: 01 00 00 00 nop *
+1328: 01 00 00 00 nop *
- +132c: 81 cf e0 08 rett %i7 \+ 8
+ +132c: 81 cf e0 08 return %i7 \+ 8
+1330: 01 00 00 00 nop *
#pass
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-24 12:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-24 10:48 New Sparc linker testsuite failures Nick Clifton
2017-04-24 12:39 ` Jose E. Marchesi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).