From: Richard Sandiford <rdsandiford@googlemail.com>
To: "Maciej W. Rozycki" <macro@codesourcery.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] MIPS/GAS: Fix DWARF-2 with branch swapping for MIPS16 code
Date: Sat, 02 Jul 2011 07:33:00 -0000 [thread overview]
Message-ID: <87boxdcf2b.fsf@firetop.home> (raw)
In-Reply-To: <alpine.DEB.1.10.1107020155260.4083@tp.orcam.me.uk> (Maciej W. Rozycki's message of "Sat, 2 Jul 2011 02:20:15 +0100 (BST)")
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
>> - this:
>>
>> > + Advance PC by 16 to 0x5c
>>
>> depends on the target alignment of .text; it passes for GNU/Linux
>> targets but fails on ELF ones. I think we should stub out the
>> exact numbers, since they're incidental to the test.
>
> Hmm, does it? I did verify it both on a GNU/Linux and an ELF target. It
> still passes for me, except that:
>
> + Advance PC by 24 to 0x64
>
> is required instead as with my intended-to-be-sent-originally change.
> Likewise:
>
> + Advance PC by 23 to 0x40
>
> for the MIPS16 dump. Which target is failing for you? Perhaps the cause
> was merely the outdated version of the change, sigh...
Ah, could be. It was mips64-elf. Maybe I'd got confused and the
original didn't pass for GNU/Linux after all. Sorry about that.
> I have regenerated and revalidated the change now and I'm ready to push
> it, but I'd prefer the final DWARF-2 instructions to be matched exactly.
> I made the effort to make the source alignment-agnostic and I'd prefer to
> keep the final offsets to be verified literally so that any unexpected
> discrepancies are caught.
Agreed.
> 2011-07-02 Maciej W. Rozycki <macro@codesourcery.com>
>
> gas/
> * config/tc-mips.c (append_insn): Make sure DWARF-2 location
> information is properly adjusted for branches that get swapped.
>
> gas/testsuite/
> * gas/mips/loc-swap.d: New test case for DWARF-2 location with
> branch swapping.
> * gas/mips/loc-swap-dis.d: Likewise.
> * gas/mips/mips16\@loc-swap.d: Likewise, MIPS16 version.
> * gas/mips/mips16\@loc-swap-dis.d: Likewise.
> * gas/mips/loc-swap.s: Source for the new tests.
> * gas/mips/mips.exp: Run the new tests.
OK.
Richard
next prev parent reply other threads:[~2011-07-02 7:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 13:39 Maciej W. Rozycki
2011-06-29 21:26 ` Richard Sandiford
2011-07-02 1:20 ` Maciej W. Rozycki
2011-07-02 7:33 ` Richard Sandiford [this message]
2011-07-04 20:30 ` Maciej W. Rozycki
2011-07-04 22:20 ` Richard Sandiford
2011-07-05 0:28 ` Maciej W. Rozycki
2011-07-05 11:29 ` Richard Sandiford
2011-08-03 14:55 ` [ping][PATCH] MIPS: Document the use of FP_D in MIPS16 mode Maciej W. Rozycki
2011-08-03 19:47 ` Richard Sandiford
2011-08-03 21:13 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87boxdcf2b.fsf@firetop.home \
--to=rdsandiford@googlemail.com \
--cc=binutils@sourceware.org \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).