Re: [PATCH] Remove unnecessary non-standard & unportable inclusions.

[Sam James <sam@gentoo.org>]

Jan Beulich <jbeulich@suse.com> writes:

> On 01.11.2024 21:26, Jonas 'Sortie' Termansen wrote:
>> <memory.h> is not needed and not standardized and is just an alias for
>> <string.h>.
>
> The question with such #include-s is virtually always: Are they there to
> work around issues on certain platforms (a detail which would imo be
> relevant to put in the patch description)? In the case here the line was
> present from the introduction of the helper tool, so that's hard to
> answer (may want to ask the author though, as it hasn't been _that_ long
> ago that the tool was introduced). On that basis I'd be okay to approve
> that change alone, while ...
>
>> <sys/param.h> is not needed and not standardized and contains a kitchen
>> sink of various unportable definitions not agreed upon and best done
>> manually or through other headers.
>
> ... I guess we will want Nick's input here, whom you didn't even Cc.

While I agree that this is a good idea and that people ought to do it,
projects often don't document that you should, and I don't think we're
an exception.

I don't see it at https://www.gnu.org/software/binutils/ or
https://sourceware.org/binutils/wiki/HowToContribute.

I'll add it to the latter. I dunno how to edit the former. Thanks.