From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id BE33B3858CDA for ; Mon, 5 Feb 2024 17:25:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE33B3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE33B3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::634 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707153920; cv=none; b=D35qxN5wTbcbiat0V/1D0PphY91k6GF2J8BcBwJtpx/iUd8tKqOP8t5DwVNsZauJPxOnGSFQLV8rS0iwBIgd9iLJ0SAiqyAWkoXubzyVZNQNzLlqBZEyPxDsYakJQmvmG+LCJUONkYWe66as9SnmV/HsY+RwHK9pfcFc48ETzdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707153920; c=relaxed/simple; bh=v+Z88RRLyJJLSjNLnXOItrXgUv1ZgWXxmPaXaLFn4nI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kLEbniD9ZLtQlrZiVlJWgNHR1HKsGra+0SG0bwSBF3iDRN0RzJjOpQjO0Y7RVd7ooZt2txgT/uxUtlEjgugBomAmKa7jw3SOQoQo7hHULOUlu1X/6KrP5XdZLnRtRyXFOWrSa+1BJ/RZtQ4qf9L5Iv8IJ48nCcfhxhEt3kokL1U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1d9bd8fa49eso7377295ad.1 for ; Mon, 05 Feb 2024 09:25:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707153916; x=1707758716; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=VZdcDImK99GYg8SIVyVX2gbrIPBFoh/xr38VXSyw5Y0=; b=tWUS6QzOxNjmA5xTp8isBlePKuS0EXUUNdIJYgp94OVEAelsa34h+lrBGqBrOsl1ur Tqg3qhuPV3YIbB1aPbwoD2HQ6ArHf6RuuxiJZO3ivcnLjAL6FekL0HNOqPiDH+qK9EDO LnD+ekukfXgbOcnWnsxJ/YS+FqMi8CszBovywr/b6+qET7eGTc24IFus5OmhEfjcI0XS sXT01fsGj0qerp91pOJjuE7/QIq9A9MpoFVxYa4JeL+U95t/6Telb16TnRnUuoh2Y4fd RqYzemFy+gSnXrf5w0AV4PrMR0RRpEzROalbJECbg/ZXLEh3yLC0uNlrJ5Z2uQwanIkQ IpLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707153916; x=1707758716; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VZdcDImK99GYg8SIVyVX2gbrIPBFoh/xr38VXSyw5Y0=; b=hiC4kC8/lBEh46AB4weqkfF8viIYOu3GDkblP8pNImR6k4BvPXb//zb8Mbm7pjXDMA vhXusB4019ncZ8LvxUAGHNx6mP1quCBBp4ihSSpU4axeWdttmeoK1KPE58Lf5RWCVYjz gMw6JetcgVbKqvOSXjErx0kIXSxQy+eBFdAhh/VZ02Zo8c8AVKgsza0gBR9xIJopsiKN Dgn4SqPXdREnToqSeoSflVr6CdcAkUH/HhUs+tUkAKgp3ohG2EPXl9ZPKpueL/ScqHHf zjo+x97DLEdOWf8mH77o+qhaqJ109Idaj/eahtp8D1cvn81TeiV7v922v3wXFOyo3Fq9 cRKA== X-Gm-Message-State: AOJu0Yyj7J+Sb5Vlz1ooK6hTMk4ElyPPp5f0YLAEgzt2VJlNEc6KGbbH sz6gs5GfyNMSH3NxNgEHcjDQY226vr8qdYyeSG+QZyyq0uOwqF7UHUt9SZdiDwM= X-Google-Smtp-Source: AGHT+IHSVxDzIZS9slcX0IZXaEDw4TOXyAuXc85jxX/A67blEPDDl1BU67Jv8XPwU/UtWl0xms5zLg== X-Received: by 2002:a17:903:181:b0:1d9:c20b:1d54 with SMTP id z1-20020a170903018100b001d9c20b1d54mr221075plg.19.1707153916548; Mon, 05 Feb 2024 09:25:16 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWZx5SqutWckyTJLNuDHimwnatTdWckWowguqIYH2gaLFl7XlSil4bsTgZHUmbzfuR9eh8g2CyszAT5s8jgRt5vAji9qKyxvg== Received: from localhost ([2804:14d:7e39:8470:3e0f:c572:eb80:5a11]) by smtp.gmail.com with ESMTPSA id lo11-20020a170903434b00b001d91b608a9csm107426plb.279.2024.02.05.09.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 09:25:16 -0800 (PST) References: <20240203031408.137939-1-thiago.bauermann@linaro.org> <0dd8e039-d15f-4d79-be71-587b0758304f@arm.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org, "binutils@sourceware.org" Subject: Re: [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default In-reply-to: <0dd8e039-d15f-4d79-be71-587b0758304f@arm.com> Date: Mon, 05 Feb 2024 14:25:14 -0300 Message-ID: <87cytadds5.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Luis, Luis Machado writes: > cc-ing binutils@ as well. > > On 2/3/24 03:14, Thiago Jung Bauermann wrote: >> Commit e5f2f7d901ee ("Disable year 2038 support on 32-bit hosts by >> default") fixed a mismatch between 64-bit time_t in GDB and system heade= rs >> and 32-bit time_t in BFD. >>=20 >> However, since commit 862776f26a59 ("Finalized intl-update patches") >> gnulib's year 2038 support has been accidentally re-enabled =E2=80=94 ca= using >> problems for 32-bit hosts again. The commit split baseargs into >> {h,b}baseargs, but this hasn't been done for the code that handles >> --disable-year2038. > > Ouch. That's unfortunate. That was an annoying bug to chase. Thanks for c= hasing it > (again). No problem. It was much easier the second time around, of course. >> This patch restores the intended behaviour. With this change, the number >> of unexpected core files goes from 18 to 4. >>=20 >> Tested on armv8l-linux-gnueabihf. >> --- >> configure | 3 ++- >> configure.ac | 3 ++- >> 2 files changed, 4 insertions(+), 2 deletions(-) >>=20 >> diff --git a/configure b/configure >> index 670684d83d15..6466b97f3ec0 100755 >> --- a/configure >> +++ b/configure >> @@ -10313,7 +10313,8 @@ hbaseargs=3D"$hbaseargs --disable-option-checkin= g" >> tbaseargs=3D"$tbaseargs --disable-option-checking" >>=20=20 >> if test "$enable_year2038" =3D no; then >> - baseargs=3D"$baseargs --disable-year2038" >> + bbaseargs=3D"$bbaseargs --disable-year2038" >> + hbaseargs=3D"$hbaseargs --disable-year2038" >> tbaseargs=3D"$tbaseargs --disable-year2038" >> fi >>=20=20 >> diff --git a/configure.ac b/configure.ac >> index 88b4800e298f..1300a805fd8d 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -3432,7 +3432,8 @@ hbaseargs=3D"$hbaseargs --disable-option-checking" >> tbaseargs=3D"$tbaseargs --disable-option-checking" >>=20=20 >> if test "$enable_year2038" =3D no; then >> - baseargs=3D"$baseargs --disable-year2038" >> + bbaseargs=3D"$bbaseargs --disable-year2038" >> + hbaseargs=3D"$hbaseargs --disable-year2038" >> tbaseargs=3D"$tbaseargs --disable-year2038" >> fi >>=20=20 > > Approved-By: Luis Machado Thanks! Since this is a patch for the repository top-level, is your approval sufficient to commit the patch, or should I have approval from a binutils maintainer as well? --=20 Thiago