From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id EF8A0385C6F1 for ; Tue, 25 Jul 2023 20:56:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF8A0385C6F1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36PJIYDS020113 for ; Tue, 25 Jul 2023 20:56:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=HReajkcrlNVgcpc1bQfDrRE6sNL6ZFCsY2T88fUsm80=; b=M/H/BVxcMM31jos5tECPNWKAvaXey3gyUUIWhtDQ0Gsy4wRrmO/aCW79q0c0ECd/JUKY NQFiwYGDSJG5eUWuILLwFHhesXz2vJPAk/PoWPuCIwKWbW4KafjEbP67x18VrDNpvFT/ NvsK0aRYYiJAtsKN1DaVRkIcE1P70sdbnyzyye9y8Imou7jsYHzCNrN9zK7ldaglKggc PM7N59qu5HwMc8aCTnG1NSeNUl1lzALXsjZ5J2xswwxkCEcMniBUS16EmMB5aXyCcEUj YEyyCjqV3n7dsvfa0kpdruvdBMp9xW0eUNKg+3023X0Dr/7AcfKbW8dJlODCdVD4kgnl yg== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s05hdx2g5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 25 Jul 2023 20:56:17 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 36PJiJVE030456 for ; Tue, 25 Jul 2023 20:56:16 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3s05jbket4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 25 Jul 2023 20:56:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R4X/Iq03hxN7xrKftP8UZFR9EqNlyNGml0qGprGoRU11ouVSaY75hc8nMO1CctI209nfHkdNAnWoald58FaJlOq39RQpueOO3qu9W74MX0l+Psf0xxGz7YMDsQijZ3BxghfabNsH3MfoVVFI/y/FafywcQv845o52w6xdA/kirgOYhjJQErlprWr/zD5oexru6qkkKHLDkOLtrK6cF5WCxFyDUfnnll9nETivNundVi2iUsr9fSxPdPitaSO2t0ZlBfJmnsIMpdZjqrCP1lWm8tIqeDF+Ckkf9zh3lisMtepXyrWyRU9RblZ7AuluTqsm6Grd+yX+DIGLb1vxKqutA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HReajkcrlNVgcpc1bQfDrRE6sNL6ZFCsY2T88fUsm80=; b=OSae6mn0BRnQom03N0B18hE1TkpqOa2ayfmoqMU+yRpK//Da6RZ9KEMZoXp+y6KgEyJzEwzCEVPbK3J29vF5xKcPcFcVJY9QGq+OCBHK7YAOz5V2tee0RyQBP9WMBlezkVrCsBZI02Ta6bUR8FvqMdFDOwuGPyBxZ2lfyOvjDQlqOweVtX80gkJZiucMVgdfHSh6gYJUcbtxOoSJO+fboEZMkA1ZFh9FjoVMcdxPt+PLjt78EPuGpck9v+uEICWZRqJ6z9bsRcfYezOERoPZNPp9U0VmM5UYW1cbB+U6R0Bz33JKX8M7j0lBCC4LMb2v7Crwuc/PqezAlvxj0WW7MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HReajkcrlNVgcpc1bQfDrRE6sNL6ZFCsY2T88fUsm80=; b=lZilzqwqdcOlcvfAb3r9aPtyorKfDCeuY+Yrc+4viDtu74n+qH2QqP8kEzPEyLH/mMsVEXtiq6VnLM/BwlQz3EE93aEM8GM8nflx8f8jjRWrxNhd5kb93YR4tFAQ5uvFmlz8H8QZcbRM/Zi+LzSP66F6HjjzbhnjSz3LZ2sb5Bo= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by CO1PR10MB4564.namprd10.prod.outlook.com (2603:10b6:303:6f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Tue, 25 Jul 2023 20:56:15 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::d5ed:aedb:b99f:6f19]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::d5ed:aedb:b99f:6f19%3]) with mapi id 15.20.6609.032; Tue, 25 Jul 2023 20:56:15 +0000 From: "Jose E. Marchesi" To: David Faust Cc: binutils@sourceware.org Subject: Re: [PATCH] bpf: accept # as an inline comment char In-Reply-To: <20230725204435.9560-1-david.faust@oracle.com> (David Faust's message of "Tue, 25 Jul 2023 13:44:35 -0700") References: <20230725204435.9560-1-david.faust@oracle.com> Date: Tue, 25 Jul 2023 22:56:08 +0200 Message-ID: <87cz0faexj.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO3P123CA0008.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::13) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|CO1PR10MB4564:EE_ X-MS-Office365-Filtering-Correlation-Id: da390b48-3f8c-485c-c7e4-08db8d5195b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y5kyzHoSqXkAVKqXvRGyZ1byLssvlJum5X1OmMdc6aNL/T7jS+E43Qy+hjeYg/XbI8p1hnI/ksMME3cr3xdP6VRWvCuPEKCbpXVBtUH5BKiWHdCNEewji9mhT3Y+1c5re55xro9HcLBt8De+ejqiNkqV39Jot1qtrS2rYm1CijsM0RXE64+jDOkYeDTdt8C9ASnbfLSVOWh0msQMzfc6e+0tqWXzpHTRv2Htaa8vKTs/FG5v2evHBmsRNOwdh6+0lM6jfcq0N+L+dvS19elh2rzcpPPH9bmRd2N2YCJsxNpnvfkaqVBI5gxfWY3ln3caCr1Gi9f9RRZr+oUVDtOIGm7bkbXBp07GmsgkdsIWNqOOfd2RSObktiZjQRG+kjOAmBkJEMSQdo3aISHisUz2mkXXnJ2Shpjgr142q6NrzX28d/t+YvprArplsLDBTA2UBVX2B3lqtXivrb0e2ZlzbnGKrRYbHRa/mFg7/gS84fRb53o6Lyty3DgmWwBHOY1ki0+vA/nuDYqSrS9HNkQiYDArg04yG1+ORZYKd0X4I2Mag0S7c2sXPaPHQ5SJY0if X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(136003)(396003)(366004)(39860400002)(451199021)(8676002)(8936002)(6862004)(5660300002)(41300700001)(316002)(4326008)(6636002)(2906002)(37006003)(66946007)(66556008)(66476007)(478600001)(6486002)(6512007)(26005)(186003)(6506007)(86362001)(36756003)(2616005)(6666004)(83380400001)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jDMGcAM52AZNzROv8fdqc1h0OBvyxxYmM9zuZyxostcp22lE7pKjGWxAUgmC?= =?us-ascii?Q?c/ID0UCMMTWY9TA0Itd+va4ljHYkGfwSXx+hnIDS2kqCQL44qnzLChrdRzCq?= =?us-ascii?Q?RUs+HvnGIULJq3djIvijYMepIqxBS8hDNxbob+mRvbVRRkqqnSGOEgx1W/8l?= =?us-ascii?Q?9iwRtUs/J1N04K7hikTF4RXCZ9W+35CI2+G7bWBXB47WM8vZD248CcXKvBTb?= =?us-ascii?Q?zeNIbuzx6YfkAFkTkIRuGGA9zsi5ircRoB73T574Xtp9JdVhe7aj2yNDeMYf?= =?us-ascii?Q?gdus1ov7ZlHxW+zeqrfD89v1i2pmfDmg6NDXnuU7Mv42rkme+AhHI8A29hrw?= =?us-ascii?Q?4mD/vRNUSqvMwEv8lJLoJ6F8AtEuzrlXv6ZiglmBZz0qp47phPEY2pjaL1NU?= =?us-ascii?Q?W0EViZk3ziypk3/ZlQNGPTMEbBcNgMUs59ccBB39ec9tha9MFj3MV5F8CDWC?= =?us-ascii?Q?0Rrz/PWOZMUUcM1nBAaztaa31Ke+HEoFmYlvNHcYQg4m3KiwnDcssPp4OYsh?= =?us-ascii?Q?cyoXLvmXJDvZAmFdtLiF80K2ufowg3RAK9+8marQfbK5oJ4m0/qHgo1WCxQG?= =?us-ascii?Q?njj0nm21IKoCi6PwpDyBks0j4/utsYuYqgS3ptXBSSHyvAwSgCvNBJaIMe2U?= =?us-ascii?Q?sEf9etL6wj3cD9WY9WsdGdHGNvi8shcNDIt0GyL33zZKpWiKJY3pq8F1NhjF?= =?us-ascii?Q?akGB0Palb+41t26uFxLPavzKE0Pz54OfoOJtIdHoTKWBFUP65KNHweSZfD5t?= =?us-ascii?Q?U0WcsEXwXMi61kDj1fTolEj8w4vwR/nibTY/QWUcDXksXwM/etUDE9EJIRrw?= =?us-ascii?Q?XxPG4v3zZ2ACh2KPqhTnrBMHTATvkyWOWIywmBCnFIqIFamQ85zlOBoZJoiL?= =?us-ascii?Q?SesdwAmVe7kG+K0fxyNWZLF6e9FW5MGyFQRIqBw08vMm5gfm6q5L/bxTi1it?= =?us-ascii?Q?KCPC1XHhruLDQR/ZN+0BpvxbnoeMR/Qx73kqeZrGCsFZq06w9xerTYw36g2d?= =?us-ascii?Q?CgXXiSsEPMfKtCWHJh9Zu6Emh6kn/QmftGO23c6Pemr7wl8CIpRVZxGNWbti?= =?us-ascii?Q?CRJJFHxiJbEJAQCnx+8LN6fz4hG2Qi7Nwt1TvTBEsdPUmzBoclgtLhuPp4OB?= =?us-ascii?Q?wLT7Qq64B9GJbbUThZ3oFFCa0NQdMOpmeSBTzsXZmYQJaHR2pQ++w6IZqWmC?= =?us-ascii?Q?g+VpfLvuTocbacq2F7ZpZW1YC5Ct7PEFUDt9XrXDkftPyCf+Q7gSKzUFLX/V?= =?us-ascii?Q?OSqFwgGxViWzCsM8LW09msRHli7G6Z2IP+OzO8BX5LrNE5Fe2rR/BSLUU5TS?= =?us-ascii?Q?OL4HM4efiNx5CeVMYncVLIsHr90KBFO7tmh+5cyveltWlpd7z6+JvKDUkVpo?= =?us-ascii?Q?bUKJFBTcRkTg8LCJarK3eYfmN+Ye41N/IaNA88LtHfJvqOptuyd7BzFsOlP8?= =?us-ascii?Q?t/FPGI8jr/iOn0PGMLTr0g8l9DvitOgl2XdSZ8ff0GrLiXAJj+Bpf/skv+5I?= =?us-ascii?Q?uKtJp83D9KKXJ6E/b9zMNuAtJBo3CLIO9SuB08rLRNMEZUOv+i2+d9Sc8/am?= =?us-ascii?Q?LvRwYIQR8hswjAIvMKv7bmWEIm4PH8wJJU2Zm4j2UiwUJnVIdQ3KkHjNEWm9?= =?us-ascii?Q?UA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: agzU8lE2A1hQYYBOvmNOBceuR4LT5MLebCHMvwU+hn6waR6k1buJzBJUpvXYzYTEQvcqj9vF0pWKB/epV1lBU8nGezXhYou1iPHguAJORJMQOdtu9Kr8pr3E9Oeayf+USNkx+vT/O20kcFjxRcNzWdRjycwebTxcHHNu+ITH9tSLkbUyy7tw9EFiIQwtarHUzfFPxakHZ++6OX9ydUsJj4Kc0YPuOscGiMg8MkVcaJ25rknbgKvis32MkPDIrSca1MUg3AwZPPJVyj2N95cbvpiYIU5MDu0u24zSCsuzYr0PZjmo/sP9M9VnEQFq2HCl5YCov5e8DAR2lw1nOQeLkZEO8r7qVLJMF5o57JH2EQBucDBqizB9mRycCxNXPS7Kdfve+L8D7a5dIViPvhMEKi2E4zRMpiDUBROhj69Wfenz6nz5m8vcuo7GnRW9/Uv3sgByYOl0Mycg6LWRu45M6jJDWrbiF3TaOrvZGyse4EpiiVDnq1OV9gy6YUoqkW1rAa1O5t8lj3Bdi1b42EzuaRl6QnluTxNyHgFl5A4u9lYr5YtNkKWT3RzAQ0ML0CPB4PNIkl2V33l967A4r7fHTLVg8JUeOYW/IyPrh7C/jVlQLp4cQHU85t9nCuqsTtHnpCnetIftIgZsClkMeQ9Ad018ATCHPUUfarzawls/e+TpwadBcAG9ktMDOgGfZL6UrHWudlQABMPFDuSLrPVHJe/oxVrMZMagVR1Zs02K8KO0KPqv1RxmbSWAqCjbjUrG X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: da390b48-3f8c-485c-c7e4-08db8d5195b5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 20:56:14.9551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6BbCUgEKdh99LK147mSa6yEXic3qOxtSbKelefusVFfX6KKok1Fj75x+3geGluJzNcWrjOEyhUzoRzZS3LHEQpxYfKn96uJaLGbT3dVBcQo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4564 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_12,2023-07-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=809 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250178 X-Proofpoint-ORIG-GUID: zTbfvB6rwwX1oKg5aEV49t66fPVIC0O1 X-Proofpoint-GUID: zTbfvB6rwwX1oKg5aEV49t66fPVIC0O1 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > This little patch makes the BPF assembler accept '#' as an inline > comment character, which clang -S seems to use. > > Tested on bpf-unknown-none. > OK? > > gas/ > * config/tc-bpf.c (comment_chars): Add '#'. > * doc/c-bpf.texi (BPF Special Characters): Add note that '#' may > be used for inline comments. > --- > gas/config/tc-bpf.c | 2 +- > gas/doc/c-bpf.texi | 7 ++++--- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gas/config/tc-bpf.c b/gas/config/tc-bpf.c > index c56b8fe984f..56c434c223d 100644 > --- a/gas/config/tc-bpf.c > +++ b/gas/config/tc-bpf.c > @@ -53,7 +53,7 @@ struct bpf_insn > unsigned int has_imm64 : 1; > }; > > -const char comment_chars[] = ";"; > +const char comment_chars[] = ";#"; > const char line_comment_chars[] = "#"; > const char line_separator_chars[] = "`"; > const char EXP_CHARS[] = "eE"; > diff --git a/gas/doc/c-bpf.texi b/gas/doc/c-bpf.texi > index 8f39ab314a7..597b3b30b30 100644 > --- a/gas/doc/c-bpf.texi > +++ b/gas/doc/c-bpf.texi > @@ -64,9 +64,10 @@ the host endianness is used. > > @cindex line comment character, BPF > @cindex BPF line comment character > -The presence of a @samp{;} on a line indicates the start of a comment > -that extends to the end of the current line. If a @samp{#} appears as > -the first character of a line, the whole line is treated as a comment. > +The presence of a @samp{;} or a @samp{#} on a line indicates the start > +of a comment that extends to the end of the current line. If a > +@samp{#} appears as the first character of a line, the whole line is > +treated as a comment. Hm, isnt' this second sentence a quite obvious corollary now? :) > @cindex statement separator, BPF > Statements and assembly directives are separated by newlines.