From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B1720383D80D for ; Thu, 19 May 2022 14:04:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1720383D80D Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-388-i0QQ-0ltNMO8iY8KYnjxaA-1; Thu, 19 May 2022 10:04:36 -0400 X-MC-Unique: i0QQ-0ltNMO8iY8KYnjxaA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B558E811E81 for ; Thu, 19 May 2022 14:04:35 +0000 (UTC) Received: from comet.redhat.com (unknown [10.39.195.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59501492C3B for ; Thu, 19 May 2022 14:04:35 +0000 (UTC) From: Nick Clifton To: binutils@sourceware.org Subject: Commit: Fix some warnings about using potentially uninitialised variables Date: Thu, 19 May 2022 15:04:33 +0100 Message-ID: <87czg91uvi.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2022 14:04:39 -0000 Hi Guys, I noticed today that we are getting some new compile time warnings about variables being used when they are potentially uninitialised, so I am going to check in the patch below as a quick fix. Cheers Nick binutils/ChangeLog 2022-05-19 Nick Clifton * dlltool.c (run): Initialise errmsg_fmt. * dllwrap.c (run): Likewise. * resrc.c (run_cmd): Likewise. * mclex.c (mc_add_keyword): Initialise usz. * srconv.c (wd_hd): Initialise hd.spare2. * windmc.c (mc_add_node_lang): Initialise s. (mc_generate_bin_item): Initialise cvt_txt. (main): Initialise u. diff --git a/binutils/dlltool.c b/binutils/dlltool.c index 89871510b45..e2af2084700 100644 --- a/binutils/dlltool.c +++ b/binutils/dlltool.c @@ -1268,7 +1268,7 @@ run (const char *what, char *args) int pid, wait_status; int i; const char **argv; - char *errmsg_fmt, *errmsg_arg; + char *errmsg_fmt = NULL, *errmsg_arg = NULL; char *temp_base = choose_temp_base (); inform (_("run: %s %s"), what, args); diff --git a/binutils/dllwrap.c b/binutils/dllwrap.c index 713322905c4..1be3cec72f1 100644 --- a/binutils/dllwrap.c +++ b/binutils/dllwrap.c @@ -350,7 +350,7 @@ run (const char *what, char *args) int pid, wait_status, retcode; int i; const char **argv; - char *errmsg_fmt, *errmsg_arg; + char *errmsg_fmt = NULL, *errmsg_arg = NULL; char *temp_base = choose_temp_base (); int in_quote; char sep; diff --git a/binutils/mclex.c b/binutils/mclex.c index fd2888625b9..fe6f127d903 100644 --- a/binutils/mclex.c +++ b/binutils/mclex.c @@ -212,7 +212,7 @@ enum_severity (int e) static void mc_add_keyword_ascii (const char *sz, int rid, const char *grp, rc_uint_type nv, const char *sv) { - unichar *usz, *usv = NULL; + unichar *usz = NULL, *usv = NULL; rc_uint_type usz_len; unicode_from_codepage (&usz_len, &usz, sz, CP_ACP); diff --git a/binutils/resrc.c b/binutils/resrc.c index 249eb9a87ed..42afdc1d954 100644 --- a/binutils/resrc.c +++ b/binutils/resrc.c @@ -200,7 +200,7 @@ run_cmd (char *cmd, const char *redir) int pid, wait_status, retcode; int i; const char **argv; - char *errmsg_fmt, *errmsg_arg; + char *errmsg_fmt = NULL, *errmsg_arg = NULL; char *temp_base = choose_temp_base (); int in_quote; char sep; diff --git a/binutils/srconv.c b/binutils/srconv.c index c77db99a9e7..6fc98bc49d5 100644 --- a/binutils/srconv.c +++ b/binutils/srconv.c @@ -316,6 +316,7 @@ wr_hd (struct coff_ofile *p) struct IT_hd hd; hd.spare1 = 0; + hd.spare2 = 0; if (bfd_get_file_flags (abfd) & EXEC_P) hd.mt = MTYPE_ABS_LM; else diff --git a/binutils/windmc.c b/binutils/windmc.c index f9a41694be4..b47da91f1bb 100644 --- a/binutils/windmc.c +++ b/binutils/windmc.c @@ -338,7 +338,7 @@ mc_add_node_lang (mc_node *root, const mc_keyword *lang, rc_uint_type vid) static char * convert_unicode_to_ACP (const unichar *usz) { - char *s; + char *s = NULL; rc_uint_type l; if (! usz) @@ -607,7 +607,7 @@ mc_generate_bin_item (mc_node_lang *n, rc_uint_type *res_len) else { rc_uint_type txt_len, l; - char *cvt_txt; + char *cvt_txt = NULL; codepage_from_unicode( &l, n->message, &cvt_txt, n->lang->lang_info.wincp); if (! cvt_txt) @@ -1105,7 +1105,7 @@ main (int argc, char **argv) /* Load the input file and do code page transformations to UTF16. */ { - unichar *u; + unichar *u = NULL; rc_uint_type ul; char *buff; bfd_size_type flen;