From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id B8C643858C52 for ; Tue, 25 Jul 2023 23:36:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B8C643858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36PJITVL025744 for ; Tue, 25 Jul 2023 23:36:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=7pyyxXrNd1Za5n5FU5/Sk1f4RC6Q5yHaeYVui+BqflA=; b=M6WPBzjRsf/nEJd+/FBS6fFpDLLK0d61PkvE2+8ayrYSxPbwwGB37zpGTAdlwo8ZZGft SXqP+jaXdSmAgN6pUfQjQgxAhnaWBsVc3Cq9I+qZ6zFXIUZGNeuzuBU2nnRb+yjB4Jls KB6KOkGZ7xO82yrjcC7nrKQ4Vr6Y43VK8vpeqaLN9xGzeX+2fqCtwnF9+FKx08h8fCEh 0c9bYatcgB7yHt6l5uKdT8zXFrUY32ITwErat7+q+uIwVq58mo3rgQ1p7syWD/lyJ01y TJXYhw5zkzp4A4GwsrB08TPL848M/YFEFwo/a0vgwdkQcb7srrM0j4jIxMFg9rH+vjAy Ew== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3s075d6bv3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 25 Jul 2023 23:36:37 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 36PLj1Op029511 for ; Tue, 25 Jul 2023 23:36:36 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam04lp2046.outbound.protection.outlook.com [104.47.74.46]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3s05j5fdm2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 25 Jul 2023 23:36:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oNMu2IoQyIp6X5KcF8Y2hr1dz6QWczYwPxm21jYCnnOZMwM3z/lSMlRhvA53WP7dPkTppxS8yZvwnZVNITSjBV7ulDmKEAC/NLF5o8dlvjcNLMBNk0JsdCnrLKG3MilSLOXkeUu8CSjKFi705VYoS7t1FJznOQZkHJGr3HfJNqgY3+9QkqZ50yqRzjWrrzYK2lpqfaxhA09+xGZswHQJkhJ/QUSK5c00i26PznPeB24omLk4/R+anwtac2+YIP8JEWkPdr4aoZAfiTAQMM1hiUgZJVkZK1DV92AUZGQ3XTXSZh8JWPZqR+c5yHdLPcAe902O2dHAtDKYrMwR6F/vKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7pyyxXrNd1Za5n5FU5/Sk1f4RC6Q5yHaeYVui+BqflA=; b=R3sSmflwrQpuT+tsmb4OriMtiCspaBz6hgVsLH/W83mjhtGeOds5AFMErRXrbNDHNVhcTLd0jHOJ9mPxYTNDBVdiGyV9B4TPrkP61hViq9/CiYFNDLbDhB8e0FjGjwM689g6lEUA6pTVRgDFB2EX+AhKckZT5qCUI3dtBs2NFBTXxHKtxm4eRqFSC2sK/nsOlfjQEwUBKXgBSyJbbXB/WirqibsYpsSkFApsdNsay/xMF2ZZgFDzI4DemTEGoXaXLfa9WQVECQL2UjqbXghXDfOaY04bgfizfO0cPPv6kWUHrVjxsYIBT41toJRtCanA0+rrlr9IDvZjYhZp8rIYPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7pyyxXrNd1Za5n5FU5/Sk1f4RC6Q5yHaeYVui+BqflA=; b=VjIkFi3a5iH61OGjh81wp6aCmYXYazdG4SMdRfOPL3WkdDa41pUg6dk0C6uGZCMhAy1N3HhuGqM9cH3nJyHiPrLL25UmfRgLIbIbcMaGd5NQQu0EUWle/ivLOuuU62pYBgH057J30UoSXXGcOc17gEfY8cnRDkZ3PxRT1HHZGDU= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by LV3PR10MB7748.namprd10.prod.outlook.com (2603:10b6:408:1b4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.32; Tue, 25 Jul 2023 23:36:33 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::d5ed:aedb:b99f:6f19]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::d5ed:aedb:b99f:6f19%3]) with mapi id 15.20.6609.032; Tue, 25 Jul 2023 23:36:33 +0000 From: "Jose E. Marchesi" To: David Faust Cc: binutils@sourceware.org Subject: Re: [PATCH] bpf: accept # as an inline comment char In-Reply-To: (David Faust's message of "Tue, 25 Jul 2023 16:13:50 -0700") References: <20230725204435.9560-1-david.faust@oracle.com> <87cz0faexj.fsf@oracle.com> <2268139b-f2ba-afee-3cd5-a1e3130b290a@oracle.com> <87jzun8uof.fsf@oracle.com> Date: Wed, 26 Jul 2023 01:36:27 +0200 Message-ID: <87edkv8sxw.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LNXP265CA0027.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::15) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|LV3PR10MB7748:EE_ X-MS-Office365-Filtering-Correlation-Id: 29fd806d-70c9-47df-d622-08db8d67fa7e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i3/5VHu5XhT9VbkRaMLdZ2kYutLsUH1myGwfoGkwECgTUL7ykr6QPEk/1A+WNDLSTZ9GbuN2h7+N21kyVJdjkBN5jpYhm2eUpK3A/dOMSGXs4dFgx52Ju5kE/gNjawUtGWCnlWLrHelgB/fJ/1f+yQ28AuQ+33npzc6PPPTnaGqtG1ze89VYT4HNa1LBvL4ob8euJjcvwM6psuV1MdmwEYx7syxmhaJHCZYEvT4nRIza2IvgiBUbUiyiJaSH3b2kfkA8+A/nhhz882O02feDvs1CUIqmk8HEYFanVbHAxJx/LsY5joG07H4dbjnyQNF1D79ZemgDwP+wknnPhTZ2ccX+8tcNTZw5GW/UNRvPsBEukfA4fvyPjon8ZIP34BXFDthK/1XfsOhm8LBSfe9dUuGM2MRv/2dPqnKcfVPLOlyeAjNXRVZHKOPQDKV8UHsbUbA0pOZGCH3tfy0sfPGt2Pzd3pUSmQ3S33hTwdKvLCcocXbhaKd2qRJSTXhoay1btSPDLiOFl2yfnjY+CbOwsPFNzO3us6HJqtpEZRiayZiKR8GIvsvMsmFfr9/GOl++ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(396003)(136003)(346002)(39860400002)(451199021)(66946007)(83380400001)(37006003)(6666004)(86362001)(6512007)(66556008)(66476007)(6486002)(4326008)(6636002)(316002)(2616005)(41300700001)(478600001)(5660300002)(8936002)(8676002)(6862004)(6506007)(186003)(26005)(36756003)(38100700002)(2906002)(53546011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZAXlmILfeYK9/ZUfQU37nu0JkzrUleTM+bmaw7x0igOEm7UewujN1WUkk5hs?= =?us-ascii?Q?hm6XJmcOGMxcxt704LLsGbqNLZfKRLMLNG0GG2ZvCaP2bkQbcJEwQCL3u+Ld?= =?us-ascii?Q?xxW9jmh6FBzZjSaW+7ybrvG0nmzB9wMdpVqGEpMgfRsuKH7LKG/AatuHNtjX?= =?us-ascii?Q?QarWeaq0blLXLCWM6G0xIkak9ogjYu7HZm/L/hzcAeIzzocvnINjZ/rj2DDZ?= =?us-ascii?Q?EqUCZcab/9/1+uK4X7guU8MvgKFfGmvHeagwK3q8ZUwoTbXbL9LyHMYrLthW?= =?us-ascii?Q?o56F35F4VGuoxXkQMIxkxKLY6l8gRHlHjTLK8qokcs8inoDDnDc55smQdo1I?= =?us-ascii?Q?bsQEJxzazTBVda7EVVZVbLjRtG5vDpHwsdfRqlS8aB78QAEl6bhTJ5QAhuIn?= =?us-ascii?Q?/fOz9V7wlZ6OTwMfnUUUqKH4PVqLWDcnJ1USj9f0KSSSV12mfhvojMt2rxNk?= =?us-ascii?Q?DHfWuvUlV6BmqUzrEeINIzR7RQNqequ38Nm45oT1oICrEQH59GT2N58wUQtL?= =?us-ascii?Q?NhkxFgDLqDixFhlGnnXVvi1ON1Xq2ci4gZjKXjv2dbu4swVEsGNc/DPKXKJD?= =?us-ascii?Q?v9j/Mdy3xjJFkRQKcIIpRuqEz3eqcz+Y5KumruI0NAFC0RNdBPR9H0CYXaWm?= =?us-ascii?Q?04LaUsnvrqjeY1o6kZFEAlvv8FXIRQX+ybeeuCaaGsVkKOiws1aAqmD7Hw1O?= =?us-ascii?Q?IJ0jadwMftRdiwt99r6atnhXkgriC4WB/4WeCTKwfb8chQVMryBRSvn6EHh4?= =?us-ascii?Q?gBPvKxLFbiEDeUsko5a7/eWAgTu6NPyUgLQ68h8CUH3CEhXgM+JrFIFEWYNb?= =?us-ascii?Q?Q+dUMzXD5zKkG8ICpMrkf5qa7f77OpBS58qBwCbfqePDLeDy5pvV1fsPARPu?= =?us-ascii?Q?+qdngMjuMMQVz2SIbJff3eLZv3bn+lFBfBjWNtgHJVjXrJmDsu22yAoH0hxx?= =?us-ascii?Q?cS0LFuw8tlv/1/9lCuRYilqZW7E62dRgND4VbNg7tRtYhcCRo32C2eUaFpzs?= =?us-ascii?Q?D2M3xX3dcmqxStX9KGSxSIqaESX5r3AxFqigHxZb69yJ+QBzkH8q11M2ogVg?= =?us-ascii?Q?QwNHz8JScNkyCBLiivb3yoN8WbvjhLmgkhsYYZunNsZ6/AG6TnGPeu2jG3y8?= =?us-ascii?Q?JInt2uM9juE0bWCOIoOEUUaOvzMYD+4TxgNqg2YlmR7CCD8Y6E2LuwpDV0iA?= =?us-ascii?Q?IzGdKawPw85A3pv3BqE8Ldm3j1B+29FHECDWvv1zQwA1AaZgrfq5+BSwa/Km?= =?us-ascii?Q?CbSxMzlzaWkj8TrOE+0NMq/4H5m5abMGP6uCuWY783q5FRtJDzDYKUqA3imo?= =?us-ascii?Q?7yDtFfLWWc69bdAfUnvN0nepqLdridpiToq327cTjxjgL3YePgtG8NoBeDy5?= =?us-ascii?Q?AaCjudnNSsAMILdKHrnfCdqDXsnwAmrosP2yNBUzAuy+8X0QzqsQ5i/0faPq?= =?us-ascii?Q?P51Mb4UaZ79oDqUTChdwJrXUe58s/OeVUUADmopPVn+jJzv4InDYY5IGt2YM?= =?us-ascii?Q?PkObzffaNESuvKZwdsYvsPtQUM0dh3EM9bFK5pP6SPVFzYrX6q9S0yqEVmCh?= =?us-ascii?Q?fLPZXeUDhjdH/X35fN3XNEL4GnR13ZSV+behKKN4jBm5UKM/mhJD92F0wpJw?= =?us-ascii?Q?qw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ssRM9Td0wzcUJSZ3K9ugbN4zTdA+jwuX7PKE7a2V8AD8ZP9RrlP97jiH/6yiFwDUCrqfiRKHjMKNHkwUQpPhuAC5uTZx7be++OeF7SGV+rv5PLnRk54FjElfAe6uiMPgNPiTbxwtlxhCt3O9gz2uyBCADzrz0+DAzRSAEPdUtXx7Wur4f+oPj77fW9muTkAeY+8pX1W/yBRdBpPWIhzSaikWenM5JXPcOOUnqAX3jANaB+2vheulx7RZZ9ZTXoNi22ro8LB2v8kTgwJvARI5bdjPneUcTbQMb1xRnqphepuLo2TPsXEoTLj225dgg59PcMI4bv+kAz87M4qJqKZ6WyHy2r851nA9DSafdFEHDAG2WMgfJ7Pdqy+H8tNx+tIXjz0dSLvor0pv+I/KdW7NVooXhBF5aYgRg8yHZN1BCD+mQIW3mS6jzjw88xHLN+fatF+vBEwALsAtWKLx4bh/WSzR24FXHNcQXLZ2HN0Y+e4uyOzK33ZheU2F+XkGu3c4kSXlIy9aB8MlZUWoiKTssIJAjGjmAzIQG2dozQCpmQJyF18PGhW3yG5RMPNKO3MOl81N2hBihJMgXIhVI7UIRBOvTZZwDMfIS9cMFNTrsQ/snzcWwMvVEFc43wza6ggAoAY8hHHpWbJ9V1FKXnur0Tc3GEWkzXKGUwMX4u1YUWUaMY9f0aOs1rMk2EcD0zIkTgt/c3Rd8IrGZMm0qcHvGQWLRwRgG3T5naUrfge9KvAn/u0mZFn5avHVMlOyksZQHEvPued8T7cVeMjqY+cGWQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29fd806d-70c9-47df-d622-08db8d67fa7e X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2023 23:36:33.0494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JJPr+DIqd+1FtqARnVx53mJVVf2u5J2Za+Q43li5uOzt+w8e47t7me+AB3aEC/nNQxzDikcibn7VDBaMe1d0s79NZb+RfR5tHLWvbPgotys= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7748 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-25_13,2023-07-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 mlxlogscore=828 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307250200 X-Proofpoint-ORIG-GUID: Gqmg9XW5zD-Jqj8W4njhXgkBaoONNURQ X-Proofpoint-GUID: Gqmg9XW5zD-Jqj8W4njhXgkBaoONNURQ X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 7/25/23 15:58, Jose E. Marchesi wrote: >> >>> On 7/25/23 13:56, Jose E. Marchesi wrote: >>>> >>>>> This little patch makes the BPF assembler accept '#' as an inline >>>>> comment character, which clang -S seems to use. >>>>> >>>>> Tested on bpf-unknown-none. >>>>> OK? >>>>> >>>>> gas/ >>>>> * config/tc-bpf.c (comment_chars): Add '#'. >>>>> * doc/c-bpf.texi (BPF Special Characters): Add note that '#' may >>>>> be used for inline comments. >>>>> --- >>>>> gas/config/tc-bpf.c | 2 +- >>>>> gas/doc/c-bpf.texi | 7 ++++--- >>>>> 2 files changed, 5 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/gas/config/tc-bpf.c b/gas/config/tc-bpf.c >>>>> index c56b8fe984f..56c434c223d 100644 >>>>> --- a/gas/config/tc-bpf.c >>>>> +++ b/gas/config/tc-bpf.c >>>>> @@ -53,7 +53,7 @@ struct bpf_insn >>>>> unsigned int has_imm64 : 1; >>>>> }; >>>>> >>>>> -const char comment_chars[] = ";"; >>>>> +const char comment_chars[] = ";#"; >>>>> const char line_comment_chars[] = "#"; >>>>> const char line_separator_chars[] = "`"; >>>>> const char EXP_CHARS[] = "eE"; >>>>> diff --git a/gas/doc/c-bpf.texi b/gas/doc/c-bpf.texi >>>>> index 8f39ab314a7..597b3b30b30 100644 >>>>> --- a/gas/doc/c-bpf.texi >>>>> +++ b/gas/doc/c-bpf.texi >>>>> @@ -64,9 +64,10 @@ the host endianness is used. >>>>> >>>>> @cindex line comment character, BPF >>>>> @cindex BPF line comment character >>>>> -The presence of a @samp{;} on a line indicates the start of a comment >>>>> -that extends to the end of the current line. If a @samp{#} appears as >>>>> -the first character of a line, the whole line is treated as a comment. >>>>> +The presence of a @samp{;} or a @samp{#} on a line indicates the start >>>>> +of a comment that extends to the end of the current line. If a >>>>> +@samp{#} appears as the first character of a line, the whole line is >>>>> +treated as a comment. >>>> >>>> Hm, isnt' this second sentence a quite obvious corollary now? :) >>> >>> Well, yes I suppose so.. :) >>> >>> I left it in because I did not touch (nor look further at): >>> >>> const char line_comment_chars[] = "#"; >>> >>> which was what the sentence documented. >>> I agree it doesn't add much anymore though, shall I remove it? >> >> Hm, not sure. Try if it makes a difference in practice... > > Yeah, it causes build failures if totally removed and failures > in gas/macros/macros.exp if left blank. Best to leave it. > > Here's a v2 with just the redundant sentence in the manual removed. OK for master. Thanks! > This little patch makes the BPF assembler accept '#' as an inline > comment character, which clang -S seems to use. > > gas/ > * config/tc-bpf.c (comment_chars): Add '#'. > * doc/c-bpf.texi (BPF Special Characters): Add note that '#' may > be used for inline comments. > --- > gas/config/tc-bpf.c | 2 +- > gas/doc/c-bpf.texi | 5 ++--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/gas/config/tc-bpf.c b/gas/config/tc-bpf.c > index c56b8fe984f..56c434c223d 100644 > --- a/gas/config/tc-bpf.c > +++ b/gas/config/tc-bpf.c > @@ -53,7 +53,7 @@ struct bpf_insn > unsigned int has_imm64 : 1; > }; > > -const char comment_chars[] = ";"; > +const char comment_chars[] = ";#"; > const char line_comment_chars[] = "#"; > const char line_separator_chars[] = "`"; > const char EXP_CHARS[] = "eE"; > diff --git a/gas/doc/c-bpf.texi b/gas/doc/c-bpf.texi > index 8f39ab314a7..3fde0e6b613 100644 > --- a/gas/doc/c-bpf.texi > +++ b/gas/doc/c-bpf.texi > @@ -64,9 +64,8 @@ the host endianness is used. > > @cindex line comment character, BPF > @cindex BPF line comment character > -The presence of a @samp{;} on a line indicates the start of a comment > -that extends to the end of the current line. If a @samp{#} appears as > -the first character of a line, the whole line is treated as a comment. > +The presence of a @samp{;} or a @samp{#} on a line indicates the start > +of a comment that extends to the end of the current line. > > @cindex statement separator, BPF > Statements and assembly directives are separated by newlines.