From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: Cupertino Miranda <cupertino.miranda@oracle.com>
Cc: binutils@sourceware.org, elena.zannoni@oracle.com, nickc@redhat.com
Subject: Re: [PATCH 2/2] Changed ld and gas BPF tests
Date: Mon, 20 Mar 2023 17:01:32 +0100 [thread overview]
Message-ID: <87edpj2yzn.fsf@oracle.com> (raw)
In-Reply-To: <87wn3bo2vw.fsf@oracle.com> (Cupertino Miranda's message of "Mon, 20 Mar 2023 15:31:47 +0000")
> I removed those relocations. Until proven otherwise the approach was to
> assume that we will not needed it until we do. I could not come up with
> an use case that we could practically needed those.
Thanks for the info. The patch is OK.
Thanks!
>
> Regards,
> Cupertino
>
> Jose E. Marchesi writes:
>
>> Hi Cuper.
>> Thanks for the patch.
>>
>>> diff --git a/ld/testsuite/ld-bpf/reloc-data.s b/ld/testsuite/ld-bpf/reloc-data.s
>>> index 431ef5aef61..90a5ff06896 100644
>>> --- a/ld/testsuite/ld-bpf/reloc-data.s
>>> +++ b/ld/testsuite/ld-bpf/reloc-data.s
>>> @@ -10,7 +10,3 @@ d64:
>>> .quad foo
>>> d32:
>>> .word d64
>>> -d16:
>>> - .half d32
>>> -d8:
>>> - .byte d16
>>
>>> diff --git a/ld/testsuite/ld-bpf/reloc-data-be.d b/ld/testsuite/ld-bpf/reloc-data-be.d
>>> index 4d793e2b41a..05734b12094 100644
>>> --- a/ld/testsuite/ld-bpf/reloc-data-be.d
>>> +++ b/ld/testsuite/ld-bpf/reloc-data-be.d
>>> @@ -8,4 +8,4 @@
>>>
>>> Contents of section \.data:
>>> 0020 666f6f00 62617200 00000000 00000020 .*
>>> - 0030 00000028 003034 .*
>>> + 0030 00000028 .*
>>
>>> diff --git a/ld/testsuite/ld-bpf/reloc-data-le.d b/ld/testsuite/ld-bpf/reloc-data-le.d
>>> index 97cb1b36a2a..8cabc7fae5c 100644
>>> --- a/ld/testsuite/ld-bpf/reloc-data-le.d
>>> +++ b/ld/testsuite/ld-bpf/reloc-data-le.d
>>> @@ -8,4 +8,4 @@
>>>
>>> Contents of section \.data:
>>> 0020 666f6f00 62617200 20000000 00000000 .*
>>> - 0030 28000000 300034 .*
>>> + 0030 28000000 .*
>>
>> Why removing d16 and d8 from reloc-data.s?
next prev parent reply other threads:[~2023-03-20 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 16:00 [PATCH-BPF] Fixes in recent BPF commit Cupertino Miranda
2023-03-17 16:00 ` [PATCH 1/2] Reloc howto access broken for BPF Cupertino Miranda
2023-03-17 16:00 ` [PATCH 2/2] Changed ld and gas BPF tests Cupertino Miranda
2023-03-20 14:57 ` Jose E. Marchesi
2023-03-20 15:31 ` Cupertino Miranda
2023-03-20 16:01 ` Jose E. Marchesi [this message]
2023-03-20 11:34 ` [PATCH-BPF] Fixes in recent BPF commit Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edpj2yzn.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=binutils@sourceware.org \
--cc=cupertino.miranda@oracle.com \
--cc=elena.zannoni@oracle.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).