From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19222 invoked by alias); 20 May 2014 22:07:54 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 19213 invoked by uid 89); 20 May 2014 22:07:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f170.google.com Received: from mail-we0-f170.google.com (HELO mail-we0-f170.google.com) (74.125.82.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 20 May 2014 22:07:52 +0000 Received: by mail-we0-f170.google.com with SMTP id u57so1216773wes.15 for ; Tue, 20 May 2014 15:07:49 -0700 (PDT) X-Received: by 10.180.7.198 with SMTP id l6mr6714870wia.52.1400623668536; Tue, 20 May 2014 15:07:48 -0700 (PDT) Received: from localhost ([2.26.169.52]) by mx.google.com with ESMTPSA id d6sm13009wiz.4.2014.05.20.15.07.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 May 2014 15:07:47 -0700 (PDT) From: Richard Sandiford To: Matthew Fortune Mail-Followup-To: Matthew Fortune ,"binutils\@sourceware.org" , Rich Fuhler , rdsandiford@googlemail.com Cc: "binutils\@sourceware.org" , Rich Fuhler Subject: Re: [PATCH][MIPS] Implement .module directive References: <6D39441BF12EF246A7ABCE6654B02353538578@LEMAIL01.le.imgtec.org> <87tx8kib4k.fsf@talisman.default> <6D39441BF12EF246A7ABCE6654B023535390A7@LEMAIL01.le.imgtec.org> Date: Tue, 20 May 2014 22:07:00 -0000 In-Reply-To: <6D39441BF12EF246A7ABCE6654B023535390A7@LEMAIL01.le.imgtec.org> (Matthew Fortune's message of "Tue, 20 May 2014 21:40:52 +0000") Message-ID: <87egzohznw.fsf@talisman.default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00189.txt.bz2 Matthew Fortune writes: >> > @@ -787,7 +787,7 @@ if { [istarget mips*-*-vxworks*] } { >> > run_dump_test "relax-swap1-mips2" >> > run_dump_test "relax-swap2" >> > run_dump_test_arches "relax-swap3" [mips_arch_list_all] >> > - run_list_test_arches "relax-bc1any" "-mips3d -relax-branch" \ >> > + run_list_test_arches "relax-bc1any" "-mips3d -64 -relax-branch" \ >> > [mips_arch_list_matching mips64 \ >> > !micromips] >> > run_list_test_arches "relax-bposge" "-mdsp -relax-branch" \ >> >> Not all targets compile in support for n32 and n64, so -mabi=o64 would >> be better than -64. > > Will do. I had only run the assembler tests for this patch but on running > the linker tests it showed a problem with .dc.a which is dependent on > TC_ADDRESS_BYTES and that in turn is dependent on the GPR size. The > mips_address_bytes function therefore has to finalise the options (because > that is where the inferred GP register width is set up). This means that > .dc.a is another pseudo that prevents further .module directives. > > Is that OK? (patch below to be applied along with the overall patch if > approved) Yeah, looks good to me, thanks. Richard