* [PATCH] [ARC] C++ compatibility for arc-dis.h
@ 2016-08-22 17:38 Anton Kolesov
2016-08-23 8:50 ` Nick Clifton
0 siblings, 1 reply; 3+ messages in thread
From: Anton Kolesov @ 2016-08-22 17:38 UTC (permalink / raw)
To: binutils
Cc: Anton Kolesov, Francois.Bedard, Claudiu.Zissulescu, Cupertino Miranda
GDB uses arc-dis.h and it is a C++ application, so header should use
`extern "C"`.
opcodes/
* arc-dis.h: Wrap around in extern "C".
---
opcodes/arc-dis.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/opcodes/arc-dis.h b/opcodes/arc-dis.h
index a588f97..9abfd94 100644
--- a/opcodes/arc-dis.h
+++ b/opcodes/arc-dis.h
@@ -22,6 +22,10 @@
#ifndef ARCDIS_H
#define ARCDIS_H
+#ifdef __cplusplus
+extern "C" {
+#endif
+
enum ARC_Debugger_OperandType
{
ARC_UNDEFINED,
@@ -102,4 +106,9 @@ struct arcDisState
struct arcDisState
arcAnalyzeInstr (bfd_vma memaddr, struct disassemble_info *);
+
+#ifdef __cplusplus
+}
+#endif
+
#endif
--
2.8.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [ARC] C++ compatibility for arc-dis.h
2016-08-22 17:38 [PATCH] [ARC] C++ compatibility for arc-dis.h Anton Kolesov
@ 2016-08-23 8:50 ` Nick Clifton
2016-08-24 12:38 ` Claudiu Zissulescu
0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2016-08-23 8:50 UTC (permalink / raw)
To: Anton Kolesov, binutils
Cc: Francois.Bedard, Claudiu.Zissulescu, Cupertino Miranda
Hi Anton,
> opcodes/
> * arc-dis.h: Wrap around in extern "C".
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] [ARC] C++ compatibility for arc-dis.h
2016-08-23 8:50 ` Nick Clifton
@ 2016-08-24 12:38 ` Claudiu Zissulescu
0 siblings, 0 replies; 3+ messages in thread
From: Claudiu Zissulescu @ 2016-08-24 12:38 UTC (permalink / raw)
To: Nick Clifton, Anton Kolesov, binutils
Cc: Francois.Bedard, Claudiu.Zissulescu, Cupertino Miranda
Committed.
Thank you for your review,
Claudiu
> -----Original Message-----
> From: Nick Clifton [mailto:nickc@redhat.com]
> Sent: Tuesday, August 23, 2016 10:50 AM
> To: Anton Kolesov <Anton.Kolesov@synopsys.com>;
> binutils@sourceware.org
> Cc: Francois.Bedard@synopsys.com; Claudiu.Zissulescu@synopsys.com;
> Cupertino Miranda <Cupertino.Miranda@synopsys.com>
> Subject: Re: [PATCH] [ARC] C++ compatibility for arc-dis.h
>
> Hi Anton,
>
> > opcodes/
> > * arc-dis.h: Wrap around in extern "C".
>
> Approved - please apply.
>
> Cheers
> Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-24 12:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-22 17:38 [PATCH] [ARC] C++ compatibility for arc-dis.h Anton Kolesov
2016-08-23 8:50 ` Nick Clifton
2016-08-24 12:38 ` Claudiu Zissulescu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).