From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id ECD4A3858409 for ; Fri, 21 Jul 2023 18:11:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECD4A3858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36LEFr2C000399 for ; Fri, 21 Jul 2023 18:11:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=z0N6jM5wWRXhYD/jOiC0WADYkHEaoZMNVwOAgi4zR5E=; b=pSCOdI4T1RBVGODVCpMxnHxiyXveDDR8m9M3n7kQK6XN44akVnFzlyXs2d3h1CiHhkZC 1hcO3VmiO1K8aXDCNFz5MoSO99jF9sVPa1Ej3HFsKhYLl989U6aPyAnQ3GQ3OoARDs2U R9Mi7wE/2jCs9xxUQkb1CCYCTqGX5LJhDotmG5KzL/NwO+MZ/mHALsSOcS5tcCWjdWwj mo7n4iyepVMO32htw0FU9B3xRhIQ6cjig7en6TxguJlNrSohKbIEdU/H1eUArHA7RX3e y6QGItFjN3Sm8fSMDLxMBCUzata4nb61FXibCABW2+95DuZcRGtYP0WGciCxOVfVAP3R UQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ry1m4k71e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 21 Jul 2023 18:11:19 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 36LH6tBO000760 for ; Fri, 21 Jul 2023 18:11:18 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2107.outbound.protection.outlook.com [104.47.55.107]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3ruhwab87p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 21 Jul 2023 18:11:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jsNvWyxfGKvB5OB+I+8gEpj76nYSSuMSK4fBROrcvW1+sTXxnR5n5sPByKJ2I9TsGciVmh6qhOTd5FbCckO5Oy/5bDM6AWdPxmiyGMv8k29RsrbeNNYkzzQW/Yo5ID2hcceWCMRNP+NhEI6PnoHymh4cYp+mR0g62j7tDGkH5aKLHF+tJJk9gi7yRhSaaRCRp95SptsgvetQV09LL+WUpzgJV7u+FUFLwGiU2XRXIyEmFybY6uAVP4E6zKZ4xEbGmLLD+m5q7CKROHqE1GIyOOzyEGa0kF7gmm5eFWLobwbtLo3tsXSJf9iJIFqyrOhHXsYew3ezx4uwGoCDVJgJyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z0N6jM5wWRXhYD/jOiC0WADYkHEaoZMNVwOAgi4zR5E=; b=Cpd6y53EzJF8qgSNULp/wpnDkEYzigQD9RAFiULhU+Px8Y/h4WzoTF1jNpHIfEk/L1TCLOcnvUJC4WbMiJTTGoWE4jOO4vAcEj2s9g/rIuaEz0ofRX8Dzu+yeyAiZnFRViYR4lknjYy2J53EW5E0cZ+qHTKnByczfJVlFFYVY28CT3mWfT8OlpeNWDmcitat8tawTips30ZDA8mAfn/bwsMhXsDt0p+ILg5DN92PkUt4fOxm2BxuQsPbRGCUikICtVEd4sCUFu200kNilwiS6Jr0o5+5ELAiluDgJOkA5Ig/+cnJLvQ+Q/rwECR4aVgFCfg8xWBNI0TGXNn+c8vQpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z0N6jM5wWRXhYD/jOiC0WADYkHEaoZMNVwOAgi4zR5E=; b=fPnLOyiSNi8ZpTm2IcVQ3CspumU2WmbJC+d5TVq0iWS8gM75bqcCOs5bYvbxPR9MBBCUmcfkMmWATTC3c5OEKWQXjSPlC6KBPqBu2HhZsj+P26hfaZu6x9rtVtj6AexbvIFpPkCAJgj+kV0rKLBbEBkl8taDgyZYy6VZWND4KTI= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by SN7PR10MB6570.namprd10.prod.outlook.com (2603:10b6:806:2a9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.28; Fri, 21 Jul 2023 18:11:16 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::4d0c:9857:9b42:2f6c]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::4d0c:9857:9b42:2f6c%4]) with mapi id 15.20.6609.026; Fri, 21 Jul 2023 18:11:15 +0000 From: "Jose E. Marchesi" To: David Faust Cc: binutils@sourceware.org Subject: Re: [PATCH] bpf: disasemble offsets of value 0 as "+0" In-Reply-To: <20230721175855.6460-1-david.faust@oracle.com> (David Faust's message of "Fri, 21 Jul 2023 10:58:55 -0700") References: <20230721175855.6460-1-david.faust@oracle.com> Date: Fri, 21 Jul 2023 20:11:05 +0200 Message-ID: <87fs5h5e4m.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO4P265CA0106.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c3::9) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|SN7PR10MB6570:EE_ X-MS-Office365-Filtering-Correlation-Id: 46e663a4-2f3b-4cfa-319d-08db8a15dfd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ATHnuKhMoPJDKDLaSCMQlgZ505R1DGDH6RJS/8y/0NqaycBVMa5TJKgJ6yJqHgbEkA0uW77Dr1s7zhAxn25CPCX7W6BkKvxz8eElqX3kdyQZNrUPI9bx3wmF8dv556Os9XVv4ilnX6+QJUTeqoOApRHSCBxqBl/2qi25Q81h1Zx6jA5aK4/o/z/VQr7/j/G0jQXpKiJOISwIN3vWeA4l7/aHKmBbmGH3D26cKd7nFxnaEM90dZV1PBfmnm+dxPHKygiRMjoYBiBQoJOyR//f+HKjOB3530L8n2pRT5MaXzx/D43RLEgwR7GRsiE2Qu8k63Ln4c7xiIS9vZUZyOD4STL1Yss4vYHQXAYbgDLPg4WBaJGJxXR9M7UPuClnqu/GNGw43mcJ4063d89jBNYn8df3Ds5mSDBXAQCRInSlE67pACOyaK0OAfk9ka9Whswq3H62wTF/sB85YssOCM7R7iRsGzmbQY0XAR1OvSnonpXGjFjuwFBds/UOynXlC3vQz6wE+7T2ZGVEJDf5riVwdKamGpGsJdU4tj1EZbKzH0IuoSH5Shws+DCd1X1P9G4z X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(376002)(346002)(39860400002)(451199021)(41300700001)(6506007)(186003)(26005)(478600001)(316002)(4326008)(6636002)(66556008)(66946007)(66476007)(6862004)(8936002)(8676002)(5660300002)(6666004)(6512007)(6486002)(37006003)(2616005)(2906002)(83380400001)(38100700002)(36756003)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?reAY7QUpUYudtJkk+jMJkIRYqviF86oxfdIT3s/aqwIXwz0pxpXNATaFKdjI?= =?us-ascii?Q?rpfM39mTfsiGuN01AN9TG7h+ZMQlCW0VFPUb1Ynd9Jv61Qtxn+KMJFTJTRjp?= =?us-ascii?Q?fUMddmBVLwruBXoMAJC21Nuk0XEY2m6ilFabzqOU+ErO8WwD0WtZO3lBGwTu?= =?us-ascii?Q?WTF/LzAM6zfkXKUMH2anNeN0EqKR+0spjqs8nmmcibvzsd//fYDZVv+bzOQk?= =?us-ascii?Q?OCaQrQO6jtf4smna88pnqcB3j4AeVyrxhEzyErWUcUmoASrEvYPZm5w2kjx5?= =?us-ascii?Q?vmvxzuuBXcThznMxLPJ4Lyey/1N5pOuOHgx5rqEaUyXu2zcbGUyGGABhlkvB?= =?us-ascii?Q?rzOXtjsFmHNFIqJ8FikdpNh1Hq5fU77RIqy9reHMWtmIaL+NbZWMQf4QpUuD?= =?us-ascii?Q?14w7t/SFibP+iRN9FmfLE7un4HiCpuY1tSjQNHo9T6e/mPdbCg3hIGD53FP2?= =?us-ascii?Q?4F3mai2dROtJl28iLU26Z0t7gVh4xvx8BsNLFUBoqjKr6hG5IhWjse6AH5q2?= =?us-ascii?Q?fH1o42QYvRW9Nv4Hz0gZawUtE0eq7WxAmNLRZCHCMsM/zWP6YAnK7X9GIG0U?= =?us-ascii?Q?tptXDBLkZvfLyUfEVHKp8JK0fvlxqUBJWLdfhpBmAf/Rf1L8KU+klwOmT+SI?= =?us-ascii?Q?9vKI5jgYaSSsQOpFpvine8CYCJQQ/NCRUxDJWF+0CPHP2w4F9qsK6jvtl96B?= =?us-ascii?Q?wwCVFJP68MlcH9yqR6kwQAV8JfB2+rO5y49PxiIFa+/qiIDGSApRzMrCIyWn?= =?us-ascii?Q?UcLxSN9bupJWIztn5qR/9Zl9oSnNq1aBWeUXbnWklsvIBRcT0ehpKZ3/s8Cd?= =?us-ascii?Q?egIcy4XaWUs8i3UKiRrBuOOFEGAsBY4ik/ifDMl+hFEylCbTPAx1RDKSmOz/?= =?us-ascii?Q?LhdvEC5SHYh5pWNRLU6kxCB8LBFH6x7/Jy1OTYyOSLSNmGQQjvz6wyD08D3Z?= =?us-ascii?Q?S6n3/YE88QVFsft8mGwwJdmhMYQvkTwAOG7S7dHmqwvQN+m9+TD5q/U/Tdxe?= =?us-ascii?Q?Uo20HH4h1jMbVe4JBypLwwyMCv+za3icb/JC3Y62LcU6l0E8OZ/q4gInzVAd?= =?us-ascii?Q?dCfH8A6aQPo8IOIE0LaZH6VOluauPAi5vwsjVG73Qv2AUaTjRSSOU4PCoVl5?= =?us-ascii?Q?0/AJXn6R8d1VP/zQ5fTcn0vWSH/vwtXonqeKSSCC2aSLBQ+xJN7y5bx525R+?= =?us-ascii?Q?JU7UKIaxW+IAPJlC+GQHVXkDFdnY/BiugLdbhkYWoZzhUtGY2I0kGINXSsTL?= =?us-ascii?Q?1QQA+pyNq54rijkVFKpJ3bdPrOLSGrZQBFmW5748slSJIQWaRxeuV0ikOQkZ?= =?us-ascii?Q?cmOiBKXFynnNCQnWmk3T9y8soEgIPT5i1uBy+LY0gspZc9LHKfKkdmRshObM?= =?us-ascii?Q?UzwKgSeV/LbTSNSeM2QW4IMxCS6J0X0OHZa42+1LdvEAnPJRNAJPng5t+xtP?= =?us-ascii?Q?1gT5Kzx3wroTtj33/NXXIPlfYMRQcgxzqqKUclKkO9BKRN1ocyRNYMVarJ2v?= =?us-ascii?Q?Ix1vJP3dV/QTa/Bh2B+jVf7U5suy22lfMP75ssJ2E4q83oE+ntdHLqHOAlY5?= =?us-ascii?Q?IyTSbGibKESWrE59zmglzFHOKEqo8IJSvp8hpKmS+sVh8PTAZvJ9EW3Hxcjb?= =?us-ascii?Q?JA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: rrU+jsGdyCzdA9vS+Omli5SagKjtsJ1Vp6JhStoS86RZzwxH+FRk2Xy4/4+80/Akp+PSv6Pn0iiNpOZ+UVqmN0246HLVfhJH7J0F7cMxGVZH+vYadf1VfMigAGIQXuXxzDxdl8BKWLYaf3o3DAqrsdWC3vWt7Cv7NpFbAD23BUkSK6VKxYHmr1pkmeq91kOQWnLlverZzkuVAY3SfICuDbVHCICQIO+V9zNR3vqWLdwqv4vzZvn50iNNlcAkv9NjiLzaaKKzvXqlqD44V7DVWSSmAVDAjd3svfa+oJvMt5bN7QZLUGKAJ+tcnOlQK03qAt2F0ilDW12m/sfzWmRCTkumt2w0wnYQevNNdq82/Wq8WqcPJGjNzwwJ7W9iaGpvLkMopUM1430TpTT14VQfFUJ6gNCIH237qywtsigEcRebl1HZB/Cz2D6w/gpfvv/5i6wQJDJKeaK3YBUs6vB70BJD4cXT8+Xpk9kmmMl5dIay861AIw7XJLbOahCPm5gC2H/ZXPOy2q0LMh9r4xgxc5gwv3zqqjgRmJte9lwUfRVd6JDwlH58uy8Y38ipLyQW1RvUkKDPPTVSIGZaldfSxZpR9vwhfTG3qzhQ45HL7ZBjcsoFWhqU+KGzcPejkBsWtOTLcq+dZsEXebwYhYccIlkeY/YbMl/2PjhhBilOvrSzaRjf8ciQWdcf0wKY50EayNs6yHAEoFBRuSrUXJKMi/UK69HuO8A00iE+V85LZFXnMecaexMSyt0oi3cDATqx X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46e663a4-2f3b-4cfa-319d-08db8a15dfd7 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2023 18:11:15.9168 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h60idsahy988n+lsJB7+vV2pDIiNr5eJh3kGyXOq8L9DNHbTEBLOFch2S1sg4t4bpXzmP4FgJwHieqot8r2jAFBsMwHWXPGqX3OVM4D+qIc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6570 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-21_10,2023-07-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999 suspectscore=0 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307210159 X-Proofpoint-GUID: lhgmfhWRoeO_aVm27aznBpy5gluzwHWn X-Proofpoint-ORIG-GUID: lhgmfhWRoeO_aVm27aznBpy5gluzwHWn X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > This tiny patch makes the BPF disassembler to emit, e.g. > > ldxdw %r1, [%r0+0] > > instead of > > ldxdw %r1, [%r00] Damn, /me dumb 8-) Thanks for picking this up. Yeah, but the fix should be done for %I32 as well. Also, we would need these cases in the mem.s test. > when the offset is 0, to avoid confusion. > > Tested on bpf-unknown-none. > Maybe obvious, but.. OK? > > Thanks. > > opcodes/ > > * bpf-dis.c (print_insn_bpf): Print 16-bit offsets with value 0 > as "+0". > --- > opcodes/bpf-dis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/opcodes/bpf-dis.c b/opcodes/bpf-dis.c > index a4dc3dc2523..bb63119e813 100644 > --- a/opcodes/bpf-dis.c > +++ b/opcodes/bpf-dis.c > @@ -231,7 +231,7 @@ print_insn_bpf (bfd_vma pc, disassemble_info *info) > if (p[1] == 'o') > (*info->fprintf_styled_func) (info->stream, dis_style_immediate, > "%s", > - asm_obase != 10 || offset16 > 0 ? "+" : ""); > + asm_obase != 10 || offset16 >= 0 ? "+" : ""); > if (asm_obase == 16 || asm_obase == 8) > (*info->fprintf_styled_func) (info->stream, dis_style_immediate, > asm_obase == 8 ? "0%" PRIo16 : "0x%" PRIx16,