From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 1675C3858C54 for ; Fri, 4 Nov 2022 12:10:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1675C3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A4B5J8e030348 for ; Fri, 4 Nov 2022 12:10:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : subject : references : date : in-reply-to : message-id : content-type : mime-version; s=corp-2022-7-12; bh=hmJQZXMXvXj35KULqra8YhTBJqHX6FvHxsx4tB+nWLo=; b=KPXPioIMvEIrcLRHsudvwUZv47L7XbAqofw3nwX1tzTOQ7yUQIEeTPfsnYHffnaxYLBS yhTBH13FYrMkV4KdW/1HLRaFGhhOTbY1BNQKBAIEvylcVZPAshmli1FgiG2TOsnSLagD RWSJDxy6ydYJQUzDXGCb9VnvKt47SPY/R/7ZrOXg8/p7bxQ7u4dJu0v2bEAv3hfn+aUy BXvx/Y+Kt5I1F8jSGw6HqTpLGEZQWWvmLeIkyh3Ef0UFkoqvGM8OruIsAmoVrqcWDkYf tJShg32jRAd5kiHZar//+WXTjqbZRHXRhscacSPnjQcILSdfJ62s9fKFcygtwaR5C/rY 0g== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kgty37nhc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 04 Nov 2022 12:10:34 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2A48oVgc031957 for ; Fri, 4 Nov 2022 12:10:33 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2174.outbound.protection.outlook.com [104.47.55.174]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kmqb66ywu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 04 Nov 2022 12:10:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OVY239nPq5tSQDcIiIABpgg+/IVeDa4uVwc/0we09/JG0gN6SlMPr2x3xlBu3S4wfpg92A3dfuIWNlR4xrZk63AFJB6ghzSTtcCRtXiFHeBd0h81xcu10uxUJBwk7Mn8eE1X7B9xjBbiUGRuoI8KhHs8Vz8210FK5pSDQaBwcX6sQoiBJl+WUV/9s2sMz6ewVNACgaZRd12bux36+VTplNO+HPOMK0lwyiUXPGPEhmAzpqRi7uGKOXs/skX4Q9C26IUcqxxx82ne0usA3EFCF5WSKWRD3fhv20nro6mTFRfy4isfZBt1hlpPLrXq1bHxMbh/kgjQ4mQ/wCQ0eNrVmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hmJQZXMXvXj35KULqra8YhTBJqHX6FvHxsx4tB+nWLo=; b=UUiIJjb/0dUE8R5IbHVe/73Fh51SXcCK/XPKhx/xAn1FkGYEAqk0aoeBVtK77s1CvnKR5L1jJMyuXIoRsQwv7xhc+06yXjvlBV09ZI31JV0UGiX05rsyA6sgsrbbH/G/DFROFIGFZZ8JaBLSnOIy15JQ0z/lgi07a9CmrNGw6C2+xoatP+06qkztJ2D9JpkSXsAOZSUFT9F1s19+1JUNGwSc12djbWXxaaCQ8dgK6gCe60H0ic3Yocgs85j9ZhhmPT+1Tr4ALO1HBNK/f92y9uE1vhtEz9YaaVJzcl3eICE9xAuIPwbe2ShdIhSJhzeibQCSZMCQk6O93d78W5Or0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hmJQZXMXvXj35KULqra8YhTBJqHX6FvHxsx4tB+nWLo=; b=v9tYLpmjV93zL5NjMPi3+o8PZtx/OA9FVg3+39tNWY8yVrr1bEjKwTMy7WqWJRuBr0CX0hLsl2JHyifbMhYynsPgb4BSAc0rYvN024CBNJPJayYUpcrCkGFMkXqhVSwvFHQKrQVJHOQQiwg4k1reQxcHue3DO9pzvsqWlPXb98Q= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by PH7PR10MB6531.namprd10.prod.outlook.com (2603:10b6:510:202::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Fri, 4 Nov 2022 12:10:31 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::5095:b148:8def:1049]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::5095:b148:8def:1049%5]) with mapi id 15.20.5791.020; Fri, 4 Nov 2022 12:10:31 +0000 From: "Jose E. Marchesi" To: binutils@sourceware.org Subject: Re: [PATCH, V3 10/15] gdb: sim: buildsystem changes to accommodate libsframe References: <20221030074450.1956074-1-indu.bhagat@oracle.com> <20221030074450.1956074-11-indu.bhagat@oracle.com> <0f7e9a96-61fb-22a2-f71e-f3bead83579e@oracle.com> <87iljxuq74.fsf@oracle.com> Date: Fri, 04 Nov 2022 13:14:34 +0100 In-Reply-To: (Mike Frysinger's message of "Thu, 3 Nov 2022 22:27:34 +0700") Message-ID: <87fseysyqd.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: AS9PR06CA0559.eurprd06.prod.outlook.com (2603:10a6:20b:485::23) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|PH7PR10MB6531:EE_ X-MS-Office365-Filtering-Correlation-Id: a9421bd5-ae91-4b7d-0cdd-08dabe5d9190 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 62chf7Qly+hh7K7MkdIYaPz0uT69Lzgy3AuN/S0YszofT0IzmlTRZF1ZiE8Qgy+9W3ZCHEfv1I+FtcLj9ymR6k3rp3vSK1soRmxag8deG6ZBgm2IyhzBS/8e4Dp9nUagQT/byN2fCuFVzDYRn55BZHoqmt2vXP2HtwijoVnCKbchTkObDj1Ro/kkCYQ+Eno77gY435TaK7Do2ePxSjTTnJ809hbpRjLlvOVZh7nlGdUrYWPmlEXkwXB3J/SVFSuZUtW60ICaww5Oh+VBnLdum+1inbHsoXUkmoVCbqhD+TATpIl/lWA7FiDa4odnjC3wOFA1iHFqB6m1hwCdrBO+rPj6A70eB3cLYs/cNYP+6VDvneCc4KzxGuhw4yj0GlORELWG7+UbNazf3Bd9mFSr20gOi/5j8w/lOp/mHxG3vVeIib7Zh6hT2RXDrcDW7403BgNWPOCV7cYokhF03ChgGFmueWSNfwQIfBXsjaxcjFJlyxAbCifiTvXDuyk0+HdpOIjmfwzDP9uNjj3CD/qPSnMXJA/1hhBLQws4Gm+bSTlDUbAuKGBf0oQF1ODwymdXw8EcnPtaM/3s4E8NkTTwzUgb/I9ttns6OI5IoKpyFJTxjBjgFGCKnbWtfKf+JuwNrLECn/3yqtGxX65Yp12D6MclMQIuORORGu2PQFH+Mx5RPYDfIug5vWAHuPi/Bi9BxXJXlb+5ndCHu0/QaAdF3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199015)(38100700002)(66556008)(66476007)(6916009)(8676002)(8936002)(2906002)(316002)(66946007)(41300700001)(5660300002)(6486002)(2616005)(53546011)(6506007)(26005)(186003)(83380400001)(6512007)(478600001)(86362001)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q+GrflOdtcXXqjPFDOQnARnPRr+3OOcN7hCx82vSFQxhg1gw/1Fc/P+Bj2PQ?= =?us-ascii?Q?+Qn+zWG2zk4NPG3T1ExLo4fXW4BeYGA2oYtRPMTLcPLDytKewebQcMKjK70j?= =?us-ascii?Q?7DAcVD59g8vWsnJSWPns/v9/nXhqfC3dwuI4bjL9OO87vK/igBfhFP2/bWeP?= =?us-ascii?Q?VJGq9SIfnE7gxv3Soz+0cCACHVAKRE6I2zglGLD+0d7eBKqUtG6pvxnXR3s6?= =?us-ascii?Q?DAu6UCwcpqhqhuOaPaZorVCdV5B7zezQwYl8wp/EALuD3CLOSxDQ9dvlWndA?= =?us-ascii?Q?ttBoCAZRoay8XozKDZWudSrzi/l449sem7g1Vn8Wjb8LQ8jwUS+T+abDfO3D?= =?us-ascii?Q?4ckP/HOSaKdFkvN4waObvs4UmKfnKLF4NvFTHOenWOhIBHrba0gjpI+OnXx4?= =?us-ascii?Q?fseJbaeT5boUw+rNBfNqP6Cnr+OCtm6spn0IIT4llTnOvlOwSxJyZ/G8zVfo?= =?us-ascii?Q?fMojT1GIkmFXyVH7hKFOlZ/3y8zxv5axKETVdN4Pa5//NWJ22oCzXUujRUW3?= =?us-ascii?Q?t2KAanNnFIUOySG8aqwyUQz1duVyz0oaDz2l0nziPfhq0SXXr+TeKuK9Asux?= =?us-ascii?Q?L0lWnMoLNfyU5Sho+/O36fCykejQDKaXh36mGztGaUuos4Bfq0htS5IIRdw5?= =?us-ascii?Q?6G8OKctPkor4HG01Gp2VnMLaj0UN0wWvfbb/Qg04kViYj/VkdtXGT5ZCceeE?= =?us-ascii?Q?M6YWYOpgSBmmRLXeM5W68MyZf/vS5aoaWKMVx9DoKIn8GRcXP0Uic/2owW/m?= =?us-ascii?Q?5ZiXeplECPyRZv+iyIYB2OxXdXPk/gnBCCQcKxQAKAc1EM2zuQRTjKRpfD5t?= =?us-ascii?Q?sXphZ5ITUMa5t/TTnycjzqLgJewo5/6h1meuA2/aIsTo28KaEfYFiOjTw4Qh?= =?us-ascii?Q?Xa+bDalpysOpUVAtd+9Bcn2YKqYG5fQwf6S5VaoH5SQ4TN6AUicvLLLF+mgH?= =?us-ascii?Q?vmIKv7pml75g5eBCX40OPJBNSiOHmfqUo5Adx1UB4IjQTJDhdFJki85S3cDP?= =?us-ascii?Q?XaF6bTI4+xLQjWQoCsn9sVw0KLTd6WvIzlz4dqL3rLCbvme1P76rLPt+bB3m?= =?us-ascii?Q?5YAoGx6CvEKhO0EvDqQ/b57YSVatWKxe07ip2OiYl003U9MuylMBKOBEH3E7?= =?us-ascii?Q?ajpWbUlvkko/SiAj3WfZMFxXinaxf1z6BcT153jxJWX/qfc7yoEkyBRvOJYZ?= =?us-ascii?Q?DMrD+51SXyVtrvlFlg/u4/5g7vOHiwiHDILA/fHnn+QQnILj8pAdHBcWjWVH?= =?us-ascii?Q?4l+XGUN0YoSLkORe1Mw+51jzKP0tO0pRm7hstzl00egAkyHkfTdWgxUs0zkm?= =?us-ascii?Q?SvkYnNv10OXmaexRoZJBmqn+J8qokOlINybbx02OQyHOrmzrVhS6vyivEbBM?= =?us-ascii?Q?D1+ku5QNQZjPVtUboY/I1pS8tQmUGxwSeAUAlu3/aYbuinulX2ktFdBI4oIE?= =?us-ascii?Q?6DpWlWnVhB6pw56MdfbnGY/BY0yB6oMKBl0Jpy4ZgbtlUe8rHZ2IKcMDdoW5?= =?us-ascii?Q?G4Q/Mv7iWQEJeWX9Ly7cu+GLGI26BAOHZFWcLtdnPq41PrVvpPTTuoJECOJt?= =?us-ascii?Q?XH6yfSYdWwZhTdIaa2qTNx52opttalWfCm7UDmjOzYuhh2HOrnBeauC/1Uk8?= =?us-ascii?Q?qg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9421bd5-ae91-4b7d-0cdd-08dabe5d9190 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2022 12:10:31.3000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IkbsmVp+GVbCZ38hG5/d4VdYifAFT+14IUDL5mtozLNmlowVndFxcr+ok8pbj1VnJxYMRA3BqMXYtMhf5GCdJFKxV9sFWuvTpqyQIzBT7rU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6531 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-04_07,2022-11-03_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211040082 X-Proofpoint-ORIG-GUID: U_M0coDdUki8vxgYCAJB05Ia8KliDb1O X-Proofpoint-GUID: U_M0coDdUki8vxgYCAJB05Ia8KliDb1O X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 02 Nov 2022 20:11, Jose E. Marchesi wrote: >> >> Hi Mike, Indu. >> >> >> > On 30 Oct 2022 00:44, Indu Bhagat via Binutils wrote: >> >> >> [Changes in V3] >> >> >> - Additional diff in sim/ppc/Makefile.in to accommodate libsframe. >> >> >> This is needed to ensure --enable-targets=all continues to build. >> >> >> - Addressed review comments by Mike Frysinger. >> >> > >> >> > this doesn't seem to actually address my comments. you're still poking >> >> > the internals of libtool by accessing files under .libs/. >> >> >> >> gdb does not use libtool yet. >> > >> > you have access to the source. you can change these things. >> > >> > also, gdb & sim are sep projects. >> >> I see gdb/configure.ac uses the same strategy in order to locate the >> in-tree libbacktrace.a and libctf: >> >> if test "${enable_libbacktrace}" = "yes"; then >> LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/" >> LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a >> AC_DEFINE(HAVE_LIBBACKTRACE, 1, [Define if libbacktrace is being used.]) >> else >> LIBBACKTRACE_INC= >> LIBBACKTRACE_LIB= >> fi >> >> [...] >> >> if test x${enable_static} = xno; then >> LIBCTF="-Wl,--rpath,../libctf/.libs ../libctf/.libs/libctf.so" >> CTF_DEPS="../libctf/.libs/libctf.so" >> else >> LIBCTF="../libctf/.libs/libctf.a" >> CTF_DEPS="$LIBCTF" >> fi >> >> With corresponding substitutions in gdb/Makefile.in. >> >> I agree it would be better to have GDB libtoolized so it could refer to >> the .la libraries directly thus avoiding internals, but could that be >> done in a separated patch set, also covering the other cases? >> >> In the meanwhile, Indu could change her patch in order to look for >> libsframe.so in gdb/configure.ac instead of gdb/Makefile.in, as it is >> done for the other libs. Then we libtoolize. > > "the code is already in bad shape, so let's add more kindle to the fire" > isn't a great strategy. hoping someone else will come and clean up the > mess also isn't a great strategy ... usually that means it never gets > cleaned up, and the tech debt just continues to build. so "let's do > this as a followup" almost always translates into "i don't want to do > it, and it's never actually going to happen, so let me merge anyways". > i'm not saying that's necessarily the intention of the person making > such a request, just that that's the practical result in my experience > in the vast majority of cases. people, no matter how well intentioned, > are busy, so without any pressing leverage (like "this is required if > you want to merge"), it never improves. > > to be clear, i'm not a global gdb maintainer, so if you can convince > one of them, then certainly they override. i am NAKing adding any > such hacks to the sim code though. although that's a bit moot since > i've already posted patches to clean up its libtool usage which means > it doesn't need any changes for libsframe logic. > -mike I'm following up in gdb-patches@.